Re: [Bug: 21.5-b26] Options->Font Menu raises an error
Giacomo Boffi <giacomo.boffi(a)polimi.it> wrote:
i clicked on the "Options" entry in the menu-bar, and i
moved the
mouse doenward
when i reached the "Font" entry, an error was raised (the same happens
eith "Font Size"):
(6) (event/warning) Error during menu callback: (wrong-type-argument (devicep
#<x-frame "XEmacs" 0x2a77a>))
It looks like this happens because x-font-menu-font-data-xft expects its
DOMAIN parameter to be a device, but x-font-menu-font-data passes
(selected-frame) if font-menu-this-frame-only-p is non-nil. If you
evaluate this version of the function, does the problem go away?
(defun x-font-menu-font-data (face dcache)
(let* ((case-fold-search t)
(domain (if font-menu-this-frame-only-p
(selected-frame)
(selected-device)))
(name (font-instance-name (face-font-instance face domain))))
(if (featurep 'xft-fonts)
(if (xlfd-font-name-p name)
;; #### this call to x-font-menu-font-data-core originally
;; had 4 args, and that's probably the right way to go
(x-font-menu-font-data-core face dcache)
(x-font-menu-font-data-xft face dcache name (selected-device)))
;; #### this one, too
(x-font-menu-font-data-core face dcache))))
Regards,
--
Jerry James, Assistant Professor james(a)xemacs.org
Computer Science Department http://www.cs.usu.edu/~jerry/
Utah State University