1:40 p.m.
This bug report will be sent to the XEmacs Development Team,
not to your local site managers!!
Please write in English, because the XEmacs maintainers do not have
translators to read other languages for them.
Please describe as succinctly as possible:
- What happened.
- What you thought should have happened.
- Precisely what you were doing at the time.
Please also include any C or lisp back-traces that you may have.
================================================================
Dear Bug Team!
It's an admittedly minor inconsistency, but irritating: by default,
M-q is bound to fill-paragraph-or-region; cc-mode rebinds it to
c-fill-paragraph, which I find very useful (when I call it in a
comment, c-fill-paragraph stops reformatting at the boundaries of that
comment while fill-paragraph-or-region assimilates the surrounding
code as well), but cperl-mode doesn't... Since cperl-mode already has
a cperl-fill-paragraph function (doing what I want), I think it should
also bind cperl-fill-paragraph to M-q by default. Any objections?
Bye
Vasek
================================================================
System Info to help track down your bug:
---------------------------------------
uname -a: Linux linux 2.4.0 #3 Sun Jan 28 20:49:46 GMT 2001 i686 unknown
./configure '--with-mule'
XEmacs 21.5-b3 "asparagus" configured for `i686-pc-linux'.
Compilation / Installation:
Source code location: /usr/local/cvs.src/xemacs/xemacs-21.5
Installation prefix: /usr/local
Operating system description file: `s/linux.h'
Machine description file: `m/intel386.h'
Compiler: gcc -g -O3 -Wall -Wno-switch -Winline
-Wmissing-prototypes -Wshadow -Wsign-compare
Relocating allocator for buffers: no
GNU version of malloc: yes
- Using Doug Lea's new malloc from the GNU C Library.
Window System:
Compiling in support for the X window system:
- X Windows headers location: /usr/X11/include
- X Windows libraries location: /usr/X11/lib
- Handling WM_COMMAND properly.
Compiling in support for the Athena widget set:
- Athena headers location: X11/Xaw
- Athena library to link: Xaw
Using Lucid menubars.
Using Lucid scrollbars.
Using Athena dialog boxes.
Using Athena native widgets.
TTY:
Compiling in support for ncurses.
Compiling in support for GPM (General Purpose Mouse).
Images:
Compiling in support for GIF images (builtin).
Compiling in support for XPM images.
Compiling in support for PNG images.
Compiling in support for JPEG images.
Compiling in support for TIFF images.
Sound:
Compiling in support for sound (native).
Compiling in support for ESD (Enlightened Sound Daemon).
Databases:
Compiling in support for Berkeley database.
Compiling in support for GNU DBM.
Internationalization:
Compiling in support for Mule (multi-lingual Emacs).
Compiling in support for XIM (X11R5+ I18N input method).
- Using raw Xlib to provide XIM support.
Mail:
Compiling in support for "dot-locking" mail spool file locking method.
Other Features:
Compiling in support for dynamic shared object modules.
Compiling in support for extra debugging code.
WARNING: ---------------------------------------------------------
WARNING: Compiling in support for runtime error checking.
WARNING: XEmacs will run noticeably more slowly as a result.
WARNING: Error checking is on by default for XEmacs beta releases.
WARNING: ---------------------------------------------------------
Load-Path Lisp Shadows:
----------------------
nil
Installed XEmacs Packages:
-------------------------
((xemacs-base:version 1.55 :type regular)
(w3 :version 1.2 :type regular)
(vm :version 6.96 :type regular)
(semantic :version 1.1 :type regular)
(psgml :version 1.23 :type regular)
(prog-modes
:version
1
.42
:type
single-file)
(net-utils :version 1.23 :type single-file)
(mew :version 1.14 :type regular)
(mail-lib :version 1.39 :type regular)
(igrep :version 1.08 :type regular)
(fsf-compat :version 1.09 :type single-file)
(efs :version 1.26 :type regular)
(edit-utils :version 1.7 :type single-file)
(ediff :version 1.33 :type regular)
(edebug :version 1.14 :type regular)
(dired :version 1.11 :type regular)
(cc-mode :version 1.26 :type regular)
(mule-base :version 1.39 :type regular)
(leim :version 1.17 :type regular))
Features:
--------
(mail-abbrevs xemacsbug shadow sendmail compile cperl-mode view-less
view hyper-apropos cus-edit cus-load font-lock cc-mode cc-align
cc-cmds cc-engine cc-styles cc-langs cc-vars wid-edit cc-menus imenu
cc-defs efs-cu cus-face overlay remem xemacs-base-autoloads
w3-autoloads vm-autoloads semantic-autoloads psgml-autoloads
prog-modes-autoloads net-utils-autoloads mew-autoloads
mail-lib-autoloads igrep-autoloads fsf-compat-autoloads efs-autoloads
edit-utils-autoloads ediff-autoloads edebug-autoloads dired-autoloads
cc-mode-autoloads mule-base-autoloads leim-autoloads src-autoloads
loadhist auto-show fontl-hooks x-iso8859-1 slovenian czech romanian
ccl mule-help code-cmds gutter-items menubar-items x-menubar
mode-motion mouse itimer auto-save lisp-mode easymenu iso8859-1 page
buff-menu lib-complete cus-file derived frame text-props obsolete
cus-start custom widget cl-extra mini-cl cl cl-19 packages backquote
very-early-lisp file-coding mule lucid-scrollbars cut-buffer
lucid-menubars athena-dialogs x c-balloon-help tty-frames tty toolbar
esd-sound native-sound scrollbar unix-processes multicast
network-streams subprocesses modules menu-accelerator-support menubar
berkeley-db dbm md5 xemacs xim gutter tiff png gif jpeg xpm xbm
lisp-float-type linux dialog devices window-system base64)
Recent keystrokes:
-----------------
C-x C-f c o r e TAB l o c u s / l m TAB c TAB RET misc-user
C-h k M-q button1 button1up C-x C-f BS BS BS BS BS
BS BS BS BS BS BS BS BS BS BS BS BS w o r d m i TAB
y a TAB i TAB TAB button1 button1up RET C-x ` button1
button1up C-x 1 C-h k M-q M-x r e p o r t - x e TAB
RET
Recent messages (most recent first):
-----------------------------------
Loading mail-abbrevs...
Loading xemacsbug...done
Loading xemacsbug...
No compilation started!
Loading compile...done
Loading compile...
Scanning for "hard" Perl constructions... done
Scanning for "hard" Perl constructions...
Loading cperl-mode...done
Loading cperl-mode...
Making completion list...
Loading view-less...done
Loading view-less...
Loading cus-edit...done
Loading customization dependencies...done
Loading customization dependencies...
Loading cus-edit...
Loading cc-mode...done
Loading cc-mode...
Loading efs-cu...done
10:17 a.m.
Vaclav Barta <vbar(a)comp.cz> writes:
It's an admittedly minor inconsistency, but irritating: by
default,
M-q is bound to fill-paragraph-or-region; cc-mode rebinds it to
c-fill-paragraph, which I find very useful (when I call it in a
comment, c-fill-paragraph stops reformatting at the boundaries of that
comment while fill-paragraph-or-region assimilates the surrounding
code as well), but cperl-mode doesn't... Since cperl-mode already has
a cperl-fill-paragraph function (doing what I want), I think it should
also bind cperl-fill-paragraph to M-q by default. Any objections?
You should bind cperl-fill-paragraph to
fill-paragraph-function, not directly changing M-q. That
way, every key binding of fill-paragraph-or-region will
be changed to use cperl-fill-paragraph.
Except that point, I agree it is a good change. Would you
care to post a patch to xemacs-patches?
--
Yoshiki Hayashi
12:21 p.m.
>>>> "Yoshiki" == Yoshiki Hayashi
<yoshiki(a)xemacs.org> writes:
Yoshiki> Vaclav Barta <vbar(a)comp.cz> writes:
> It's an admittedly minor inconsistency, but irritating: by
default,
> M-q is bound to fill-paragraph-or-region; cc-mode rebinds it to
> c-fill-paragraph, which I find very useful (when I call it in a
> comment, c-fill-paragraph stops reformatting at the boundaries of that
> comment while fill-paragraph-or-region assimilates the surrounding
> code as well), but cperl-mode doesn't... Since cperl-mode already has
> a cperl-fill-paragraph function (doing what I want), I think it should
> also bind cperl-fill-paragraph to M-q by default. Any objections?
Yoshiki> You should bind cperl-fill-paragraph to
Yoshiki> fill-paragraph-function, not directly changing M-q. That
Yoshiki> way, every key binding of fill-paragraph-or-region will
Yoshiki> be changed to use cperl-fill-paragraph.
Yoshiki> Except that point, I agree it is a good change. Would you
Yoshiki> care to post a patch to xemacs-patches?
It should probably also be submitted upstream to
Ilya Zakharevich <ilya(a)math.mps.ohio-state.edu>
BTW, what's the right way to report cperl-mode bugs?
Adrian
Yoshiki> --
Yoshiki> Yoshiki Hayashi
--
Adrian Aichner
mailto:adrian＠xemacs.org
http://www.xemacs.org/
4:43 a.m.
Adrian Aichner <adrian(a)xemacs.org> writes:
Yoshiki> Except that point, I agree it is a good change.
Would you
Yoshiki> care to post a patch to xemacs-patches?
It should probably also be submitted upstream to
Ilya Zakharevich <ilya(a)math.mps.ohio-state.edu>
Is he still maintaining cperl-mode? I thought he was too
busy to maintain it and XEmacs Development Team took over
the maintenance. Maintainer comment in cperl-mode.el agrees
with what I thought.
Vaclav Barta <vbar(a)comp.cz> writes:
You mean like (setq fill-paragraph-function
'cperl-fill-paragraph) ? That doesn't work (M-q still calls
fill-paragraph-or-region)... Perhaps I'm putting it in the wrong
place (I certainly don't understand how cperl-mode initializes
itself), but uncommenting the (cperl-define-key "\M-q"
'cperl-fill-paragraph) in the same place (cperl-mode-map
initialization) works OK...
Did you eval setq in scratch buffer? Then it won't work.
You have to eval it in a buffer because
fill-paragraph-function is a buffer local variable. Switch
buffer to where you are visiting perl program and then type
M-: (setq fill-paragraph-function 'cperl-fill-paragraph)
It is OK that M-q calls fill-paragraph-or-region. If you
look at the doc string of fill-paragraph-function, you'll
find this:
Documentation:
Mode-specific function to fill a paragraph, or nil if there is none.
If the function returns nil, then `fill-paragraph' does its normal work.
> Except that point, I agree it is a good change. Would you
> care to post a patch to xemacs-patches?
You'll have far more trouble explaining to me how to make a xemacs
patch than making the one-line change yourselves - but if you
insist...:-)
The suggested change is to call
(setq fill-paragraph-function 'cperl-fill-paragraph)
inside cperl-mode function.
Then take the unified diff between old and new files by
using diff -u. You also need to write the changelog for it
(see xemacs-patches and other ChangeLog for how to write it)
and send it to xemacs-patches. It is also helpful to add
small sample perl file which is formatted incorrectly before
the change and will be formatted correctly after the change.
It is not mandatory but it will significantly speed up the
review process.
If all goes well, Steve Youngs will apply the patch and
release a new package.
Even if it is a single line change, it is always good to
have more people involved in the development. Also, if you
add test cases to a patch, it will make developer's life
easier because he/she won't need to write test case and see
the change is working correctly.
--
Yoshiki Hayashi
5:27 a.m.
>>>> "Yoshiki" == Yoshiki Hayashi
<yoshiki(a)xemacs.org> writes:
Yoshiki> Is he still maintaining cperl-mode?
IIRC, yes.
Yoshiki> I thought he was too busy to maintain it and XEmacs
Yoshiki> Development Team took over the maintenance. Maintainer
Yoshiki> comment in cperl-mode.el agrees with what I thought.
For us, yes. But we're not the primary source as we are for (eg)
edict and footnote. IIRC, Ilya (a) disagreed with a change somebody
here decided was required, and (b) didn't want to deal with XEmacs
bureaucracy to take over XEmacs maintenance himself, that's all.
I could be wrong. We should figure out how to document this kind of
case, though. Eg, similar deal with JDE, although Paul K is much more
obviously active as a maintainer, and JDE activity level is much
higher, so confusion is unlikely.
Suggestions? Steve Y.?
--
Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Don't ask how you can "do" free software business;
ask what your business can "do for" free software.
7:41 a.m.
>>>> "Stephen" == Stephen J Turnbull
<stephen(a)xemacs.org> writes:
>>>> "Yoshiki" == Yoshiki Hayashi
<yoshiki(a)xemacs.org> writes:
Yoshiki> Is he still maintaining
cperl-mode?
Stephen> IIRC, yes.
Yoshiki> I thought he was too busy to maintain it and XEmacs
Yoshiki> Development Team took over the maintenance. Maintainer
Yoshiki> comment in cperl-mode.el agrees with what I thought.
Last time I contacted Ilya, he said that he wouldn't have much time
for cperl-mode, but he still welcomed patches.
I think we should still send patches to Ilya when we apply them to our
prog-modes package (to cperl-mode.el).
Stephen> For us, yes. But we're not the primary source as we are
Stephen> for (eg) edict and footnote. IIRC, Ilya (a) disagreed
Stephen> with a change somebody here decided was required, and (b)
Stephen> didn't want to deal with XEmacs bureaucracy to take over
Stephen> XEmacs maintenance himself, that's all.
Stephen> I could be wrong. We should figure out how to document
Stephen> this kind of case, though. Eg, similar deal with JDE,
Yep.
Stephen> although Paul K is much more obviously active as a
Stephen> maintainer, and JDE activity level is much higher, so
Stephen> confusion is unlikely.
Stephen> Suggestions? Steve Y.?
Stephen> --
Stephen> Institute of Policy and Planning Sciences
http://turnbull.sk.tsukuba.ac.jp
Stephen> University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573
JAPAN
Stephen> Don't ask how you can "do" free software
business;
Stephen> ask what your business can "do for" free
software.
--
Adrian Aichner
mailto:adrian＠xemacs.org
http://www.xemacs.org/
9 a.m.
Adrian Aichner writes:
>>>>> "Stephen" == Stephen J Turnbull
<stephen(a)xemacs.org> writes:
>>>>> "Yoshiki" == Yoshiki Hayashi <yoshiki(a)xemacs.org>
writes:
Yoshiki> Is he still maintaining cperl-mode?
Stephen> IIRC, yes.
Yoshiki> I thought he was too busy to maintain it and XEmacs
Yoshiki> Development Team took over the maintenance. Maintainer
Yoshiki> comment in cperl-mode.el agrees with what I thought.
Last time I contacted Ilya, he said that he wouldn't have much time
for cperl-mode, but he still welcomed patches.
I think we should still send patches to Ilya when we apply them to our
prog-modes package (to cperl-mode.el).
is anyone actively involved with cperl-mode ??
i would consider looking after it
there was a few additions i thought would be useful last time i looked
at the code
--
-------------------------------------------------------------------------
Peter (Rendhalver)
XEmacs Advocate http://www.xemacs.org/
Perl Hacker http://www.perl.com/
Apache God http://httpd.apache.org/
FreeBSD Devote http://www.FreeBSD.org/
rendhalver(a)users.sourceforge.net
do not try and bend the spoon, thats impossible.
but try to realise the truth.
and that is?
there is no spoon.
- Neo and child Prodigy
- The Matrix
-------------------------------------------------------------------------
9:26 a.m.
>>>> "Peter" == Peter Brown
<rendhalver(a)users.sourceforge.net> writes:
Peter> Adrian Aichner writes:
> >>>>> "Stephen" == Stephen J Turnbull
<stephen(a)xemacs.org> writes:
>
> >>>>> "Yoshiki" == Yoshiki Hayashi
<yoshiki(a)xemacs.org> writes:
Yoshiki> Is he still maintaining
cperl-mode?
>
Stephen> IIRC, yes.
>
Yoshiki> I thought he was too busy to maintain it
and XEmacs
Yoshiki> Development Team took over the maintenance. Maintainer
Yoshiki> comment in cperl-mode.el agrees with what I thought.
>
>> Last time I contacted Ilya, he said that he
wouldn't have much time
>> for cperl-mode, but he still welcomed patches.
>
>> I think we should still send patches to Ilya
when we apply them to our
>> prog-modes package (to cperl-mode.el).
Peter> is anyone actively involved with cperl-mode ??
Hi Peter,
I did the last sync of cperl-mode with Ilya's current version:
2000-06-25 Adrian Aichner <aichner(a)ecf.teradyne.com>
* cperl-mode.el (cperl-perldoc): Make function work under XEmacs.
(cperl-version): sync with version 4.32 of Ilya Zakharevich
<ilya(a)math.ohio-state.edu>
A number of people have made contributions since then.
Please consult
XEmacs\packages\xemacs-packages\prog-modes\ChangeLog
for details.
You're most welcome to make contributions.
Peter> i would consider looking after it
Peter> there was a few additions i thought would be useful last
Peter> time i looked at the code
What additions were you thinking about?
Best regards,
Adrian
Peter> --
Peter> -------------------------------------------------------------------------
Peter> Peter (Rendhalver)
Peter> XEmacs Advocate http://www.xemacs.org/
Peter> Perl Hacker http://www.perl.com/
Peter> Apache God http://httpd.apache.org/
Peter> FreeBSD Devote http://www.FreeBSD.org/
Peter> rendhalver(a)users.sourceforge.net
Peter> do not try and bend the spoon, thats impossible.
Peter> but try to realise the truth.
Peter> and that is?
Peter> there is no spoon.
Peter> - Neo and child Prodigy
Peter> - The Matrix
Peter> -------------------------------------------------------------------------
--
Adrian Aichner
mailto:adrian＠xemacs.org
http://www.xemacs.org/
2:17 a.m.
|--==> "SJT" == Stephen J Turnbull <stephen(a)xemacs.org> writes:
SJT> IIRC, Ilya (a) disagreed with a change somebody here decided was
SJT> required, and (b) didn't want to deal with XEmacs bureaucracy to
SJT> take over XEmacs maintenance himself, that's all.
SJT> I could be wrong. We should figure out how to document this kind of
SJT> case, though.
I'm really not sure what to say about this in general terms because
each case is different. What I can say is that my primary aim is to
respect the wishes of the maintainer first and foremost.
--
|---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---|
| XEmacs - It's not just an editor. |
| It's a way of life. |
|------------------------------------<youngs(a)xemacs.org>---|
6:06 a.m.
|--==> "YH" == Yoshiki Hayashi <yoshiki(a)xemacs.org> writes:
YH> If all goes well, Steve Youngs will apply the patch and
YH> release a new package.
I'll keep an eye open for it. :-)
--
|---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---|
| XEmacs - It's not just an editor. |
| It's a way of life. |
|------------------------------------<youngs(a)xemacs.org>---|
8:22 p.m.
Yoshiki Hayashi wrote:
Vaclav Barta <vbar(a)comp.cz> writes:
> You mean like (setq fill-paragraph-function
> 'cperl-fill-paragraph) ? That doesn't work (M-q still calls
> fill-paragraph-or-region)... Perhaps I'm putting it in the
Did you eval setq in scratch buffer? Then it won't work.
No, I changed
cperl-mode.el and restarted (bad Windows
habits:-) ) xemacs. With (setq fill-paragraph-function
'cperl-fill-paragraph) in cperl-mode.el, fill-paragraph-function
*is* 'cperl-fill-paragraph after I open a Perl file.
You have to eval it in a buffer because
fill-paragraph-function is a buffer local variable. Switch
buffer to where you are visiting perl program and then type
M-: (setq fill-paragraph-function 'cperl-fill-paragraph)
It is OK that M-q calls fill-paragraph-or-region. If you
No, it's not -
fill-paragraph-or-region ruins the code (even after
I set it explicitly as described above). I also note that cc-mode
does not use fill-paragraph-function either - the decision is
explicitly commented, but the comment is rather vague (it's
surprisingly hard to write a useful comment... :-) ).
I'm attaching a patch as a dry run - this is what does *not* work.
Putting the point into the multi-line comment (say, on ':') of the test
file (also attached) and pressing M-q will format all
the rest of the file as a comment (with or without the patch).
Even if it is a single line change, it is always good to
have more people involved in the development. Also, if you
I know *every* change
should be reviewed - but this is the first
time I see it in practice... Not having a budget does have its
advantages...:-)
Bye
Vasek
--- cperl-mode.el Mon Dec 3 20:57:07 2001
+++ xemacs-packages/lisp/prog-modes/cperl-mode.el Tue Dec 4 19:57:06 2001
＠＠ -2108,6 +2108,7 ＠＠
[(control meta |)])
;;(cperl-define-key "\M-q" 'cperl-fill-paragraph)
;;(cperl-define-key "\e;" 'cperl-indent-for-comment)
+ (setq fill-paragraph-function 'cperl-fill-paragraph)
(if cperl-xemacs-p
(progn
(cperl-define-key 'backspace 'cperl-electric-backspace)
9:50 a.m.
Vaclav Barta <vbar(a)comp.cz> writes:
> You have to eval it in a buffer because
> fill-paragraph-function is a buffer local variable. Switch
> buffer to where you are visiting perl program and then type
> M-: (setq fill-paragraph-function 'cperl-fill-paragraph)
> It is OK that M-q calls fill-paragraph-or-region. If you
No, it's not - fill-paragraph-or-region ruins the code (even after
I set it explicitly as described above). I also note that cc-mode
does not use fill-paragraph-function either - the decision is
explicitly commented, but the comment is rather vague (it's
surprisingly hard to write a useful comment... :-) ).
I'm attaching a patch as a dry run - this is what does *not* work.
Putting the point into the multi-line comment (say, on ':') of the test
file (also attached) and pressing M-q will format all
the rest of the file as a comment (with or without the patch).
Thanks for the patch and test.pl. I tested it and it
doesn't work here either. The problem is that
fill-paragraph-function should return non-nil when it does
actual filling work but cperl-fill-paragraph always returns
nil. Probably the function is only designed for replacing
M-q and not for fill-paragraph-function. But binding
fill-paragraph-function is the right way to achieve the same
goal so I suggest you also change that function to return t.
> Even if it is a single line change, it is always good to
> have more people involved in the development. Also, if you
I know *every* change should be reviewed - but this is the first
time I see it in practice... Not having a budget does have its
advantages...:-)
Yeah, but we need more volunteers to review and apply all of
the patches. ;-)
--
Yoshiki Hayashi
8:26 p.m.
Yoshiki Hayashi wrote:
doesn't work here either. The problem is that
fill-paragraph-function should return non-nil when it does
actual filling work but cperl-fill-paragraph always returns
nil. Probably the function is only designed for replacing
M-q and not for fill-paragraph-function. But binding
fill-paragraph-function is the right way to achieve the same
goal so I suggest you also change that function to return t.
OK, I followed both
your suggestions, it works, I'm sending
a patch. Note that cperl-mode.el still rebinds M-q, for some
versions of xemacs - I don't think I should be changing anything
there...
Bye
Vasek
P.S.: To recap: To see the difference before and after the patch,
open the attached test file.pl (in cperl-mode, which should happen
by default), put the point into the multi-line comment (say, on
':') of the attached test file and press M-q (which should be
bound to fill-paragraph-or-region).
--- cperl-mode.el Mon Dec 3 20:57:07 2001
+++ xemacs-packages/lisp/prog-modes/cperl-mode.el Wed Dec 5 19:58:47 2001
＠＠ -2619,6 +2619,7 ＠＠
'(t (cperl-fontify-syntaxically))
'(t)))))
(make-local-variable 'cperl-old-style)
+ (setq fill-paragraph-function 'cperl-fill-paragraph)
(or (fboundp 'cperl-old-auto-fill-mode)
(progn
(fset 'cperl-old-auto-fill-mode (symbol-function 'auto-fill-mode))
＠＠ -5269,7 +5270,7 ＠＠
(delete-char -1))))))))
;; Stolen from lisp-mode with a lot of improvements
-
+;; 5Dec2001: modified to always return t
(defun cperl-fill-paragraph (&optional justify iteration)
"Like \\[fill-paragraph], but handle CPerl comments.
If any of the current line is a comment, fill the comment or the
＠＠ -5352,7 +5353,8 ＠＠
(setq comment-column c)
(indent-for-comment)
;; Repeat once more, flagging as iteration
- (cperl-fill-paragraph justify t)))))))
+ (cperl-fill-paragraph justify t))))))
+ t)
(defun cperl-do-auto-fill ()
;; Break out if the line is short enough
2001-12-05 Vaclav Barta <vbar(a)comp.cz>
* cperl-mode.pl: Got fill-paragraph-or-region to use
cperl-fill-paragraph.
9:22 p.m.
Yoshiki Hayashi wrote:
Vaclav Barta <vbar(a)comp.cz> writes:
> also bind cperl-fill-paragraph to M-q by default. Any
You should bind cperl-fill-paragraph to
fill-paragraph-function, not directly changing M-q. That
You mean like (setq
fill-paragraph-function
'cperl-fill-paragraph) ? That doesn't work (M-q still calls
fill-paragraph-or-region)... Perhaps I'm putting it in the wrong
place (I certainly don't understand how cperl-mode initializes
itself), but uncommenting the (cperl-define-key "\M-q"
'cperl-fill-paragraph) in the same place (cperl-mode-map
initialization) works OK...
Except that point, I agree it is a good change. Would you
care to post a patch to xemacs-patches?
You'll have far more trouble explaining
to me how to make a xemacs
patch than making the one-line change yourselves - but if you
insist...:-)
Bye
Vasek
8176
days inactive
8179
days old
13 comments
7 participants
participants (7)
-
Adrian Aichner -
Adrian Aichner -
Peter Brown -
Stephen J. Turnbull -
Steve Youngs -
Vaclav Barta -
Yoshiki Hayashi