[Q] Re: [PATCH] [21.4R21.5] xemacs-packages/hm--html-menus enable compilation without 'menubar

QUERY [ cited in full for the benefit of others ] |--==> "smikes" == Samuel Mikes <smikes(a)cubane.com&gt; writes: smikes> Extremely dodgy fix. Saying something like this really doesn't fill me with confidence. smikes> Unprotected, the require causes top-level smikes> forms in hm--html-menu.el to be evaluated; some of these forms smikes> reference menubar functions, such as get-popup-menu-response on line smikes> 812. Compilation of hm--html-mode.el fails, stopping compilation of smikes> the entire package tree. smikes> As it turns out, hm--html-mode does not actually require smikes> hm--html-menu for compilation. The patch below is a hedge: the smikes> require may be necessary at runtime. I am unable to test this smikes> package: somebody with menubars, please test just dropping the smikes> require, which would be a much cleaner change. smikes> xemacs-packages/hm--html-menus/ChangeLog addition: smikes> 2002-03-06 Samuel Mikes <smikes(a)cubane.com&gt; smikes> * hm--html-mode.el (require): don't require 'hm--html-menu at smikes> compilation; enables compilation on systems with no menubars smikes> packages source patch: smikes> Diff command: cvs -q diff -u smikes> Files affected: xemacs-packages/hm--html-menus/hm--html-mode.el smikes> Index: xemacs-packages/hm--html-menus/hm--html-mode.el smikes> =================================================================== smikes> RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/hm--html-menus/hm--html-mode.el,v smikes> retrieving revision 6.20 smikes> diff -u -u -r6.20 hm--html-mode.el smikes> --- xemacs-packages/hm--html-menus/hm--html-mode.el 1998/12/03 17:18:29 6.20 smikes> +++ xemacs-packages/hm--html-menus/hm--html-mode.el 2002/03/06 07:02:36 smikes> ＠＠ -89,7 +89,8 ＠＠ smikes> (defvar hm--html-minor-mode nil smikes> "Non-nil, if the `hm--html-minor-mode' is active.") smikes> -(require 'hm--html-menu) smikes> +(dont-compile smikes> + (require 'hm--html-menu)) smikes> (require 'hm--html-keys) And... ,----[ C-h f dont-compile RET ] | `dont-compile' is a compiled Lisp macro | -- loaded from "/usr/local/lib/xemacs-21.5-b5/lisp/bytecomp-runtime.elc" | (dont-compile &rest BODY) | | Documentation: | Like `progn', but the body always runs interpreted (not compiled). | If you think you need this, you're probably making a mistake somewhere. `---- Scares me too. I'd like to hear from others before I do anything with this one. Thanks for contributing, Samuel. -- |---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---| | XEmacs - It's not just an editor. | | It's a way of life. | |------------------------------------&lt;youngs(a)xemacs.org&gt;---|