On 15 Aug 2002, Ville Skyttä wrote:
Hello Peter, could you have a look at this? TIA...
On Thu, 2002-08-15 at 11:05, Katsumi Yamaoka wrote:
> I can't use the key `C-x C-q' for the command `toggle-read-only'.
> The key is re-mapped to the command `p4-toggle-read-only' by
> prog-modes/auto-autoloads.elc but it isn't provided.
Marking p4-toggle-read-only for autoload seems to fix it. However, I
wonder why the substitute-key-definition is autoloaded in the first place:
(substitute-key-definition p4-prev-toggle-fkn 'p4-toggle-read-only
Doing this means that p4.el will be autoloaded as soon as you type "C-x
C-q", which seems wasteful because the vast majority of users probably
don't use perforce/p4 anyway.
And it will not really help p4 users either, because p4.el adds an entry
to find-file-hooks. This means that for correct operation, p4.el would
have to be autoloaded as soon as a file is opened, which makes the whole
autoload idea rather pointless.
Maybe the right thing to do is to just remove the autoload from
substitute-key-definition and let users who want to use p4.el load it
Peter Osterlund - petero2(a)telia.com