Re: Please fix these compile warnings/errors
>>>> "Andy" == Andy Piper
<andy(a)xemacs.org> writes:
Andy> At 12:53 PM 5/19/00 -0700, Martin Buchholz wrote:
> /xemacs/ws/dev/src/glyphs-x.c: In function
`x_finalize_image_instance':
> /xemacs/ws/dev/src/glyphs-x.c:415: warning: implicit declaration of
Andy>
function `ungcpro_popup_callbacks'
Andy> I don't understand this - this is in gui-x.h, maybe I forgot to commit it.
I think so. After the latest `cvs update', the warning is gone.
> "/net/lasker/xemacs/ws/dev/src/glyphs.c", line 1955:
warning: initializer
Andy> does not fit or is out of range: -1
> "/net/lasker/xemacs/ws/dev/src/glyphs.c", line 1956:
warning: initializer
Andy> does not fit or is out of range: -1
>
> Regarding the above, note that an unsigned int is being assigned ~0,
> which will change its value. Then it might be compared with ~0, which
> might not give you what you want, depending on promotion rules and
> such. I strongly suggest making IMAGE_UNSPECIFIED_GEOMETRY below a
> small non-negative integer. What's the justification for making it
> ~0???
Andy> Its sometimes passed as a dimension to indicate that the dimension needs to
Andy> be determined, so a small number will not suffice.
Then please use the value INT_MAX (which requires #include'ing
limits.h), which at least will avoid warnings and possible bugs due to
changes of value from negative to positive when assigned to an
unsigned int.
I still think the mixing of types `unsigned int' and `enum
image_instance_geometry' should be reconsidered.
Martin