Re: New Test for file modification
On 8/16/07, Stephen J. Turnbull <stephen(a)xemacs.org> wrote:
I don't have time to actually generate patches right now, but
this can
wait a week to ten days, right?
OK with me.
Further general comments below.
Vin Shelton writes:
> So, I think there are 3 things wrong here:
>
> (1) [Minor] the "Wrote /home/acs/test-revert-buffer-resets-modiff"
> should be suppressed.
Wrap the call to `save-buffer' in a call to `Silence-Message'. This
may have been intentional to ensure a reminder to fix:
This is a symptom of a bigger problem, in my opinion. `save-buffer'
does not document that it can output a message and should. There's
nothing to "fix" that's useful to me, but this needs to get documented.
> BTW, why is it writing this file to my home
> directory? Shouldn't the test use some temporary directory or the
> build or test directory?
Yes. I couldn't remember whether `make-temp-name' was the sanctioned
(robust and secure) way to do this, so I punted.
Is it? Inquiring minds want to know and it should be documented.
-sb
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta