[PATCH] packages: sc-attribs-extract-namestring to err on bad from address

Hi All, this seems to be the best I can come up with. Any thoughts on this? Seems better than Signaling: (wrong-type-argument stringp nil) still. Best regards, Adrian xemacs-packages/supercite/ChangeLog addition: 2001-08-06 Adrian Aichner <adrian(a)xemacs.org&gt; * supercite.el (sc-attribs-extract-namestring): Provide error message when neither full-name nor canonical-address can be extracted from argument. packages Patch (cvs -f -z3 diff -u xemacs-packages/supercite/supercite.el): Index: xemacs-packages/supercite/supercite.el =================================================================== RCS file: /usr/CVSroot/XEmacs/packages/xemacs-packages/supercite/supercite.el,v retrieving revision 1.11 diff -u -r1.11 supercite.el --- xemacs-packages/supercite/supercite.el 2001/01/15 05:54:08 1.11 +++ xemacs-packages/supercite/supercite.el 2001/08/06 20:32:52 ＠＠ -1080,9 +1080,10 ＠＠ "Extract the name string from FROM. This should be the author's full name minus an optional title." (let ((from-parts (mail-extract-address-components from))) - (if (equal (car from-parts) nil) - (sc-attribs-emailname (cadr from-parts)) - (car from-parts)))) + (or (car from-parts) + (and (cadr from-parts) + (sc-attribs-emailname (cadr from-parts))) + (error "cannot extract address components from %s" from)))) (defun sc-attribs-chop-namestring (namestring) "Convert NAMESTRING to a list of names. -- Adrian Aichner mailto:adrian＠xemacs.org http://www.xemacs.org/