[Bug: 21.4.18] etags.el add-to-tag-completion-table includes skip bug

================================================================ Dear Bug Team! The emacs.el file shipped with xemacs up to and including 2.4.19 has, at the bottom of add-to-tag-completion-table, the following while loop: (while (looking-at tags-include-pattern) (goto-char (match-end 0)) (setq filename (file-name-sans-versions (match-string 1))) (forward-line 1)) This, unfortunately, is buggy -- (goto-char (match-end 0)) takes the insertion point to the form feed preceding the next include line, and the following (forward-line 1) then places the point over the first character of the include line itself; this causes the while loop condition (looking-at tags-include-pattern) to fail on the next iteration, as the point is no longer on the form feed. This causes TAGS file parsing to fail with 'Bad TAGS file.' Removing (forward-line 1) causes TAGS files containing multiple includes to parse properly on my system, as below: (while (looking-at tags-include-pattern) (goto-char (match-end 0)) (setq filename (file-name-sans-versions (match-string 1)))) Thanks, Ethan ================================================================ System Info to help track down your bug: --------------------------------------- uname -a: Linux terranova 2.6.12 #1 SMP Tue Aug 9 18:56:34 UTC 2005 i686 GNU/Linux ./configure '--with-sound=none,native' '--with-x11' '--extra-verbose' '--with-site-lisp' '--with-database=berkdb' '--statedir=/var/lib' '--infodir=/usr/share/info/xemacs21' '--infopath=/usr/share/info/xemacs21' '--with_menubars=lucid' '--with_scrollbars=lucid' '--with_dialogs=athena' '--docdir=/usr/lib/xemacs-21.4.18/i386-debian-linux/mule-canna-wnn/' '--with-mule' '--with-canna' '--with-wnn6' '--with-xim=xlib' '--with-xfs' '--package-path=~/.xemacs:~/.xemacs/packages:~/.xemacs/xemacs-packages::/usr/share/xemacs21/site-packages:/usr/share/xemacs21/mule-packages:/usr/share/xemacs21/xemacs-packages' 'i386-debian-linux' XEmacs 21.4.18 "Social Property" configured for `i386-debian-linux'. Compilation / Installation: Source code location: /build/buildd/xemacs21-21.4.18 Installation prefix: /usr/local Operating system description file: `s/linux.h' Machine description file: `m/intel386.h' Compiler: gcc -g -O3 -Wall -Wno-switch -Winline -Wmissing-prototypes -Wsign-compare -Wshadow Compiler version: gcc-4.0.gcc-opt (GCC) 4.0.3 20051204 (prerelease) (Ubuntu 4.0.2-5ubuntu2) Compiler specs file: specs. Relocating allocator for buffers: no GNU version of malloc: yes - Using Doug Lea's new malloc from the GNU C Library. Need to guess glibc1/2/etc here Window System: Compiling in support for the X window system: - X Windows headers location: - X Windows libraries location: - Handling WM_COMMAND properly. Compiling in support for the Athena widget set: - Athena headers location: X11/Xaw - Athena library to link: Xaw Using Lucid menubars. Using Lucid scrollbars. Using Athena dialog boxes. Using Athena native widgets. TTY: Compiling in support for ncurses. Images: Compiling in support for GIF images (builtin). Compiling in support for XPM images. Compiling in support for PNG images. Compiling in support for JPEG images. Compiling in support for TIFF images. Compiling in support for X-Face message headers. Sound: Compiling in support for sound (native). Databases: Compiling in support for Berkeley database. Compiling in support for LDAP. Internationalization: Compiling in support for Mule (multi-lingual Emacs). Compiling in support for XIM (X11R5+ I18N input method). - Using raw Xlib to provide XIM support. - Using XFontSet to provide bilingual menubar. Compiling in support for Canna on Mule. Compiling in support for the WNN input method on Mule. - Using WNN version 6. Mail: Compiling in support for "dot-locking" mail spool file locking method. Other Features: Inhibiting IPv6 canonicalization at startup. Compiling in support for dynamic shared object modules. Using the new portable dumper. Load-Path Lisp Shadows: ---------------------- (/usr/share/xemacs21/site-lisp/dictionaries-common/flyspell /usr/share/xemacs21/site-lisp/dictionaries-common/flyspell /usr/share/xemacs21/site-lisp/dictionaries-common/ispell /usr/share/xemacs21/site-lisp/dictionaries-common/ispell /usr/share/xemacs21/site-lisp/dictionaries-common/debian-ispell /usr/share/xemacs21/site-lisp/dictionaries-common/debian-ispell /usr/share/xemacs21/site-lisp/gtk-doc-tools/gtk-doc /usr/share/xemacs21/site-lisp/gtk-doc-tools/gtk-doc /usr/share/xemacs21/site-lisp/debian-startup /usr/share/emacs/site-lisp/debian-startup /etc/emacs/site-start /usr/share/xemacs21/site-packages/lisp/site-start /usr/share/xemacs21/site-lisp/dictionaries-common/ispell /usr/share/xemacs21/xemacs-packages/lisp/ispell/ispell /usr/share/xemacs21/site-lisp/dictionaries-common/flyspell /usr/share/xemacs21/xemacs-packages/lisp/text-modes/flyspell /home/elb/.xemacs/etags /usr/lib/xemacs-21.4.18/lisp/etags /usr/share/xemacs21/xemacs-packages/lisp/build/build-report /usr/lib/xemacs-21.4.18/lisp/build-report /home/elb/.xemacs/custom /usr/lib/xemacs-21.4.18/lisp/custom) Installed XEmacs Packages: ------------------------- (zenirc ver: 1.16 upstream: 2.112) (xwem ver: 1.21 upstream: lg(a)xwem.org--2005/xwem--main--2.1--versionfix-1) (xslt-process ver: 1.12 upstream: 1.2.1) (xslide ver: 1.09 upstream: 0.2.2) (xlib ver: 1.14 upstream: lg(a)xwem.org--2005/xlib--main--2.1--version-0) (xetla ver: 1.0 upstream: steve(a)eicq.org--2005/xetla--main--1.0--version-0) (xemacs-devel ver: 1.72 upstream: No-Upstream-Ver) (xemacs-base ver: 2.0 upstream: No-Upstream-Ver) (x-symbol ver: 1.1 upstream: 4.5.1) (w3 ver: 1.31 upstream: 4.0pre47) (vm ver: 7.22 upstream: 7.17) (viper ver: 1.47 upstream: 3.09) (view-process ver: 1.13 upstream: 2.4) (vhdl ver: 1.2 upstream: 3.33.2) (vc-cc ver: 1.22 upstream: No-Upstream-Ver) (vc ver: 1.41 upstream: No-Upstream-Ver) (tramp ver: 1.28 upstream: 2.0.51) (tpu ver: 1.14 upstream: 4.2X) (tooltalk ver: 1.15 upstream: No-Upstream-Ver) (tm ver: 1.38 upstream: No-Upstream-Ver) (time ver: 1.14 upstream: 1.17) (textools ver: 1.15 upstream: No-Upstream-Ver) (text-modes ver: 1.9 upstream: No-Upstream-Ver) (texinfo ver: 1.3 upstream: No-Upstream-Ver) (supercite ver: 1.21 upstream: 3.55x3) (strokes ver: 1.1 upstream: No-Upstream-Ver) (speedbar ver: 1.28 upstream: 0.14beta4) (sounds-wav ver: 1.12 upstream: No-Upstream-Ver) (sounds-au ver: 1.12 upstream: No-Upstream-Ver) (sml-mode ver: 0.12 upstream: 3.9.5) (slider ver: 1.15 upstream: 0.3x1) (sieve ver: 1.18 upstream: No-Upstream-Ver) (sh-script ver: 1.21 upstream: 2.0f) (sgml ver: 1.11 upstream: No-Upstream-Ver) (semantic ver: 1.19 upstream: 1.4.2) (scheme ver: 1.14 upstream: No-Upstream-Ver) (sasl ver: 1.16 upstream: 1.14.4) (ruby-modes ver: 1.02 upstream: 1.6.8) (rmail ver: 1.14 upstream: No-Upstream-Ver) (riece ver: 1.21 upstream: 2.0.2) (reftex ver: 1.34 upstream: 4.21) (re-builder ver: 1.05 upstream: 1.20) (python-modes ver: 1.06 upstream: No-Upstream-Ver) (psgml-dtds ver: 1.03 upstream: No-Upstream-Ver) (psgml ver: 1.44 upstream: 1.3.1) (ps-print ver: 1.11 upstream: 6.5.6) (prog-modes ver: 2.06 upstream: No-Upstream-Ver) (pgg ver: 1.06 upstream: 0.1) (perl-modes ver: 1.08 upstream: No-Upstream-Ver) (pcomplete ver: 1.04 upstream: 1.1.6) (pcl-cvs ver: 1.66 upstream: R-2_9_9) (pc ver: 1.28 upstream: No-Upstream-Ver) (os-utils ver: 1.36 upstream: No-Upstream-Ver) (oo-browser ver: 1.04 upstream: 4.08) (ocaml ver: 0.05 upstream: 3.06) (net-utils ver: 1.48 upstream: N/A) (mmm-mode ver: 1.02 upstream: 0.4.7) (misc-games ver: 1.18 upstream: No-Upstream-Ver) (mine ver: 1.16 upstream: 1.9) (mh-e ver: 1.29 upstream: 7.4.2) (mew ver: 1.19 upstream: 1.94.2) (mailcrypt ver: 2.14 upstream: 3.5.8) (mail-lib ver: 1.75 upstream: No-Upstream-Ver) (jde ver: 1.48 upstream: 2.3.2) (ispell ver: 1.32 upstream: 3.6) (ilisp ver: 1.33 upstream: 5.12.0) (igrep ver: 1.14 upstream: 2.111) (idlwave ver: 1.32 upstream: 5.1) (ibuffer ver: 1.09 upstream: No-Upstream-Ver) (hyperbole ver: 1.16 upstream: 4.18) (hm--html-menus ver: 1.23 upstream: 5.9) (haskell-mode ver: 1.07 upstream: 1.45) (gnus ver: 1.87 upstream: 5.10.7) (gnats ver: 1.17 upstream: 3.101) (general-docs ver: 1.04 upstream: No-Upstream-Ver) (games ver: 1.17 upstream: 1.04) (fsf-compat ver: 1.15 upstream: No-Upstream-Ver) (frame-icon ver: 1.11 upstream: No-Upstream-Ver) (fortran-modes ver: 1.04 upstream: No-Upstream-Ver) (forms ver: 1.15 upstream: 2.37) (footnote ver: 1.16 upstream: 0.18x) (eudc ver: 1.39 upstream: 1.32) (eterm ver: 1.17 upstream: No-Upstream-Ver) (eshell ver: 1.1 upstream: 2.4.1) (escreen ver: 1.01 upstream: 1.16) (erc ver: 0.19 upstream: Version 5.0 Revision: 1.776) (emerge ver: 1.11 upstream: No-Upstream-Ver) (elib ver: 1.11 upstream: 1.0) (eieio ver: 1.05 upstream: 0.17) (efs ver: 1.33 upstream: 1.23) (edt ver: 1.13 upstream: No-Upstream-Ver) (edit-utils ver: 2.32 upstream: No-Upstream-Ver) (ediff ver: 1.6 upstream: 2.75) (edebug ver: 1.21 upstream: No-Upstream-Ver) (ecrypto ver: 0.2 upstream: 2.0) (ecb ver: 1.22 upstream: 2.31) (docbookide ver: 0.07000000000000001 upstream: 0.1) (dired ver: 1.17 upstream: 7.13) (dictionary ver: 1.16 upstream: 1.8) (debug ver: 1.17 upstream: No-Upstream-Ver) (crisp ver: 1.15 upstream: 1.34) (cookie ver: 1.15 upstream: No-Upstream-Ver) (clearcase ver: 1.1 upstream: /main/laptop/165) (cc-mode ver: 1.45 upstream: 5.30.10) (calendar ver: 1.23 upstream: No-Upstream-Ver) (calc ver: 1.26 upstream: 2.02fX3) (c-support ver: 1.22 upstream: No-Upstream-Ver) (build ver: 1.14 upstream: 2.02) (bbdb ver: 1.29 upstream: 2.34) (auctex ver: 1.46 upstream: 11.55) (apel ver: 1.32 upstream: 10.6) (ada ver: 1.14 upstream: 2.27) (Sun ver: 1.16 upstream: No-Upstream-Ver) (skk ver: 1.23 upstream: 10.62a) (mule-ucs ver: 1.14 upstream: 0.84) (mule-base ver: 1.47 upstream: No-Upstream-Ver) (lookup ver: 1.15 upstream: 1.0) (locale ver: 1.22 upstream: No-Upstream-Ver) (leim ver: 1.22 upstream: No-Upstream-Ver) (latin-unity ver: 1.15 upstream: 1.15) (latin-euro-standards ver: 1.07 upstream: 1.07) (egg-its ver: 1.27 upstream: No-Upstream-Ver) (edict ver: 1.16 upstream: 0.9.9) Installed Modules: ----------------- Features: -------- (mail-abbrevs flyspell advice advice-preload ispell xemacsbug shadow sendmail rfc822 symbol-syntax view-less view info hyper-apropos tags etags cc-mode cc-fonts cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs regexp-opt efs-cu shell comint ring paren blink-paren font-lock cus-face gnuserv filladapt jka-compr ansi-color mwheel zenirc-autoloads xwem-autoloads xslt-process-autoloads xslide-autoloads xlib-autoloads xetla-autoloads xemacs-devel-autoloads xemacs-base-autoloads x-symbol-autoloads w3-autoloads vm-autoloads viper-autoloads view-process-autoloads vhdl-autoloads vc-cc-autoloads vc-autoloads tramp-autoloads tpu-autoloads tooltalk-autoloads tm-autoloads time-autoloads textools-autoloads text-modes-autoloads texinfo-autoloads supercite-autoloads strokes-autoloads speedbar-autoloads sounds-wav-autoloads sounds-au-autoloads sml-mode-autoloads slider-autoloads sieve-autoloads sh-script-autoloads sgml-autoloads semantic-autoloads scheme-autoloads sasl-autoloads ruby-modes-autoloads rmail-autoloads riece-autoloads reftex-autoloads re-builder-autoloads python-modes-autoloads psgml-dtds-autoloads psgml-autoloads ps-print-autoloads prog-modes-autoloads pgg-autoloads perl-modes-autoloads pcomplete-autoloads pcl-cvs-autoloads pc-autoloads os-utils-autoloads oo-browser-autoloads ocaml-autoloads net-utils-autoloads mmm-mode-autoloads misc-games-autoloads mine-autoloads mh-e-autoloads mew-autoloads mailcrypt-autoloads mail-lib-autoloads jde-autoloads ispell-autoloads ilisp-autoloads igrep-autoloads idlwave-autoloads ibuffer-autoloads hyperbole-autoloads hm--html-menus-autoloads haskell-mode-autoloads gnus-autoloads gnats-autoloads general-docs-autoloads games-autoloads fsf-compat-autoloads frame-icon-autoloads fortran-modes-autoloads forms-autoloads footnote-autoloads eudc-autoloads eterm-autoloads eshell-autoloads escreen-autoloads erc-autoloads emerge-autoloads elib-autoloads eieio-autoloads efs-autoloads edt-autoloads edit-utils-autoloads ediff-autoloads edebug-autoloads ecrypto-autoloads ecb-autoloads docbookide-autoloads dired-autoloads dictionary-autoloads debug-autoloads crisp-autoloads cookie-autoloads clearcase-autoloads cc-mode-autoloads calendar-autoloads calc-autoloads c-support-autoloads build-autoloads bbdb-autoloads auctex-autoloads apel-autoloads ada-autoloads Sun-autoloads skk-autoloads mule-ucs-autoloads mule-base-autoloads lookup-autoloads locale-autoloads leim-autoloads latin-unity-autoloads latin-euro-standards-autoloads egg-its-autoloads edict-autoloads lisp-autoloads loadhist auto-show fontl-hooks x-iso8859-1 canna-leim slovenian czech romanian ccl mule-help code-cmds gutter-items menubar-items x-menubar mode-motion mouse itimer auto-save lisp-mode easymenu iso8859-1 page buff-menu lib-complete cus-file derived frame text-props obsolete cus-start custom widget cl-extra mini-cl cl cl-19 packages backquote very-early-lisp CANNA file-coding wnn mule lucid-scrollbars cut-buffer lucid-menubars athena-dialogs x c-balloon-help tty-frames tty toolbar native-sound scrollbar unix-processes multicast network-streams subprocesses modules menu-accelerator-support menubar berkeley-db md5 xemacs xim gutter tiff png gif jpeg xface xpm xbm lisp-float-type linux dialog devices window-system base64)