Re: 21.4.20 configure.in problems
On 5/4/07, Stephen J. Turnbull <turnbull(a)sk.tsukuba.ac.jp> wrote:
Vin Shelton writes:
> On 5/3/07, Stephen J. Turnbull <stephen(a)xemacs.org> wrote:
> > We should fix the quoting problem, though, since it's trivial to do
> > so. At least the Bash man page specifies the argument to -c as "a
> > string", so it needs quotes if it contains spaces.
>
> Here's why I asked exactly what went wrong:
>
> bash-3.2$ mkdir "foo bar"
Spaces in the path returned is not my point. As you point out,
dealing with them would take auditing the whole script, and possibly
can't be done. The point is that
sh -c cd $src && pwd
means
if sh -c cd $src; then
pwd
fi
which clearly is not the same as
sh -c "cd $src && pwd"
Yes. And my point was that, absent an actual bug (like "I was trying
to configure in a directory with spaces in the name and I couldn't"),
I'm not going to make that change. There's no real benefit to doing
so.
That's approximately where you're headed with your next point:
(although a little thought suggests that in that context it's actually
equivalent!)
Regards,
Vin
PS. I wasted about an hour of my life last night generating the
attached diff to configure. With this patch, configure will run to
completion in a directory with spaces in the name. The makefiles
still need tweaking:
srcdir=/opt/src/foo bar
needs to be turned into
srcdir=/opt/src/foo\ bar
but if you do that, you can actually build XEmacs.
--
The Journey by Mary Oliver
http://www.poemhunter.com/p/m/poem.asp?poet=6771&poem=30506
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta
Attachments:
- configure-214.diff (text/plain — 4.9 KB)