Fix for supercite and the "emailname" attribute
I've finally found time to track down a problem with supercite that has
been plaguing me for a while. The "emailname" attribute was always
returning the sender's first name instead of their username in the e-mail
address.
The problem is that sc-attribs-emailname calls sc-attribs-%＠-addresses
which simply matches the first string which contains legal e-mail address
characters. It uses the full sender string, e.g. "Gregory Neil Shapiro
<gshapiro(a)sendmail.org>". In that case, the first string is
"Gregory".
This makes the "emailname" attribute useless as it is the same as
"firstname".
This is easily fixed by using sc-get-address to strip the comments from the
e-mail address. The match string is now "gshapiro(a)sendmail.org" and
sc-attribs-emailname properly returns "gshapiro". Below is a ChangeLog
entry (for xemacs-patches) and a patch. Comments are welcome (maybe I
don't understand what an email "terminus" is).
1999-04-01 Gregory Neil Shapiro <gshapiro(a)sendmail.org>
* supercite.el (sc-attribs-chop-address): Use the e-mail address
instead of the full sender string. This allows
sc-attribs-emailname to return the first part of the e-mail
address instead of the first name of the author if the sender
string includes the authors name.
*** supercite.el~orig Wed Dec 9 12:27:12 1998
--- supercite.el Thu Apr 1 23:05:01 1999
***************
*** 1185,1191 ****
(midnames (reverse (cdr revnames)))
(lastname (car revnames))
(initials (sc-attribs-strip-initials namelist))
! (emailname (sc-attribs-emailname from))
(n 1)
author middlenames)
--- 1185,1192 ----
(midnames (reverse (cdr revnames)))
(lastname (car revnames))
(initials (sc-attribs-strip-initials namelist))
! (emailname (sc-attribs-emailname
! (sc-get-address from namestring)))
(n 1)
author middlenames)