Re: Trailing comma warnings
>>>> "Valdis" == Valdis Kletnieks
<Valdis.Kletnieks(a)vt.edu> writes:
Valdis> On Thu, 22 May 2003 16:18:20 CDT, Jerry James said:
> In message <200302231903.h1NJ32Lg031361(a)mail1.acecape.com>
on
> xemacs-patches (see
> <URL:http://list-archive.xemacs.org/xemacs-patches/200302/msg00237.html>),
> Matthew Persico asked that we remove a bunch of trailing commas
> to reduce warnings on Solaris 2.7 machines. That seems like a
> good idea, since those trailing commas are the main reason why
> gcc's "-W" produces unusably voluminous output. Is there any
> reason why this should not be done?
Valdis> Do it. The IBM AIX compiler is even more anal-retentive,
Valdis> and by default calls those an *error*.
What does the standard say?
Anyway, you're a bit late, it was already in 21.5.12 (or something's
busted). From src/ChangeLog:
2003-04-24 Matthew O. Persico <persicom(a)acedsl.com>
* unicode.c: Removed trailing commas in some enums; older
(Solaris 2.7 cc) compiler produced volumous warnings.
* text.c: Replaced char initialization of static Ibyte
strcasecmp_charmap[] with octal numeric init. Apparently older
(Solaris 2.7 cc) compiler treats quoted octals as signed,
causing 256 signed-assigned-to-unsigned warnings.
* lrecord.h: Removed trailing commas in some enums; older
(Solaris 2.7 cc) compiler produced volumous warnings.
* lisp.h: Removed trailing commas in some enums; older
(Solaris 2.7 cc) compiler produced volumous warnings.
* frame.c: Removed trailing commas in some enums; older
(Solaris 2.7 cc) compiler produced volumous warnings.
* file-coding.h: Removed trailing commas in some enums; older
(Solaris 2.7 cc) compiler produced volumous warnings.
--
Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Ask not how you can "do" free software business;
ask what your business can "do for" free software.