[Bug: 21.4.19] Xemacs Unstable on 64-bit Systems [was: file auto-autoloads.el is newer]

Martin, Stephen et al, I don't know anything about 64-bit systems, but shouldn't size_t really work correctly in the parsesndfile() call? In any case, this patch apparently works around a real bug. Please comment. - Vin ---------- Forwarded message ---------- From: Hans de Graaff <gra...(a)gentoo.org&gt; Date: May 12, 2:59 am Subject: file auto-autoloads.el is newer To: comp.emacs.xemacs On Fri, 11 May 2007 15:26:21 -0400, Randy Yates wrote: I see you are using a 64-bit build on Linux. This will crash with native audio as soon as a sound is played. With Gentoo we use the following patch to fix this issue: Index: linuxplay.c =================================================================== RCS file: /pack/xemacscvs/XEmacs/xemacs/src/linuxplay.c,v retrieving revision 1.13 diff -u -B -r1.13 linuxplay.c --- src/linuxplay.c 2001/04/12 18:23:58 1.13 +++ src/linuxplay.c 2006/12/22 07:15:06 ＠＠ -290,7 +290,8 ＠＠ fmtType ffmt; int fmt,speed,tracks; unsigned char *pptr,*optr,*cptr,*sptr; - int wrtn,rrtn,crtn,prtn; + int wrtn,crtn; + size_t prtn,rrtn; unsigned char sndbuf[SNDBUFSZ]; /* We need to read at least the header information before we can start ＠＠ -338,9 +339,9 ＠＠ device; repeat until all data has been processed */ rrtn = length; do { - for (pptr = data; (prtn = parsesndfile((void **)&pptr,(size_t *) &rrtn, + for (pptr = data; (prtn = parsesndfile((void **)&pptr, &rrtn, (void **)&optr)) > 0; ) - for (cptr = optr; (crtn = sndcnv((void **)&cptr,(size_t *) &prtn, + for (cptr = optr; (crtn = sndcnv((void **)&cptr, &prtn, (void **)&sptr)) > 0; ) { for (;;) { if ((wrtn = write(audio_fd,sptr,crtn)) < 0) { _______________________________________________ XEmacs-Beta mailing list XEmacs-Beta(a)xemacs.org http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta