Cristalle Azundris Sabon <cristalle(a)azundris.com> writes:
> Hi Bill,
> Kindly consider this enhancement to the much enjoyed GTK UI.
Thanks for the patch... I really don't like transparency, but I'll see
about getting it committed. Comments:
1) I think you could probably reduce the number of variables. Something
like a generic gtk-transparency which is a list of things to make
transparent. So you could put '(text tab background) in there to make
2) Static variables always scare me in XEmacs - most of those should be in
either the GTK device structure, or the GTK frame structure. Especially
if GTK ever gets real mulit-display support, the atoms on each display
could be different.
Would you be interested in making these changes?
> The patch has been written for and tested with GTK/X-window; other
> combinations (GTK-FB, GTK/Win) are not supported as those provide their
> own flavours of transparency, anyway. As GTK/X goes, the feature has
> proved stable so far, including but not limited to surviving the change
> of desktop backdrops which seems to kill many pseudo-transparent apps.
What are the 'extreme bogosity' hard-coded offsets for? Is that for
figuring out where the actual emacs frame starts?
What about calling Fredraw_frame(frame,Qt) instead of directly calling
Would any of this logic make sense to be down in the GtkXEmacs widget
instead of up in redisplay?
> And yes, it looks ghastly with the wrong kind of backdrop. ; )
Maybe my eyes just aren't as good as all the 'young punks' nowadays who
seem to like transparency. :)
Ceterum censeo vi esse delendam