Aidan,
Over the past couple of months HEAD has become pretty much unusable
for ordinary work for me. Now that you've merged Ben's unicode branch,
everything I use pretty quickly runs into an error.
For one thing, I frequently run into problems with --with-union-type
regularly, such as a lack of an EXFUN declaration for Fvalues, which
at some point since my previous update got used in elhash.c (otherwise
there don't seem to be any uses in C code). I've also run into issues
with non-bignum code on several occasions; I've started building with
bignums but still get too many errors to use trunk for real work. (I
don't know if the Fvalues declaration needs MODULE_API.)
Perhaps some of it is due to pickier recent compilers (I mostly use
some recent version of LLVM on Mac). For example the chartab_range
initializer bug patched below seems to go back about a decade, and the
Info bug (separate formal patch) goes back to prehistory.
I'm also seeing (small) increases in the number of tests that fail on
my system, and HEAD seems to infloop (100% CPU for 10 minutes) in
mule-tests on trunk. To get work done, I've gone back to pre-unicode
versions.
Do you have plans to stabilize trunk any time soon?
Regards,
Steve
Appended: current patches against r6066. The "labs" patch probably
should be autoconfiscated, since it involves types of libc functions.
diff -r 63ae8a489fed src/ChangeLog
--- a/src/ChangeLog Thu Mar 09 21:39:44 2017 +0000
+++ b/src/ChangeLog Thu Apr 27 20:21:11 2017 +0900
@@ -1,3 +1,9 @@
+2017-04-27 Stephen J. Turnbull <steve(a)Stephens-MacBook-Pro.local>
+
+ * lisp.h (Fvalues): Declare it MODULE_API EXFUN.
+
+ * editfns.c (Fencode_time): Use labs rather than abs.
+
2017-03-03 Aidan Kehoe <kehoea(a)parhasard.net>
* search.c (Fstring_match_p):
diff -r 63ae8a489fed src/editfns.c
--- a/src/editfns.c Thu Mar 09 21:39:44 2017 +0000
+++ b/src/editfns.c Thu Apr 27 20:21:11 2017 +0900
@@ -1238,7 +1238,7 @@
tzstring = LISP_STRING_TO_EXTERNAL (zone, Qtime_zone_encoding);
else if (FIXNUMP (zone))
{
- int abszone = abs (XFIXNUM (zone));
+ int abszone = labs (XFIXNUM (zone));
/* We specify the time zone in offset notation (see `man
tzset' for details). The offset indicates the value one
must add to local time to arrive at UTC. Thus, we sign
diff -r 63ae8a489fed src/lisp.h
--- a/src/lisp.h Thu Mar 09 21:39:44 2017 +0000
+++ b/src/lisp.h Thu Apr 27 20:21:11 2017 +0900
@@ -4744,6 +4744,7 @@
MODULE_API EXFUN (Fcall_with_condition_handler, MANY);
EXFUN (Ffunction_max_args, 1);
EXFUN (Ffunction_min_args, 1);
+MODULE_API EXFUN (Fvalues, MANY);
MODULE_API DECLARE_DOESNT_RETURN (throw_or_bomb_out (Lisp_Object,
Lisp_Object, int,
# HG changeset patch
# Parent eec2a31de9d67f78b606314136ed13abb364046d
Fix dummy chartab_range initializers.
diff -r eec2a31de9d6 src/ChangeLog
--- a/src/ChangeLog Sat Apr 22 00:23:36 2017 +0100
+++ b/src/ChangeLog Thu Apr 27 18:50:42 2017 +0900
@@ -1,3 +1,10 @@
+2017-04-27 Stephen J. Turnbull <stephen(a)xemacs.org>
+
+ * chartab.c (char_table_print_preprocess):
+ (char_table_nsubst_structures_descend):
+ data.c (build_fixnum_to_char_map):
+ Fix chartab_range initializers.
+
2017-04-21 Aidan Kehoe <kehoea(a)parhasard.net>
* elhash.c (intern_istring):
diff -r eec2a31de9d6 src/chartab.c
--- a/src/chartab.c Sat Apr 22 00:23:36 2017 +0100
+++ b/src/chartab.c Thu Apr 27 18:50:42 2017 +0900
@@ -157,7 +157,7 @@
char_table_print_preprocess (Lisp_Object object, Lisp_Object print_number_table,
Elemcount *seen_object_count)
{
- struct chartab_range ctr = { CHARTAB_RANGE_ALL, 0, Qnil, 0 };
+ struct chartab_range ctr = { CHARTAB_RANGE_ALL, 0, 0, Qnil, 0 };
preprocess_info_t preprocess_info = { print_number_table, seen_object_count };
map_char_table (object, &ctr, print_preprocess_mapper, &preprocess_info);
}
@@ -193,7 +193,7 @@
Lisp_Object number_table,
Boolint test_not_unboundp)
{
- struct chartab_range ctr = { CHARTAB_RANGE_ALL, 0, Qnil, 0 };
+ struct chartab_range ctr = { CHARTAB_RANGE_ALL, 0, 0, Qnil, 0 };
nsubst_structures_info_t nsubst_structures_info
= { number_table, new_, old, object, test_not_unboundp };
diff -r eec2a31de9d6 src/data.c
--- a/src/data.c Sat Apr 22 00:23:36 2017 +0100
+++ b/src/data.c Thu Apr 27 18:50:42 2017 +0900
@@ -1504,7 +1504,7 @@
build_fixnum_to_char_map (Lisp_Object radix_table)
{
Lisp_Object highest_value, result;
- struct chartab_range ctr = { CHARTAB_RANGE_ALL, 0, Qnil, 0 };
+ struct chartab_range ctr = { CHARTAB_RANGE_ALL, 0, 0, Qnil, 0 };
Ichar *cctable;
EMACS_INT ii, cclen;
Ibyte *data;