October 1999 - XEmacs-Beta - XEmacs Mailing List Archives

Michael Harnois

I thought all of these were smashed, but I guess not ... Error: Widget *Group* has zero width and/or height -- Michael D. Harnois, Redeemer Lutheran Church, Washburn, IA mharnois(a)willinet.net aa0bt(a)aa0bt.ampr.org Paranoids are people, too; they have their own problems. It's easy to criticize, but if everybody hated you, you'd be paranoid too. -- D. J. Hicks

3 participants
3 comments

[Corrected Patches] Re: (call-process ...) to return correct exit-status on NT 25 years, 1 month

Adrian Aichner

Hello Craig, hello All! Sorry I goofed! I backed out a necessary modification to sys_subshell before sending the patches. Here are both patches again including these modifications. To be applied against vanilla 21.1.7 and 21.2-b19 respectively. Regards, Adrian

2 participants
1 comments

Re: (call-process ...) to return correct exit-status on NT 25 years, 1 month

Adrian Aichner

>>>>> "Craig" == Craig Lanning <CraigL(a)DyCon.com> writes: Craig> This doesn't work for me on Win98 (mingw32). It actually Craig> makes things worse. Hello Craig, thanks for the feedback. I am working on an improved patch. The issue seems to be that the process may be gone before my patch even gets the process handle from the process ID. The new patch, which seems to work fine so far, determines the process handle right after creating the new process and passes a process HANDLE to wait_for_termination on WindowsNT. Thanks for testing and sorry for the breakage. Regards, Adrian This is the current state of my patch against 21.2-b19, which works fine for me. I'll submit it with ChangeLog after more testing in 21.2-b19 and 21.1.7. Best regards, Adrian Index: src/callproc.c =================================================================== RCS file: /usr/CVSroot/XEmacs/xemacs/src/callproc.c,v retrieving revision 1.29.2.6 diff -u -r1.29.2.6 callproc.c --- callproc.c 1999/05/01 05:13:23 1.29.2.6 +++ callproc.c 1999/10/14 02:13:55 ＠＠ -114,7 +114,7 ＠＠ /* #### "c-G" -- need non-consing Single-key-description */ message ("Waiting for process to die...(type C-g again to kill it instantly)"); - wait_for_termination (pid); + wait_for_termination (OpenProcess(PROCESS_QUERY_INFORMATION, 0, pid)); /* "Discard" the unwind protect. */ XCAR (fdpid) = Qnil; ＠＠ -170,6 +170,9 ＠＠ Lisp_Object infile, buffer, current_dir, display, path; int fd[2]; int filefd; +#ifdef WINDOWSNT + HANDLE pHandle; +#endif int pid; char buf[16384]; char *bufptr = buf; ＠＠ -358,7 +361,8 ＠＠ fork_error = Qnil; #ifdef WINDOWSNT pid = child_setup (filefd, fd1, fd_error, new_argv, - (char *) XSTRING_DATA (current_dir)); + (char *) XSTRING_DATA (current_dir)); + pHandle = OpenProcess(PROCESS_QUERY_INFORMATION, 0, pid); #else /* not WINDOWSNT */ pid = fork (); ＠＠ -507,7 +511,7 ＠＠ QUIT; /* Wait for it to terminate, unless it already has. */ - wait_for_termination (pid); + wait_for_termination (pHandle); /* Don't kill any children that the subprocess may have left behind when exiting. */ Index: src/ntproc.c =================================================================== RCS file: /usr/CVSroot/XEmacs/xemacs/src/ntproc.c,v retrieving revision 1.14.2.10 diff -u -r1.14.2.10 ntproc.c --- ntproc.c 1999/10/10 12:40:13 1.14.2.10 +++ ntproc.c 1999/10/14 02:13:59 ＠＠ -457,7 +457,7 ＠＠ #endif *pPid = cp->pid; - + return TRUE; EH_Fail: Index: src/sysdep.c =================================================================== RCS file: /usr/CVSroot/XEmacs/xemacs/src/sysdep.c,v retrieving revision 1.32.2.7 diff -u -r1.32.2.7 sysdep.c --- sysdep.c 1999/07/05 05:56:44 1.32.2.7 +++ sysdep.c 1999/10/14 02:14:09 ＠＠ -234,8 +234,11 ＠＠ #endif /* NO_SUBPROCESSES */ -void -wait_for_termination (int pid) +#ifdef WINDOWSNT +void wait_for_termination (HANDLE pid) +#else +void wait_for_termination (int pid) +#endif { /* #### With the new improved SIGCHLD handling stuff, there is much less danger of race conditions and some of the comments below ＠＠ -345,6 +348,36 ＠＠ Since implementations may add their own error indicators on top, we ignore it by default. */ +#elif defined (WINDOWSNT) + int ret = 0, status = 0; + if (pid == NULL) { + /* + * If the process is gone, it has probably been terminated. APA + */ + stderr_out ("wait_for_termination.OpenProcess returns NULL GetLastError () %d for pid %d\n", GetLastError (), (int)pid); + synch_process_alive = 0; + synch_process_death = signal_name (SIGTERM); + } else { + do { + QUIT; + ret = GetExitCodeProcess(pid, &status); + } while (status == STILL_ACTIVE); + if (ret) { + synch_process_alive = 0; + synch_process_retcode = status; + } + else { + /* + * GetExitCodeProcess() didn't return a valid exit status, + * nothing to do. APA + */ + stderr_out ("wait_for_termination.GetExitCodeProcess status %d GetLastError () %d for pid %d\n", status, GetLastError (), (int)pid); + } + if (!CloseHandle(pid)) { + stderr_out ("wait_for_termination.CloseHandle GetLastError () %d for pid %d\n", + GetLastError (), (int)pid); + } + } #elif defined (EMACS_BLOCK_SIGNAL) && !defined (BROKEN_WAIT_FOR_SIGNAL) && defined (SIGCHLD) while (1) { ＠＠ -376,7 +409,7 ＠＠ Try defining BROKEN_WAIT_FOR_SIGNAL. */ EMACS_WAIT_FOR_SIGNAL (SIGCHLD); } -#else /* not HAVE_WAITPID and (not EMACS_BLOCK_SIGNAL or BROKEN_WAIT_FOR_SIGNAL) */ +#else /* not HAVE_WAITPID and not WINDOWSNT and (not EMACS_BLOCK_SIGNAL or BROKEN_WAIT_FOR_SIGNAL) */ /* This approach is kind of cheesy but is guaranteed(?!) to work for all systems. */ while (1) ＠＠ -578,7 +611,11 ＠＠ static void sys_subshell (void) { +#ifdef WINDOWSNT + HANDLE pid; +#else int pid; +#endif struct save_signal saved_handlers[5]; Lisp_Object dir; unsigned char *str = 0; ＠＠ -617,7 +654,7 ＠＠ xyzzy: #ifdef WINDOWSNT - pid = -1; + pid = NULL; #else /* not WINDOWSNT */ pid = fork (); ＠＠ -651,7 +688,7 ＠＠ #ifdef WINDOWSNT /* Waits for process completion */ pid = _spawnlp (_P_WAIT, sh, sh, NULL); - if (pid == -1) + if (pid == NULL) write (1, "Can't execute subshell", 22); #else /* not WINDOWSNT */ Index: src/sysdep.h =================================================================== RCS file: /usr/CVSroot/XEmacs/xemacs/src/sysdep.h,v retrieving revision 1.11.2.1 diff -u -r1.11.2.1 sysdep.h --- sysdep.h 1998/12/05 16:56:31 1.11.2.1 +++ sysdep.h 1999/10/14 02:14:10 ＠＠ -48,7 +48,12 ＠＠ /* Wait for subprocess with process id `pid' to terminate and make sure it will get eliminated (not remain forever as a zombie) */ +#ifdef WINDOWSNT +#include <windows.h> +void wait_for_termination (HANDLE pid); +#else void wait_for_termination (int pid); +#endif /* flush any pending output * (may flush input as well; it does not matter the way we use it) cvs server: Diffing src/m cvs server: Diffing src/s cvs server: Diffing tests cvs server: Diffing tests/DLL cvs server: Diffing tests/Dnd cvs server: Diffing tests/automated cvs server: Diffing tests/mule cvs server: Diffing tests/tooltalk

3 participants
6 comments

Re: Update of psgml package 25 years, 1 month

Jan Vroonhof

Jarl Friis <jarl(a)diku.dk> writes: > When can it be expected that you update the xemacs-package psgml from the > psgml mode? When a. somebody does the work of making a package from it and testing it. b. Steve makes a new package release. You can help by doing a., testing and submitting it. Unfortunately Steve has not made a package release since a few weeks :-(; > The current author version in the xemacs package is 1.01, while the newest > version of psgml is 1.2.0. It includes support for XML and I find it very > reasonable to update the xemacs package. 1.2.0 is only out of beta for a week or so. I agree it would be nice to update it soon. Jan

1 participants
0 comments

Re: [PATCHES] Re: (call-process ...) to return correct exit-status on NT 25 years, 1 month

Jan Vroonhof

Adrian Aichner <aichner(a)ecf.teradyne.com> writes: > Should it be possible to keyboard-quit (C-g) a long-running process? Yes > I cannot interrupt > (apply 'call-process "sleep" nil nil nil (list "30")) > short of using Task Manager to "End Process". you can under Unix. Jan

1 participants
0 comments

Update of psgml package 25 years, 1 month

Jarl Friis

When can it be expected that you update the xemacs-package psgml from the psgml mode? The current author version in the xemacs package is 1.01, while the newest version of psgml is 1.2.0. It includes support for XML and I find it very reasonable to update the xemacs package. see http://www.lysator.liu.se/projects/about_psgml.html for the newest realese of psgml mode. Please reply. Jarl Friis M-x praise-be-unto-xemacs

1 participants
0 comments

Re: bad widget! 25 years, 1 month

Michael Harnois

On Sun, 17 Oct 1999 18:15:18 +0100, Andy Piper <andy(a)xemacs.org> said: > What were you doing? Is it reproducible? I was just reading along merrily in Gnus. After I restarted the same thing happened with another tab widget a bit later. -- Michael D. Harnois, Redeemer Lutheran Church, Washburn, IA mharnois(a)willinet.net aa0bt(a)aa0bt.ampr.org Paranoids are people, too; they have their own problems. It's easy to criticize, but if everybody hated you, you'd be paranoid too. -- D. J. Hicks

1 participants
0 comments

reenabling gutter caused core dump 25 years, 1 month

Yoshiki Hayashi

This bug report will be sent to the XEmacs Development Team, not to your local site managers!! Please write in English, because the XEmacs maintainers do not have translators to read other languages for them. In XEmacs 21.2 (beta19) "Shinjuku" [Lucid] (i686-pc-linux, Mule) of Wed Sep 29 1999 on buck configured using `configure --prefix=/opt/local --with-mule' Please describe exactly what actions triggered the bug and the precise symptoms of the bug: I don't usually use gutter, so I'm disabling it with (set-specifier default-gutter-visible-p nil) When I opened a lot of files, I thought it might be usefult to have gutter again. So, I enabled gutter with (set-specifier default-gutter-visible-p t) and typed C-x b. Then XEmacs dumped core. This one is build from CVS and xemacs/src/CVS/Entries says, /ChangeLog/1.154.2.235/Wed Sep 29 07:20:36 1999//Trelease-21-2 Lisp backtrace and output of `where' follows. -- Yoshiki Hayashi

2 participants
6 comments

Re: XEmacs 21.2 (w/Mule) file-truename 25 years, 1 month

Lars Magne Ingebrigtsen

Jan Vroonhof <vroonhof(a)math.ethz.ch> writes: > Does this (untested) patch work for you? Yup; everything works nicely after applying your patch. -- (domestic pets only, the antidote for overdose, milk.) larsi(a)gnus.org * Lars Magne Ingebrigtsen

1 participants
0 comments

Misc patch 25 years, 1 month

Andy Piper

Misc fixes for things. andy 1999-10-14 Andy Piper <andy(a)xemacs.org> * event-msw.c (mswindows_key_to_emacs_keysym): add some more keycodes. * redisplay-x.c (x_output_shadows): fix dodgy maths for border calculations. * gutter.c (output_gutter): be more accurate about the area to be cleared since X seems to manage to do the clear after drawing the border. * redisplay.h (RESET_CHANGED_FLAGS): new macro for setting redisplay flags as a group. (RESET_CHANGED_SET_FLAGS): ditto. (CLASS_RESET_CHANGED_FLAGS): ditto. (GLOBAL_RESET_CHANGED_FLAGS): ditto. (REDISPLAY_FLAGS_CHANGEDP): new macro for testing redisplay flags as a group. (CLASS_REDISPLAY_FLAGS_CHANGEDP): ditto. (GLOBAL_REDISPLAY_FLAGS_CHANGEDP): ditto. * redisplay.c (redisplay_frame): use CLASS_RESET_CHANGED_FLAGS instead of setting flags individually. (redisplay_device): ditto CLASS_REDISPLAY_FLAGS_CHANGEDP. (redisplay_device): ditto. (redisplay_device): ditto CLASS_RESET_CHANGED_FLAGS. (redisplay_without_hooks): ditto GLOBAL_REDISPLAY_FLAGS_CHANGEDP. (redisplay_without_hooks): ditto CLASS_REDISPLAY_FLAGS_CHANGEDP. (redisplay_without_hooks): ditto. (redisplay_without_hooks): ditto GLOBAL_RESET_CHANGED_FLAGS. * redisplay-x.c (x_output_string): unmap subwindows in the area. (x_output_blank): ditto. * redisplay-output.c (redisplay_output_display_block): don't unmap subwindows in case layout optimization can avoid it. (redisplay_output_subwindow): unmap subwindows in the area. (redisplay_output_layout): optimize the output of layouts - only output glyphs that have changed if nothing else of redisplay significance has occurred. (redisplay_output_pixmap): change args to redisplay_clear_clipped_region. (redisplay_clear_clipped_region): allow the clipped region to be cleared of all subwindows except the one passed in. * redisplay-msw.c (mswindows_output_blank): unmap subwindows in the area. (mswindows_output_cursor): ditto. (mswindows_output_string): ditto. * gutter.c (calculate_gutter_size): if the window buffer is nil then don't continue. (update_frame_gutters): be more lenient about when we actually update the gutter. Layout optimization makes this non-costly. Cache redisplay flags that we want to temporarily ignore. * glyphs.c (Fglyph_animated_timeout_handler): handle image specific timeouts rather than iterating over the instance cache. (glyph_animated_timeout_mapper): deleted. (add_glyph_animated_timeout): use a weak list to hold onto the image so that it can be GC'ed. (disable_glyph_animated_timeout): disable a specific timeout. (vars_of_glyphs): disable-animated-pixmaps is a new boolean for controlling whether pixmaps are animated or not. * glyphs-msw.c (mswindows_finalize_image_instance): make sure the image timeout gets disabled when the image gets freed. * glyphs-eimage.c (gif_instantiate): remove meaningless comment. Cope with timeouts specified in the gif extension block. * event-msw.c (vars_of_event_mswindows): new variable mswindows-meta-activates-menu. (mswindows_wnd_proc): only goto defproc with VK_MENU if the user wants it. * glyphs-x.c (x_finalize_image_instance): delete mask first so that we can compare with image. 1999-10-13 Andy Piper <andy(a)xemacs.org> * gutter-items.el (progress-abort-glyph): new glyph for showing abort status. (append-progress): dispatch-event rather than sit-for. (abort-progress): new function. Show the abort glyph with an appropriate message. (raw-append-progress): dispatch-event rather than sit-for. (display-progress): cope with aborts. * gui.el (make-gui-button): Use native widgets for buttons unconditionally. (insert-gui-button): ditto. (gui-button-p): ditto. * xbm-button.el: remove from core. * xpm-button.el: remove from core. -------------------------------------------------------------- Dr Andy Piper Senior Consultant Architect, BEA Systems Ltd

2 participants
3 comments

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

2000

1999

1998

XEmacs-Beta October 1999