RE: [PATCH 21.5] Dump bignums (OG workspace)
-----Original Message-----
From: xemacs-patches-bounces(a)xemacs.org
[mailto:xemacs-patches-bouncesï¼ xemacs.org] On Behalf Of Jerry James
Sent: Tuesday, February 01, 2005 1:10 PM
To: XEmacs Patches
Subject: [PATCH 21.5] Dump bignums (OG workspace)
This is a modified version of OG's bignum dumping workspace.
I have altered his original patch in several ways:
(1) Some updates were necessary due to Ben Wing's name changes;
(2) I removed a comma operator that was used for
typechecking because
it was not valid C++ code (this became unnecessary anyway due to
change #4 below);
(3) I added code that uses the dumping capability to initialize
bigfloat-max-prec in a saner way than is currently possible; and
(4) His patch included some unclean typecasts that triggered alias
analysis warnings from gcc. I fixed those with a union.
It is this last point that prompts me to make this a patch
rather than a commit. Making the 4th element of
memory_description a union means that all initializers have
to put {} around that element. Does anybody object to this
and, if so, can you propose an alternative approach?
I don't object to it, although it's very slightly annoying to have the extra
braces (but not a big deal as the syntax is ungainly in any case). The
other possibility would be to make the converter structure be an extra
argument, either before or after the flags (I don't like the flags are used
in very many places).