[COMMIT] Make the #ifndef HAVE_XTREGISTERDRAWABLE msg polite, have it compile
APPROVE COMMIT 21.5
NOTE: This patch has been committed.
Malcolm, I didn’t use exactly the error message you suggested, because of
the need for a buffer to sprintf into for it, and doubts about whether
function-local static buffers are portable enough. (There’s a chance an
automatic buffer would be trashed by the signal handling, IIRC.)
src/ChangeLog addition:
2005-03-02 Aidan Kehoe <kehoea(a)parhasard.net>
* select-x.c (x_reply_selection_request): Make the error message
in the absence of HAVE_XTREGISTERDRAWABLE more polite, pass a
second argument to invalid_operation to have it actually compile
in that case.
XEmacs Trunk source patch:
Diff command: cvs -q diff -u
Files affected: src/select-x.c
Index: src/select-x.c
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/src/select-x.c,v
retrieving revision 1.21
diff -u -u -r1.21 select-x.c
--- src/select-x.c 2005/03/01 22:43:41 1.21
+++ src/select-x.c 2005/03/02 13:04:34
＠＠ -528,8 +528,7 ＠＠
else
{
#ifndef HAVE_XTREGISTERDRAWABLE
- invalid_operation("your Xt library sucks too much to transfer this "
- "much data!");
+ invalid_operation("Copying that much data requires X11R6.", Qunbound);
#else
/* Send an INCR selection. */
int prop_id;
--
“I, for instance, am gung-ho about open source because my family is being
held hostage in Rob Malda’s basement. But who fact-checks me, or Enderle,
when we say something in public? No-one!” -- Danny O’Brien