On Wed 09 Feb 2005 04:13, "Ben Wing" <ben(a)666.com> writes:
> In general, this is a good patch but shouldn't this loop be
> written with one of the LIST_LOOP macros?
>
> >>>>> "Eric" == Eric Knauel
> <knauel(a)informatik.uni-tuebingen.de> writes:
>
> +static void
> +string_list_to_fcobjectset (Lisp_Object list, FcObjectSet *os)
> +{
> + Lisp_Object i;
> +
> + for (i = list; !NILP (i); i = XCDR (i))
> + {
> + CHECK_STRING (XCAR (i));
> + FcObjectSetAdd (os, XSTRING_DATA (XCAR (i)));
> + }
> +}
> +
EXTERNAL_LIST_LOOP_2, if this is coming from the user.
Ah, I didn't know EXTERNAL_LIST_LOOP*. Fixed. Thanks for the hint!
-Eric
--
"Excuse me --- Di Du Du Duuuuh Di Dii --- Huh Weeeheeee" (Albert King)