>>>> "Jeff" == Jeff Miller
Jeff> I've generally been diff'ing against Emacs CVS using the
Jeff> -ubw flags, which is probably why I don't see all the
Jeff> whitespace problems you do.
This is likely to run into trouble in the long run, as we would like
to avoid the double-posting of patches (to xemacs-patches and
xemacs-cvs). When (if ...) these get unified, the patch posted will
be a regular unified diff generated against CVS, I am pretty sure.
Jeff> What is the generally accepted practice? Match Emacs
Jeff> space-for-space, tab-for-tab? Tabify the files? Untabify?
Feel free to set your own standard as long as you document it. I
believe that the core prefers tabified files. However, you're the one
who bears the burden of synching to Emacs and of integrating 3rd party
patches. Whatever works for you as long as you settle on something
consistent reasonably quickly (i.e., on the one hand, don't worry
about perfection, a bad standard is better than no standard, but on
the other, take enough time to decide what your requirements are).
Jeff> Ok, I can change that. I guess I was just trying to show
Jeff> what changes I had made but also indicate who the original
Jeff> authors were. Since I was including the original commit
Jeff> dates in Emacs CVS, I didn't want to confuse them with my
Jeff> commit dates.
How about a ChangeLog.upstream?
Jeff> I've tried to mark any XEmacs related changes I've been
Jeff> adding. I haven't gone back and marked any that previously
Jeff> existed and weren't marked ( with one or two exceptions).
It's a good idea to note them as you find them, along with a notation
explaining why, or that you don't understand but it seems
significant. (Gratuitous differences should be synched when you find
them.) But again, it's your package, until you pass it to somebody
School of Systems and Information Engineering http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Ask not how you can "do" free software business;
ask what your business can "do for" free software.