[AC] package sh-script executable.el (executable-interpret): parameter correction
                
            
            
                17 years, 7 months
            
            
                
                    
                     
                    
                    
                    Jerry James
                
 
                
                    
                        
                            APPROVE COMMIT packages
I have committed this patch.  Thanks again!
On Wed, Mar 19, 2008 at 7:32 AM, It's me FKtPp ;) <m_pupil(a)yahoo.com.cn> wrote:
>  Okay, I've done done modification as you described.
>
>  Please find below the patch...
>
>  Thanks,
>  FKtPp
>
>
>  ChangeLog addition:
>
>  2008-03-19  It's me FKtPp ;)  <m_pupil(a)yahoo.com.cn>
>
>     * ChangeLog:
>     * executable.el (executable-interpret):
>
>
>
>  sh-script[Packages] source patch:
>  Diff command:   cvs -q diff -u
>  Files affected: executable.el
>  ===================================================================
>  RCS ChangeLog
>  ===================================================================
>  RCS
>
>  Index: ChangeLog
>  ===================================================================
>  RCS file:
>  /pack/xemacscvs/XEmacs/packages/xemacs-packages/sh-script/ChangeLog,v
>  retrieving revision 1.30
>  diff -u -r1.30 ChangeLog
>  --- ChangeLog    2008/02/10 19:09:00    1.30
>  +++ ChangeLog    2008/03/19 13:18:20
>  @@ -1,3 +1,8 @@
>  +2008-03-15  It's me FKtPp ;)  <m_pupil(a)yahoo.com.cn>
>
> +
>  +    * executable.el (executable-interpret): Correct compile-internal's
>  +    parameters to avoid error when `C-c C-x'(executable-interpret).
>  +
>   2008-02-10  Norbert Koch  <viteno(a)xemacs.org>
>
>      * Makefile (VERSION): XEmacs package 1.23 released.
>
> Index: executable.el
>  ===================================================================
>  RCS file:
>  /pack/xemacscvs/XEmacs/packages/xemacs-packages/sh-script/executable.el,v
>  retrieving revision 1.4
>  diff -u -r1.4 executable.el
>  --- executable.el    2005/10/15 21:27:07    1.4
>  +++ executable.el    2008/03/19 13:18:20
>  @@ -223,9 +223,13 @@
>
>    (save-some-buffers (not compilation-ask-about-save))
>    (set (make-local-variable 'executable-command) command)
>    (let ((compilation-error-regexp-alist executable-error-regexp-alist))
>  -    (compile-internal command t (lambda (x) "*interpretation*"))))
>  -
>  -
>  +    ;; XEmacs change: arguments to compile-internal differ from Emacs
>
>
> +    (compile-internal command
>  +              "No more errors"
>  +              nil
>  +              nil
>  +              nil
>  +              (lambda (x) "*interpretation*"))))
>
>   ;;;###autoload
>   (defun executable-set-magic (interpreter &optional argument
-- 
Jerry James
http://loganjerry.googlepages.com/
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
                        
                     
                    
                 
             
         
        
        
            
        
        
            
                
                    
                    
                    [PATCH] package sh-script executable.el (executable-interpret): parameter correction
                
            
            
                17 years, 7 months
            
            
                
                    
                     
                    
                    
                    FKtPp
                
 
                
                    
                        
                            Dear Reviewers,
Do you think the following changelog and patch are acceptable to be
commited?
ChangeLog addition:
2008-03-15  It's me FKtPp ;)  <m_pupil(a)yahoo.com.cn>
    * executable.el (executable-interpret): Correct compile-internal's
    parameters to avoid error when `C-c C-x'(executable-interpret).
sh-script[Packages] source patch:
Diff command:   cvs -q diff -u
Files affected: executable.el
===================================================================
RCS
Index: executable.el
===================================================================
RCS file:
/pack/xemacscvs/XEmacs/packages/xemacs-packages/sh-script/executable.el,v
retrieving revision 1.4
diff -u -r1.4 executable.el
--- executable.el    2005/10/15 21:27:07    1.4
+++ executable.el    2008/03/15 08:26:22
@@ -223,9 +223,12 @@
   (save-some-buffers (not compilation-ask-about-save))
   (set (make-local-variable 'executable-command) command)
   (let ((compilation-error-regexp-alist executable-error-regexp-alist))
-    (compile-internal command t (lambda (x) "*interpretation*"))))
-
-
+    (compile-internal command
+              "No More Errors"
+              nil
+              nil
+              nil
+              (lambda (x) "*interpretation*"))))
 
 ;;;###autoload
 (defun executable-set-magic (interpreter &optional argument
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
                        
                     
                    
                 
             
         
        
        
            
        
        
            
                
                    
                    
                    commit: Fix reader crash.
                
            
            
                17 years, 7 months
            
            
                
                    
                     
                    
                    
                    Michael Sperber
                
 
                
                    
                        
                            changeset:   4439:f4eb31866c3830c131d730ed67c2aa8b462f80a9
tag:         tip
user:        Mike Sperber <sperber(a)deinprogramm.de>
date:        Sat Mar 15 12:21:11 2008 +0100
files:       src/ChangeLog src/lread.c
description:
Fix reader crash.
2008-03-15  Michael Sperber  <mike(a)xemacs.org>
	* lread.c (read1): Signal an error on ?\<newline>, thus preventing
	an assertion failure higher up.
diff -r 2785829fe37c25a05d7dc850cf9767fcf8f04786 -r f4eb31866c3830c131d730ed67c2aa8b462f80a9 src/ChangeLog
--- a/src/ChangeLog	Wed Mar 12 19:37:49 2008 +0100
+++ b/src/ChangeLog	Sat Mar 15 12:21:11 2008 +0100
@@ -1,3 +1,8 @@ 2008-03-11  Stephen J. Turnbull  <stephe
+2008-03-15  Michael Sperber  <mike(a)xemacs.org>
+
+	* lread.c (read1): Signal an error on ?\<newline>, thus preventing
+	an assertion failure higher up.
+
 2008-03-11  Stephen J. Turnbull  <stephen(a)xemacs.org>
 
 	* specifier.c (CHECK_INSTANCE_ENTRY): Fix typo in comment.
diff -r 2785829fe37c25a05d7dc850cf9767fcf8f04786 -r f4eb31866c3830c131d730ed67c2aa8b462f80a9 src/lread.c
--- a/src/lread.c	Wed Mar 12 19:37:49 2008 +0100
+++ b/src/lread.c	Sat Mar 15 12:21:11 2008 +0100
@@ -2763,6 +2763,8 @@ retry:
 
 	if (c == '\\')
 	  c = read_escape (readcharfun);
+	if (c < 0)
+	  return Fsignal (Qinvalid_read_syntax, list1 (READCHARFUN_MAYBE (readcharfun)));
 	return make_char (c);
       }
 
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
                        
                     
                    
                 
             
         
        
        
            
        
        
            
                
                    
                    
                    commit: Fix window-configuration problem.
                
            
            
                17 years, 7 months
            
            
                
                    
                     
                    
                    
                    Michael Sperber
                
 
                
                    
                        
                            changeset:   4438:2785829fe37c25a05d7dc850cf9767fcf8f04786
tag:         tip
user:        Mike Sperber <sperber(a)deinprogramm.de>
date:        Wed Mar 12 19:37:49 2008 +0100
files:       lisp/ChangeLog lisp/window-xemacs.el
description:
Fix window-configuration problem.
2008-03-12  Mike Sperber  <mike(a)xemacs.org>
	* window-xemacs.el (restore-saved-window): Restore window
	parameters right after splitting, rather than after traversing the
	other children.
diff -r 11357f7846bf1ab10224f0025a6cc3327c419e84 -r 2785829fe37c25a05d7dc850cf9767fcf8f04786 lisp/ChangeLog
--- a/lisp/ChangeLog	Tue Mar 11 23:15:08 2008 -0700
+++ b/lisp/ChangeLog	Wed Mar 12 19:37:49 2008 +0100
@@ -1,3 +1,9 @@ 2008-03-07  Michael Sperber  <mike@xemac
+2008-03-12  Mike Sperber  <mike(a)xemacs.org>
+
+	* window-xemacs.el (restore-saved-window): Restore window
+	parameters right after splitting, rather than after traversing the
+	other children.
+
 2008-03-07  Michael Sperber  <mike(a)xemacs.org>
 
 	* gnuserv.el (gnuserv-temp-file-regexp): Quote the temp-directory
diff -r 11357f7846bf1ab10224f0025a6cc3327c419e84 -r 2785829fe37c25a05d7dc850cf9767fcf8f04786 lisp/window-xemacs.el
--- a/lisp/window-xemacs.el	Tue Mar 11 23:15:08 2008 -0700
+++ b/lisp/window-xemacs.el	Wed Mar 12 19:37:49 2008 +0100
@@ -379,17 +379,21 @@ by `current-window-configuration'."
 
 (defun restore-saved-window (configuration window saved-window direction)
   "Within CONFIGURATION, restore WINDOW to the state of SAVED-WINDOW."
-  (and (saved-window-next-child saved-window)
-       (not (saved-window-minibufferp (saved-window-next-child saved-window)))
-       (progn
-	 (cond ((eq direction 'vertical)
-		(split-window window nil nil))
-	       ((eq direction 'horizontal)
-		(split-window window nil t)))
-	 (restore-saved-window configuration
-			       (window-next-child window)
-			       (saved-window-next-child saved-window)
-			       direction)))
+  (cond
+   ((and (saved-window-next-child saved-window)
+	 (not (saved-window-minibufferp (saved-window-next-child saved-window))))
+    (cond ((eq direction 'vertical)
+	   (split-window window nil nil))
+	  ((eq direction 'horizontal)
+	   (split-window window nil t)))
+    (if (not (saved-window-minibufferp saved-window))
+	(restore-saved-window-parameters configuration window saved-window))
+    (restore-saved-window configuration
+			  (window-next-child window)
+			  (saved-window-next-child saved-window)
+			  direction))
+  ((not (saved-window-minibufferp saved-window))
+   (restore-saved-window-parameters configuration window saved-window)))
 
   (if (saved-window-first-hchild saved-window)
       (restore-saved-window configuration
@@ -400,10 +404,7 @@ by `current-window-configuration'."
       (restore-saved-window configuration
 			    window
 			    (saved-window-first-vchild saved-window)
-			    'vertical))
-
-  (if (not (saved-window-minibufferp saved-window))
-      (restore-saved-window-parameters configuration window saved-window)))
+			    'vertical)))
 
 (defun restore-saved-window-parameters (configuration window saved-window)
   "Restore the window parameters stored in SAVED-WINDOW on WINDOW."
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
                        
                     
                    
                 
             
         
        
        
            
        
        
            
                
                    
                    
                    commit: Fix typo.
                
            
            
                17 years, 7 months
            
            
                
                    
                     
                    
                    
                    Stephen Turnbull
                
 
                
                    
                        
                            changeset:   4437:11357f7846bf1ab10224f0025a6cc3327c419e84
tag:         tip
user:        Stephen J. Turnbull <stephen(a)xemacs.org>
date:        Tue Mar 11 23:15:08 2008 -0700
files:       src/ChangeLog src/specifier.c
description:
Fix typo.
diff -r a72dc882abf1f0b22ed65bba72d725e70223a435 -r 11357f7846bf1ab10224f0025a6cc3327c419e84 src/ChangeLog
--- a/src/ChangeLog	Fri Mar 07 14:35:37 2008 +0100
+++ b/src/ChangeLog	Tue Mar 11 23:15:08 2008 -0700
@@ -1,3 +1,7 @@ 2008-03-05  Dominique Quatravaux  <domq@
+2008-03-11  Stephen J. Turnbull  <stephen(a)xemacs.org>
+
+	* specifier.c (CHECK_INSTANCE_ENTRY): Fix typo in comment.
+
 2008-03-05  Dominique Quatravaux  <domq(a)cpan.org>
 
 	* glyphs-gtk.c (init_image_instance_from_gdk_image):
diff -r a72dc882abf1f0b22ed65bba72d725e70223a435 -r 11357f7846bf1ab10224f0025a6cc3327c419e84 src/specifier.c
--- a/src/specifier.c	Fri Mar 07 14:35:37 2008 +0100
+++ b/src/specifier.c	Tue Mar 11 23:15:08 2008 -0700
@@ -2952,7 +2952,7 @@ specifier_instance_from_inst_list (Lisp_
 
 /* Given a SPECIFIER and a DOMAIN, return a specific instance for that
    specifier. Try to find one by checking the specifier types from most
-   specific (buffer) to most general (global).  If we find an instance,
+   specific (window) to most general (global).  If we find an instance,
    return it.  Otherwise return Qunbound. */
 
 #define CHECK_INSTANCE_ENTRY(key, matchspec, type) do {			\
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
                        
                     
                    
                 
             
         
        
        
            
        
        
            
                
                    
                    
                    commit: Quote temp-directory regexp in gnuserv.
                
            
            
                17 years, 8 months
            
            
                
                    
                     
                    
                    
                    Michael Sperber
                
 
                
                    
                        
                            changeset:   4436:a72dc882abf1f0b22ed65bba72d725e70223a435
tag:         tip
user:        Mike Sperber <sperber(a)deinprogramm.de>
date:        Fri Mar 07 14:35:37 2008 +0100
files:       lisp/ChangeLog lisp/gnuserv.el
description:
Quote temp-directory regexp in gnuserv.
2008-03-07  Michael Sperber  <mike(a)xemacs.org>
	* gnuserv.el (gnuserv-temp-file-regexp): Quote the temp-directory
	part.
diff -r 1e2fc51563a598c293a47edbd50b1ff58caa308f -r a72dc882abf1f0b22ed65bba72d725e70223a435 lisp/ChangeLog
--- a/lisp/ChangeLog	Wed Mar 05 18:01:37 2008 +0100
+++ b/lisp/ChangeLog	Fri Mar 07 14:35:37 2008 +0100
@@ -1,3 +1,8 @@ 2008-03-05  Didier Verna  <didier@xemacs
+2008-03-07  Michael Sperber  <mike(a)xemacs.org>
+
+	* gnuserv.el (gnuserv-temp-file-regexp): Quote the temp-directory
+	part.
+
 2008-03-05  Didier Verna  <didier(a)xemacs.org>
 
 	Fix auto-formatting of comments in auto-fill-mode.
diff -r 1e2fc51563a598c293a47edbd50b1ff58caa308f -r a72dc882abf1f0b22ed65bba72d725e70223a435 lisp/gnuserv.el
--- a/lisp/gnuserv.el	Wed Mar 05 18:01:37 2008 +0100
+++ b/lisp/gnuserv.el	Fri Mar 07 14:35:37 2008 +0100
@@ -214,7 +214,7 @@ current buffer set to the visiting buffe
   :group 'gnuserv)
 
 (defcustom gnuserv-temp-file-regexp
-  (concat "^" (temp-directory) "/Re\\|/draft$")
+  (concat "^" (regexp-quote (temp-directory)) "/Re\\|/draft$")
   "*Regexp which should match filenames of temporary files deleted
 and reused by the programs that invoke the Emacs server."
   :type 'regexp
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
                        
                     
                    
                 
             
         
        
        
            
        
        
            
                
                    
                    
                    Re: commit: Fix specifier inheritance behavior
                
            
            
                17 years, 8 months
            
            
                
                    
                     
                    
                    
                    Stephen J. Turnbull
                
 
                
                    
                        
                            Didier Verna writes:
 > >>  +                                    Lisp_Object depth,
 > >>  +                                    int no_fallback);
Could you please explain what this patch does, specifically why the
no-fallback behavior is needed wherever it was that you added it?  I
assume this has something to do with your background image problem;
please explain in more general terms than "it does what I need it to
do," ie, for either Lispref or Internals (as appropriate).  A patch
would be nice, but if you don't feel like hacking texi, I can do that
part.
It doesn't look like you actually fixed specifier inheritance
behavior; this option was available all along in specifiers
themselves.  Rather you added no-fallback behavior to images or
something that uses images, right?
Did you ever post a patch (besides that auto-commit notice)?  I don't
recall seeing it, and Vin responded to the commit notice....
What was all the whitespace fiddling doing i nthat patch?
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
                        
                     
                    
                 
             
         
        
        
            
        
        
            
                
                    
                    
                    commit: Fix auto-formatting of comments in auto-fill-mode
                
            
            
                17 years, 8 months
            
            
                
                    
                     
                    
                    
                    Didier Verna
                
 
                
                    
                        
                            changeset:   4435:1e2fc51563a598c293a47edbd50b1ff58caa308f
tag:         tip
user:        Didier Verna <didier(a)xemacs.org>
date:        Wed Mar 05 18:01:37 2008 +0100
files:       lisp/ChangeLog lisp/newcomment.el
description:
Fix auto-formatting of comments in auto-fill-mode
This patch makes auto-fill-mode properly format comments (when lines are
automatically broken). It looks strangely similar to that of:
| 1999-06-24  Bob Weiner  <weiner(a)beopen.com>
|
| 	* simple.el (indent-new-comment-line): Locally bound
| 	`block-comment-start' to `comstart' or else when this is called
| 	from do-auto-fill, e.g. in Lisp mode, it will insert any non-nil
| 	`block-comment-start' value, ignoring any existing spacing after a
| 	comment prefix in the previous line and producing ugly comments.
diff -r 7f3d065a56a176d7567899561d6cb5df5a251e41 -r 1e2fc51563a598c293a47edbd50b1ff58caa308f lisp/ChangeLog
--- a/lisp/ChangeLog	Wed Mar 05 10:41:54 2008 +0100
+++ b/lisp/ChangeLog	Wed Mar 05 18:01:37 2008 +0100
@@ -1,3 +1,12 @@ 2008-03-05  Didier Verna  <didier@xemacs
+2008-03-05  Didier Verna  <didier(a)xemacs.org>
+
+	Fix auto-formatting of comments in auto-fill-mode.
+
+	* newcomment.el (comment-indent): Don't insert a space at bol.
+	* newcomment.el (comment-indent-new-line): Bind
+	block-comment-start to comment-start in order to preserve the
+	formatting of previous comment lines.
+
 2008-03-05  Didier Verna  <didier(a)xemacs.org>
 
 	Ease customization of face(s) under point.
diff -r 7f3d065a56a176d7567899561d6cb5df5a251e41 -r 1e2fc51563a598c293a47edbd50b1ff58caa308f lisp/newcomment.el
--- a/lisp/newcomment.el	Wed Mar 05 10:41:54 2008 +0100
+++ b/lisp/newcomment.el	Wed Mar 05 18:01:37 2008 +0100
@@ -240,7 +240,7 @@ This is obsolete because you might as we
 		   (substring comment-start 1)))
       ;; Hasn't been necessary yet.
       ;; (unless (string-match comment-start-skip comment-continue)
-      ;; 	(kill-local-variable 'comment-continue))
+      ;;	(kill-local-variable 'comment-continue))
       )
     ;; comment-skip regexps
     (unless (and comment-start-skip
@@ -443,12 +443,12 @@ Point is assumed to be just at the end o
 ;     (save-excursion
 ;       (beginning-of-line)
 ;       (let ((eol (save-excursion (end-of-line) (point))))
-; 	(and comment-start-skip
-; 	     (re-search-forward comment-start-skip eol t)
-; 	     (setq eol (match-beginning 0)))
-; 	(goto-char eol)
-; 	(skip-chars-backward " \t")
-; 	(max comment-column (1+ (current-column))))))
+;	(and comment-start-skip
+;	     (re-search-forward comment-start-skip eol t)
+;	     (setq eol (match-beginning 0)))
+;	(goto-char eol)
+;	(skip-chars-backward " \t")
+;	(max comment-column (1+ (current-column))))))
 ;   "Function to compute desired indentation for a comment.
 ; This function is called with no args with point at the beginning of
 ; the comment's starting delimiter.")
@@ -498,7 +498,8 @@ Comments starting in column 0 are not mo
 	    (setq begpos (point))
 	    ;; Ensure there's a space before the comment for things
 	    ;; like sh where it matters (as well as being neater).
-	    (unless (eq ?\  (char-syntax (char-before)))
+	    ;; ... but unless we're at the beginning of a line -- dvl
+	    (unless (or (bolp) (eq ?\  (char-syntax (char-before))))
 	      (insert ?\ ))
 	    (insert starter)
 	    (setq cpos (point-marker))
@@ -516,8 +517,8 @@ Comments starting in column 0 are not mo
 		     (+ (current-column)
 			(- (or comment-fill-column fill-column)
 			   (save-excursion (end-of-line) (current-column)))))))
-        ;; XEmacs change: Preserve indentation of comments starting in
-        ;; column 0, as documented.
+	;; XEmacs change: Preserve indentation of comments starting in
+	;; column 0, as documented.
 	(unless (or (= (current-column) 0) (= (current-column) indent))
 	  ;; If that's different from current, change it.
 	  (delete-region (point) (progn (skip-chars-backward " \t") (point)))
@@ -653,21 +654,21 @@ comment markers."
     (setq end (copy-marker end))
 
     (let* ((numarg (prefix-numeric-value arg))
-           (ccs comment-continue)
-           (srei (comment-padright ccs 're))
-           (sre (and srei (concat "^\\s-*?\\(" srei "\\)")))
-           spt)
+	   (ccs comment-continue)
+	   (srei (comment-padright ccs 're))
+	   (sre (and srei (concat "^\\s-*?\\(" srei "\\)")))
+	   spt)
       (while (and (< (point) end)
 		  (setq spt (comment-search-forward end t)))
 	(let ((ipt (point))
-              ;; Find the end of the comment.
-              (ept (progn
-                     (goto-char spt)
-                     (unless (comment-forward)
-                       (error "Can't find the comment end"))
-                     (point)))
-              (box nil)
-              (box-equal nil))     ;Whether we might be using `=' for boxes.
+	      ;; Find the end of the comment.
+	      (ept (progn
+		     (goto-char spt)
+		     (unless (comment-forward)
+		       (error "Can't find the comment end"))
+		     (point)))
+	      (box nil)
+	      (box-equal nil))     ;Whether we might be using `=' for boxes.
 	  (save-restriction
 	    (narrow-to-region spt ept)
 
@@ -1097,6 +1098,7 @@ unless optional argument SOFT is non-nil
 			  (point))
 			 nil t)))))
 		 (comment-start comstart)
+		 (block-comment-start comment-start)
 		 (continuep (or comment-multi-line
 				(cadr (assoc comment-style comment-styles))))
 		 ;; Force comment-continue to be recreated from comment-start.
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
                        
                     
                    
                 
             
         
        
        
            
        
        
            
                
                    
                    
                    [COMMIT] Fix auto-formatting of comments in auto-fill-mode
                
            
            
                17 years, 8 months
            
            
                
                    
                     
                    
                    
                    Didier Verna
                
 
                
                    
                        
                            NOTE: This patch has been committed. The version below is informational only.
In particular, whitespace difference have been removed.
       The following patch makes auto-fill-mode properly format comments
(when lines are automatically broken). It looks strangely similar to
that of:
| 1999-06-24  Bob Weiner  <weiner(a)beopen.com>
| 
| 	* simple.el (indent-new-comment-line): Locally bound
| 	`block-comment-start' to `comstart' or else when this is called
| 	from do-auto-fill, e.g. in Lisp mode, it will insert any non-nil
| 	`block-comment-start' value, ignoring any existing spacing after a
| 	comment prefix in the previous line and producing ugly comments.
lisp/ChangeLog addition:
2008-03-05  Didier Verna  <didier(a)xemacs.org>
	Fix auto-formatting of comments in auto-fill-mode.
	* newcomment.el (comment-indent): Don't insert a space at bol.
	* newcomment.el (comment-indent-new-line): Bind
	block-comment-start to comment-start in order to preserve the
	formatting of previous comment lines.
XEmacs 21.5 source patch:
Diff command:   hg diff -wbB
Files affected: lisp/newcomment.el
diff -r 7f3d065a56a1 lisp/newcomment.el
--- lisp/newcomment.el	Wed Mar 05 10:41:54 2008 +0100
+++ lisp/newcomment.el	Wed Mar 05 17:56:04 2008 +0100
@@ -498,7 +498,8 @@ Comments starting in column 0 are not mo
 	    (setq begpos (point))
 	    ;; Ensure there's a space before the comment for things
 	    ;; like sh where it matters (as well as being neater).
-	    (unless (eq ?\  (char-syntax (char-before)))
+	    ;; ... but unless we're at the beginning of a line -- dvl
+	    (unless (or (bolp) (eq ?\  (char-syntax (char-before))))
 	      (insert ?\ ))
 	    (insert starter)
 	    (setq cpos (point-marker))
@@ -1097,6 +1098,7 @@ unless optional argument SOFT is non-nil
 			  (point))
 			 nil t)))))
 		 (comment-start comstart)
+		 (block-comment-start comment-start)
 		 (continuep (or comment-multi-line
 				(cadr (assoc comment-style comment-styles))))
 		 ;; Force comment-continue to be recreated from comment-start.
-- 
5th European Lisp Workshop at ECOOP 2008, July 7: http://elw.bknr.net/2008/
Didier Verna, didier(a)lrde.epita.fr, http://www.lrde.epita.fr/~didier
EPITA / LRDE, 14-16 rue Voltaire   Tel.+33 (0)1 44 08 01 85
94276 Le Kremlin-Bicêtre, France   Fax.+33 (0)1 53 14 59 22  didier(a)xemacs.org
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
                        
                     
                    
                 
             
         
        
        
            
        
        
            
                
                    
                    
                    Re: Whitespace
                
            
            
                17 years, 8 months
            
            
                
                    
                     
                    
                    
                    Didier Verna
                
 
                
                    
                        
                            Stephen J. Turnbull wrote:
> It wouldn't help. Certain individuals are consistent offenders, at
> least in certain contexts. Others almost never submit whitespace-
> dirty patches. That's why I ask you, who at least care about such
> things.
  Yup. But how about imposing committers a particular whitespace
configuration ? It's just a matter of 4 lines of custom/init file.
-- 
5th European Lisp Workshop at ECOOP 2008, July 7: http://elw.bknr.net/2008/
Didier Verna, didier(a)lrde.epita.fr, http://www.lrde.epita.fr/~didier
EPITA / LRDE, 14-16 rue Voltaire   Tel.+33 (0)1 44 08 01 85
94276 Le Kremlin-Bicêtre, France   Fax.+33 (0)1 53 14 59 22  didier(a)xemacs.org
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches