[Patch] Warnings in 21.0b37
I looked at the following warnings which I got during my build of
21.0b37 (see my previous build-report):
/mnt/xemacs/cvs-sources/xemacs-20/src/emacs.c: In function `voodoo_free_hook':
/mnt/xemacs/cvs-sources/xemacs-20/src/emacs.c:2104: warning: assignment from incompatible
pointer type
/mnt/xemacs/cvs-sources/xemacs-20/src/emacs.c: In function `Fkill_emacs':
/mnt/xemacs/cvs-sources/xemacs-20/src/emacs.c:2163: warning: assignment from incompatible
pointer type
/mnt/xemacs/cvs-sources/xemacs-20/src/print.c:1465: warning: `/*' within comment
/mnt/xemacs/cvs-sources/xemacs-20/src/specifier.c:79: warning: `current_specifiers'
defined but not used
File: emacs.c:
==============
In glibc 2.1 <malloc.h> will have:
extern void (*__free_hook) __MALLOC_P ((__malloc_ptr_t __ptr,
__const __malloc_ptr_t));
But 2.0.7 has:
extern void (*__free_hook) __MALLOC_P ((__malloc_ptr_t __ptr));
This leads to a warning in emacs.c for the assignment:
voodoo_free_hook(void *mem)
{
/* Disable all calls to free() when XEmacs is exiting and it doesn't */
/* matter. */
__free_hook = voodoo_free_hook;
}
Should we add a second parameter with the following conditinal?
#if defined DOUG_LEA_MALLOC && __GLIBC__ == 2 && __GLIBC__MINOR__ >= 1
Or should we just ignore it?
File: print.c:
==============
The code is ok - I've added a small patch to shut up gcc.
File: specifier.c:
==================
current_specifiers isn't used anywhere in the sources (greped them).
I've removed it.
Patches and ChangeLog entry are appended.
Andreas
1998-04-26 Andreas Jaeger <aj(a)arthur.rhein-neckar.de>
* specifier.c: Remove unused declaration of current_specifiers.
* print.c: Add '*/' to close comment and avoid gcc warning.
--- src/specifier.c.~1~ Sat Apr 18 11:12:37 1998
+++ src/specifier.c Sun Apr 26 14:45:24 1998
＠＠ -71,13 +71,6 ＠＠
static Lisp_Object Vreveal_ghoste_specifiers;
-/* #### The purpose of this is to check for inheritance loops
- in specifiers that can inherit from other specifiers, but it's
- not yet implemented.
-
- #### Look into this for 19.14. */
-static Lisp_Object_dynarr current_specifiers;
-
static void recompute_cached_specifier_everywhere (Lisp_Object specifier);
EXFUN (Fspecifier_specs, 4);
--- src/print.c.~1~ Fri Apr 24 09:53:03 1998
+++ src/print.c Sun Apr 26 14:26:47 1998
＠＠ -1462,7 +1462,7 ＠＠
alternate_do_string[alternate_do_pointer] = 0;
return character;
}
-/* #endif /* DEBUG_XEMACS */
+/* #endif */ /* DEBUG_XEMACS */
DEFUN ("external-debugging-output", Fexternal_debugging_output, 1, 3, 0, /*
Write CHAR-OR-STRING to stderr or stdout.
--
Andreas Jaeger aj(a)arthur.rhein-neckar.de jaeger(a)informatik.uni-kl.de
for pgp-key finger ajaeger(a)alma.student.uni-kl.de