10:47 p.m.
Attached is a patch which allows 21.5 to find a package tree in
../xemacs-packages. This is similar to the patch I applied to 21.4 -
http://list-archive.xemacs.org/xemacs-patches/200512/msg00137.html
The purpose of this patch is to support XEmacs 21.5 finding its
package directories at run-time. This is necessary to create a
Windows native setup kit for 21.5, as exists now for 21.4, c.f.
ftp://ftp.xemacs.org/pub/xemacs/windows/XEmacs%20Setup%2021.4.19.exe .
One thing to note about this patch is that it changes xemacs.mak so
that it does not use the now-deprecated PACKAGE_PATH mechanism by
default. That mechanism is still supported (if you specify
PACKAGE_PATH or PACKAGE_PREFIX in config.inc you can still force a
particular package path into the executable).
This patch also comments out the default usage of PACKAGE_PREFIX in
config.inc.samp. Strictly speaking, this is not entirely required for
my needs (I could just build a kit without PACKAGE_PREFIX), but since
that mechanism is deprecated, I thought we shouldn't be encouraging
people to use it.
Comments please. I will commit this patch in a few days if I don't
hear any objections.
Regards,
Vin
--
Whoever you are, no matter how lonely,
the world offers itself to your imagination,
calls to you like the wild geese, harsh and exciting--
over and over announcing your place
in the family of things. Mary Oliver
8:16 a.m.
>>>> "vin" == Vin Shelton <acs(a)xemacs.org>
writes:
vin> Attached is a patch which allows 21.5 to find a package tree
vin> in ../xemacs-packages.
You mean this?
... -+- {bin,src}/xemacs <---- executable
|
+- site-packages
|
+- mule-packages
|
+- xemacs-packages
AFAIK that's the way Mike configures his own installation, I'm pretty
sure that works.
Or do you mean this?
... -+- xemacs-$version/{bin,src}/xemacs <---- executable
|
+- site-packages
|
+- mule-packages
|
+- xemacs-packages
As far as I know that's the style that Ben uses, and Mike recently
ripped it out of the standard configuration, although you can still
use --with-late-packages. I do not like that style, I think it's
unclean. "site-packages", especially, is the kind of generic name
used by many scripting languages, and should be prefixed by something
that indicates both that it's part of XEmacs and that it is sibling to
{mule,xemacs}-packages.
I strongly prefer this "two-root" style:
... -+- xemacs-$version/{bin,src}/xemacs <---- executable
... -+- $packages -+- site-packages
|
+- mule-packages
|
+- xemacs-packages
For runtime detection, of course a one-root style is necessary, in
which case I think this is appropriate:
... -+- xemacs-$version/{bin,src}/xemacs <---- executable
|
+- $packages -+- site-packages
|
+- mule-packages
|
+- xemacs-packages
Note the similarity of the above to the current Unix installation
under $prefix/lib with $packages == xemacs.
--
School of Systems and Information Engineering http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Ask not how you can "do" free software business;
ask what your business can "do for" free software.
12:51 p.m.
Hi Vin,
the Lisp part of the patch looks fine---I can do my work on top of
that.
Now, I see there's quite a bit of logic around the setting of
PACKAGE_PATH. This really needs to go. PACKAGE_PATH itself is
deprecated, and the settings in nt/xemacs.mak are just plain wrong for
some configurations. Similarly for PACKAGE_PREFIX. If anything like
PACKAGE_PREFIX needs to be set, it should be the value of
PATH_LATE_PACKAGE_DIRECTORIES.
--
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla
3:51 p.m.
On 2/28/06, Vin Shelton <acs(a)xemacs.org> wrote:
Attached is a patch which allows 21.5 to find a package tree in
../xemacs-packages. This is similar to the patch I applied to 21.4 -
http://list-archive.xemacs.org/xemacs-patches/200512/msg00137.html
Vin, the patch on its own works fine for me, except that XEmacs only finds
packages in ~/.xemacs for me, not in c:\program file\xemacs. Is that
currently expected behaviour?
Regards
Robert
--
6:26 p.m.
On 3/6/06, Robert Pluim <rpluim(a)gmail.com> wrote:
On 2/28/06, Vin Shelton <acs(a)xemacs.org> wrote:
> Attached is a patch which allows 21.5 to find a package tree in
> ../xemacs-packages. This is similar to the patch I applied to 21.4 -
>
http://list-archive.xemacs.org/xemacs-patches/200512/msg00137.html
Vin, the patch on its own works fine for me, except that XEmacs only finds
packages in ~/.xemacs for me, not in c:\program file\xemacs. Is that
currently expected behaviour?
Hi Robert,
Thanks for testing out the patch.
Are you specifying a package path in your config.inc file? If you
are, that one should be respected. If you are not, then c:\program
files\XEmacs is no longer automatically searched.
Please include a copy of your Installation file if you follow-up.
Thanks,
Vin
--
Whoever you are, no matter how lonely,
the world offers itself to your imagination,
calls to you like the wild geese, harsh and exciting--
over and over announcing your place
in the family of things. Mary Oliver
8:48 a.m.
On 3/6/06, Vin Shelton <acs(a)xemacs.org> wrote:
On 3/6/06, Robert Pluim <rpluim(a)gmail.com> wrote:
>
>
>
> On 2/28/06, Vin Shelton <acs(a)xemacs.org> wrote:
> > Attached is a patch which allows 21.5 to find a package tree in
> > ../xemacs-packages. This is similar to the patch I applied to 21.4 -
> >
> http://list-archive.xemacs.org/xemacs-patches/200512/msg00137.html
>
>
>
> Vin, the patch on its own works fine for me, except that XEmacs only
finds
> packages in ~/.xemacs for me, not in c:\program file\xemacs. Is that
> currently expected behaviour?
>
Hi Robert,
Thanks for testing out the patch.
Are you specifying a package path in your config.inc file? If you
are, that one should be respected. If you are not, then c:\program
files\XEmacs is no longer automatically searched.
I wasn't, but putting one in seems to make no difference.
Please include a copy of your Installation file if you follow-up.
Here it is:
Building XEmacs using "NMAKE".
Building XEmacs using make flags " ".
Building XEmacs in source tree "C:\\cygwin\\home\\rpluim\\xemacs-21.5".
For src, using compiler "cl -nologo -W3 -DSTRICT -Zi -Od -MDd -c -TP
-IC:\cygwin\home\rpluim\xemacs-21.5\nt\inc -IC:\cygwin\home\rpluim\xemacs-
21.5\src -I"c:\cygwin\home\rpluim\xemacs-libs\xpm-3.4k"
-I"c:\cygwin\home\rpluim\xemacs-libs\xpm-3.4k\lib"
-I"c:\cygwin\home\rpluim\xemacs-libs\compface-1.5.1" -DHAVE_MS_WINDOWS
-DHAVE_MENUBARS -DHAVE_SCROLLBARS -DHAVE_TOOLBARS -DHAVE_WIDGETS
-DHAVE_DIALOGS -DHAVE_XPM -DFOR_MSW -DHAVE_GIF -DHAVE_XFACE
-DHAVE_NATIVE_SOUND -DERROR_CHECK_ALL -DPDUMP -DUSE_KKCC -DSYSTEM_MALLOC
-DDEBUG_XEMACS -D_DEBUG -DWIN32_LEAN_AND_MEAN -DWIN32_NATIVE -Demacs
-DHAVE_CONFIG_H -DPATH_VERSION=\"21.5-b25\"
-DPATH_PROGNAME=\"xemacs\"
-DEMACS_VERSION=\"21.5-b25\"
-DEMACS_PROGNAME=\"xemacs\"
-DSTACK_TRACE_EYE_CATCHER=xemacs_21_5_b25_i586_pc_win32
-DPATH_PREFIX=\"..\" -DEMACS_MAJOR_VERSION=21 -DEMACS_MINOR_VERSION=5
-DEMACS_BETA_VERSION=25 -DXEMACS_CODENAME=\""eggplant"\"
-DXEMACS_EXTRA_NAME=\"(+CVS-20060305)\"
-DPATH_PACKAGEPATH=\""~\\.xemacs;;c:\\Program
Files\\XEmacs\\site-packages;c:\\Program Files\\XEmacs\\xemacs-packages"\"
-DEMACS_CONFIGURATION=\"i586-pc-win32\"".
For lib-src, using compiler "cl -nologo -W3 -DSTRICT -Zi -Od -MDd
-IC:\cygwin\home\rpluim\xemacs-21.5\lib-src -IC:\cygwin\home\rpluim\xemacs-
21.5\src -DHAVE_CONFIG_H -DWIN32_NATIVE".
Compiling as C++.
Installing XEmacs in "c:\\Program Files\\XEmacs\\XEmacs-21.5-b25".
Package path is "~\\.xemacs;;c:\\Program
Files\\XEmacs\\site-packages;c:\\Program Files\\XEmacs\\xemacs-packages".
Compiling in support for Microsoft Windows native GUI.
Compiling in support for XPM images.
Compiling in support for GIF images.
--------------------------------------------------------------------
NOTE: Compiling without PNG image support.
NOTE: You should strongly consider installing the PNG libraries.
NOTE: Otherwise certain images and glyphs may not display.
NOTE: (a copy may be found in ftp://ftp.xemacs.org/pub/xemacs/aux
--------------------------------------------------------------------
Compiling in support for X-Face message headers.
Compiling in support for toolbars.
Compiling in support for dialogs.
Compiling in support for widgets.
Compiling in support for native sounds.
Using portable dumper.
Using system malloc.
Using DLL version of C runtime library.
Compiling in extra internal error-checking.
NOTE: ---------------------------------------------------------
NOTE: Compiling in support for runtime error-checking.
NOTE: XEmacs will run noticeably more slowly as a result.
NOTE: Error-checking is on by default for XEmacs beta releases.
NOTE: ---------------------------------------------------------
Compiling in debugging support (no slowdown).
Using new experimental GC mark algorithms.
7:51 p.m.
"Robert Pluim" <rpluim(a)gmail.com> writes:
On 2/28/06, Vin Shelton <acs(a)xemacs.org> wrote:
>
> Attached is a patch which allows 21.5 to find a package tree in
> ../xemacs-packages. This is similar to the patch I applied to 21.4 -
> http://list-archive.xemacs.org/xemacs-patches/200512/msg00137.html
Vin, the patch on its own works fine for me, except that XEmacs only finds
packages in ~/.xemacs for me, not in c:\program file\xemacs. Is that
currently expected behaviour?
If your XEmacs executable is sitting outside the hierarchy in
c:\Program Files\xemacs, then the answer is yes.
--
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla
12:08 a.m.
"Vin Shelton" <acs(a)xemacs.org> writes:
Attached is a patch which allows 21.5 to find a package tree in
../xemacs-packages. This is similar to the patch I applied to 21.4 -
http://list-archive.xemacs.org/xemacs-patches/200512/msg00137.html
The purpose of this patch is to support XEmacs 21.5 finding its
package directories at run-time. This is necessary to create a
Windows native setup kit for 21.5, as exists now for 21.4, c.f.
ftp://ftp.xemacs.org/pub/xemacs/windows/XEmacs%20Setup%2021.4.19.exe .
One thing to note about this patch is that it changes xemacs.mak so
that it does not use the now-deprecated PACKAGE_PATH mechanism by
default. That mechanism is still supported (if you specify
PACKAGE_PATH or PACKAGE_PREFIX in config.inc you can still force a
particular package path into the executable).
Hello Vin, I missed this patch at first.
The patch was below the signature (which I don't always read :-) ) and
the subject did not suggest this was a change to xemacs.mak as well.
I looked again after reading related conversation in xemacs-beta and
found this.
This patch looks good to me from visual inspection.
Best regards,
Adrian
This patch also comments out the default usage of PACKAGE_PREFIX in
config.inc.samp. Strictly speaking, this is not entirely required for
my needs (I could just build a kit without PACKAGE_PREFIX), but since
that mechanism is deprecated, I thought we shouldn't be encouraging
people to use it.
Comments please. I will commit this patch in a few days if I don't
hear any objections.
Regards,
Vin
--
Adrian Aichner
mailto:adrian＠xemacs.org
http://www.xemacs.org/
12:46 a.m.
Here is the latest (final, I hope) version of my 21.5 package-finding
patch. This patch will enable me to cons up a 21.5 native setup kit
that will be compatible with the 21.4 kit.
Changes since last version:
1. Per Michael's comments, runtime searching for a package root
using xemacs-packages is only for win32 configuration (I took out
the check for cygwin in setup-paths.el).
2. I ripped out all the mechanism in xemacs.mak to set
PATH_PACKAGEPATH. Now only PACKAGE_PREFIX is recognized from
config.inc and that gets directly translated into
PATH_LATE_PACKAGE_DIRECTORIES.
Stephen, I have not added an additional packages layer preceding
{mule,site,xemacs}-packages. I think consensus ran against that
additional layer.
I'd like to apply this patch within a couple of days, so please try
this out and send along your comments.
Regards,
Vin
10:28 a.m.
Vin Shelton <acs(a)xemacs.org> writes:
Hello Vin, please use -U0 for ChangeLog patches.
Following hunk failed due to a recent commit by Marcus, which makes
the trailing context fail.
M-x patcher-mail
is your friend.
All other hunks applied fine with
M-x ediff-patch-file
which I have learned to love for its interactive nature of patching
and reviewing all in one.
Will build now.
Best regards,
Adrian
Index: lisp/ChangeLog
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/ChangeLog,v
retrieving revision 1.724
diff -a -u -r1.724 ChangeLog
--- lisp/ChangeLog 2006/02/26 14:29:08 1.724
+++ lisp/ChangeLog 2006/03/11 22:50:43
＠＠ -1,3 +1,10 ＠＠
+2006-02-26 Vin Shelton <acs(a)xemacs.org>
+
+ * setup-paths.el (paths-emacs-data-root-p): Add search for package
+ root.
+ (paths-find-invocation-roots): Add root-p parameter to test
+ plausibility of the roots.
+
2006-02-26 Mike Sperber <mike(a)xemacs.org>
* lisp-mode.el (lisp-send-defun): Remove this function; the
--
Adrian Aichner
mailto:adrian＠xemacs.org
http://www.xemacs.org/
3:45 p.m.
Looks good to me. Thanks for working on this!
--
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla
1:20 a.m.
New subject: [AC21.5] Find a relative package root at runtime
Commit 21.5
On 3/11/06, Vin Shelton <acs(a)xemacs.org> wrote:
Here is the latest (final, I hope) version of my 21.5
package-finding
patch. This patch will enable me to cons up a 21.5 native setup kit
that will be compatible with the 21.4 kit.
Changes since last version:
1. Per Michael's comments, runtime searching for a package root
using xemacs-packages is only for win32 configuration (I took out
the check for cygwin in setup-paths.el).
2. I ripped out all the mechanism in xemacs.mak to set
PATH_PACKAGEPATH. Now only PACKAGE_PREFIX is recognized from
config.inc and that gets directly translated into
PATH_LATE_PACKAGE_DIRECTORIES.
Stephen, I have not added an additional packages layer preceding
{mule,site,xemacs}-packages. I think consensus ran against that
additional layer.
I'd like to apply this patch within a couple of days, so please try
this out and send along your comments.
6611
days inactive
6625
days old
11 comments
6 participants
participants (6)
-
Adrian Aichner -
Michael Sperber -
Robert Pluim -
Stephen J. Turnbull -
Vin Shelton -
Vin Shelton