[COMMIT] Don't run #'test-chars on unicode-internal, mule-tests.el
APPROVE COMMIT
NOTE: This patch has been committed
# HG changeset patch
# User Aidan Kehoe <kehoea(a)parhasard.net>
# Date 1509284891 0
# Sun Oct 29 13:48:11 2017 +0000
# Node ID 450ec5be18d1431b8a6f8377d836a2bc86f59f59
# Parent 75c2debd5be652fa2c9959d9a7b01c66248d3712
Don't run #'test-chars on unicode-internal, mule-tests.el
tests/ChangeLog addition:
2017-10-29 Aidan Kehoe <kehoea(a)parhasard.net>
* automated/mule-tests.el:
Don't run #'test-chars on unicode-internal, the time and memory
demands for inserting #x40000000 characters, then comparing them
to a string constructed separately make it impractical.
diff -r 75c2debd5be6 -r 450ec5be18d1 tests/ChangeLog
--- a/tests/ChangeLog Sat Oct 28 11:55:04 2017 +0100
+++ b/tests/ChangeLog Sun Oct 29 13:48:11 2017 +0000
＠＠ -1,3 +1,10 ＠＠
+2017-10-29 Aidan Kehoe <kehoea(a)parhasard.net>
+
+ * automated/mule-tests.el:
+ Don't run #'test-chars on unicode-internal, the time and memory
+ demands for inserting #x40000000 characters, then comparing them
+ to a string constructed separately make it impractical.
+
2017-09-30 Aidan Kehoe <kehoea(a)parhasard.net>
* automated/extent-tests.el:
diff -r 75c2debd5be6 -r 450ec5be18d1 tests/automated/mule-tests.el
--- a/tests/automated/mule-tests.el Sat Oct 28 11:55:04 2017 +0100
+++ b/tests/automated/mule-tests.el Sun Oct 29 13:48:11 2017 +0000
＠＠ -74,9 +74,14 ＠＠
(insert string)
(assert (equal (buffer-string) string))))))
-;; Run #'test-chars in byte-compiled mode only.
-(when (compiled-function-p (symbol-function 'test-chars))
- (test-chars t))
+(Skip-Test-Unless
+ ;; unicode-internal has a value of #x40000000, (expt 2 30), for
+ ;; char-code-limit and even re-writing the above to avoid allocating the list
+ ;; and the string means I run out of memory when I attempt to run this.
+ (<= char-code-limit #x200000)
+ "CHAR-CODE-LIMIT is impractically large"
+ ;; Run #'test-chars in byte-compiled mode only.
+ (and (compiled-function-p (symbol-function 'test-chars)) (test-chars t)))
(defun unicode-code-point-to-utf-8-string (code-point)
"Convert a Unicode code point to the equivalent UTF-8 string.
--
‘As I sat looking up at the Guinness ad, I could never figure out /
How your man stayed up on the surfboard after forty pints of stout’
(C. Moore)