Re: [A21.5R21.4] [PATCH 21.5] #'featurep byte-optimisation
* Aidan Kehoe <kehoea(a)parhasard.net> writes:
Ar an ceathrú lá de mí Méan Fómhair, scríobh Steve Youngs:
> * Aidan Kehoe <kehoea(a)parhasard.net> writes:
>
> > Ar an dara lá de mí Méan Fómhair, scríobh Steve Youngs:
> >> APPROVE 21.5 RECOMMEND 21.4
> >>
> >> This patch optimises #'featurep for the cases...
> >>
> >> (featurep 'xemacs) and (featurep 'sxemacs)
> >>
> >> ...making the former be always t and the latter be nil.
>
> > The latter behaviour is inappropriate, isn’t it?
>
> Not at all. You don't want (featurep 'sxemacs) returning t on XEmacs do
> you?
Nope. But it shouldn’t be optimised away to nil if the code is to run
on
SXEmacs, though! Test case, with your patch applied to XEmacs:
$ echo "(if (featurep 'sxemacs) (message \"in
SXEmacs\") (message \"not\"))" > /tmp/whatever.el
$ ~/xemacs-21.5/src/xemacs -batch -f batch-byte-compile /tmp/whatever.el
Compiling /tmp/whatever.el...
Wrote /tmp/whatever.elc
Done
$ ~/sxemacs-22.1.6/src/sxemacs -batch -l /tmp/whatever.elc
not
$
Oh hell! You are absolutely right. And it would be just as bad going
the other way... compile with SXE and run with XE.
Here's the patch to revert it, could somebody please apply it for me
(Norbert?)
2007-09-04 Steve Youngs <steve(a)sxemacs.org>
* byte-optimize.el (byte-optimize-featurep): Remove. It's wrong.
--
|---<Steve Youngs>---------------<GnuPG KeyID: A94B3003>---|
| SXEmacs - The only _______ you'll ever need. |
| Fill in the blank, yes, it's THAT good! |
|------------------------------------<steve(a)sxemacs.org>---|
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
Attachments:
- attachment.sig (application/pgp-signature — 312 bytes)
- attachment.bin (text/x-patch — 535 bytes)