[COMMIT] #'custom-add-to-group: warn if GROUP is nil.

APPROVE COMMIT NOTE: This patch has been committed. # HG changeset patch # User Aidan Kehoe <kehoea(a)parhasard.net&gt; # Date 1300947745 0 # Node ID 294ab9180fad2da8aef81412c91f1a81517d64db # Parent d363790fd936879ef0414abd81afd7ea7f25f3ee #'custom-add-to-group: warn if GROUP is nil. 2011-03-24 Aidan Kehoe <kehoea(a)parhasard.net&gt; * custom.el (custom-add-to-group): Warn if adding an option to the nil group; this is usually an error on the part of the programmer. * cmdloop.el (suggest-key-bindings): Specify a group for this variable, it didn't previously have one. diff -r d363790fd936 -r 294ab9180fad lisp/ChangeLog --- a/lisp/ChangeLog Wed Mar 23 00:08:35 2011 +0100 +++ b/lisp/ChangeLog Thu Mar 24 06:22:25 2011 +0000 ＠＠ -1,3 +1,11 ＠＠ +2011-03-24 Aidan Kehoe <kehoea(a)parhasard.net&gt; + + * custom.el (custom-add-to-group): + Warn if adding an option to the nil group; this is usually an + error on the part of the programmer. + * cmdloop.el (suggest-key-bindings): + Specify a group for this variable, it didn't previously have one. + 2011-03-21 Aidan Kehoe <kehoea(a)parhasard.net&gt; * cl-macs.el (revappend, nreconc): diff -r d363790fd936 -r 294ab9180fad lisp/cmdloop.el --- a/lisp/cmdloop.el Wed Mar 23 00:08:35 2011 +0100 +++ b/lisp/cmdloop.el Thu Mar 24 06:22:25 2011 +0000 ＠＠ -313,7 +313,8 ＠＠ :type '(choice (const :tag "off" nil) (integer :tag "time" 2) - (other :tag "on"))) + (other :tag "on")) +:group 'keyboard) (dontusethis-set-symbol-value-handler 'suggest-key-bindings diff -r d363790fd936 -r 294ab9180fad lisp/custom.el --- a/lisp/custom.el Wed Mar 23 00:08:35 2011 +0100 +++ b/lisp/custom.el Thu Mar 24 06:22:25 2011 +0000 ＠＠ -409,6 +409,9 ＠＠ (defun custom-add-to-group (group option widget) "To existing GROUP add a new OPTION of type WIDGET. If there already is an entry for OPTION and WIDGET, nothing is done." + (or group (display-warning 'custom + (format "custom: widget %s, option %s has no associated group" + widget option))) (let ((members (get group 'custom-group)) (entry (list option widget))) (unless (member entry members) -- “Apart from the nine-banded armadillo, man is the only natural host of Mycobacterium leprae, although it can be grown in the footpads of mice.” -- Kumar & Clark, Clinical Medicine, summarising improbable leprosy research _______________________________________________ XEmacs-Patches mailing list XEmacs-Patches(a)xemacs.org http://lists.xemacs.org/mailman/listinfo/xemacs-patches