commit: Remove all autoload cookies from dumped files, they're needless and confusing.
13 years, 7 months
Aidan Kehoe
Aidan Kehoe
changeset: 5490:8861440b1aa4
tag: tip
user: Aidan Kehoe <kehoea(a)parhasard.net>
date: Sun May 01 17:43:14 2011 +0100
files: lisp/ChangeLog lisp/buff-menu.el lisp/cus-file.el lisp/menubar.el lisp/mule/mule-composite.el lisp/newcomment.el lisp/x-win-sun.el lisp/x-win-xfree86.el
description:
Remove all autoload cookies from dumped files, they're needless and confusing.
lisp/ChangeLog addition:
2011-05-01 Aidan Kehoe <kehoea(a)parhasard.net>
* buff-menu.el (list-buffers-directory):
* buff-menu.el (default-list-buffers-identification):
* cus-file.el (custom-file-base):
* cus-file.el (custom-file):
* cus-file.el (make-custom-file-name):
* menubar.el (menu-split-long-menu):
* newcomment.el:
* newcomment.el (indent-for-comment):
* newcomment.el (comment-column):
* newcomment.el (comment-start):
* newcomment.el (comment-start-skip):
* newcomment.el (comment-end-skip):
* newcomment.el (comment-end):
* newcomment.el (comment-indent-function):
* newcomment.el (comment-style):
* newcomment.el (comment-padding):
* newcomment.el (comment-multi-line):
* newcomment.el (comment-normalize-vars):
* newcomment.el (comment-indent):
* newcomment.el (comment-set-column):
* newcomment.el (comment-kill):
* newcomment.el (uncomment-region):
* newcomment.el (comment-region):
* newcomment.el (comment-or-uncomment-region):
* newcomment.el (comment-dwim):
* newcomment.el (comment-indent-new-line):
* x-win-sun.el (x-win-init-sun):
* x-win-xfree86.el (x-win-init-xfree86):
* mule/mule-composite.el:
* mule/mule-composite.el (reference-point-alist):
* mule/mule-composite.el (compose-region):
* mule/mule-composite.el (decompose-region):
* mule/mule-composite.el (compose-string):
* mule/mule-composite.el (decompose-string):
* mule/mule-composite.el (compose-chars):
* mule/mule-composite.el (find-composition):
* mule/mule-composite.el (compose-chars-after):
* mule/mule-composite.el (compose-last-chars):
* mule/mule-composite.el (decompose-composite-char):
Remove all autoload cookies from dumped files, they're needless
and confusing.
diff -r 159face738c3 -r 8861440b1aa4 lisp/ChangeLog
--- a/lisp/ChangeLog Sun May 01 13:51:33 2011 +0100
+++ b/lisp/ChangeLog Sun May 01 17:43:14 2011 +0100
＠＠ -1,3 +1,47 ＠＠
+2011-05-01 Aidan Kehoe <kehoea(a)parhasard.net>
+
+ * buff-menu.el (list-buffers-directory):
+ * buff-menu.el (default-list-buffers-identification):
+ * cus-file.el (custom-file-base):
+ * cus-file.el (custom-file):
+ * cus-file.el (make-custom-file-name):
+ * menubar.el (menu-split-long-menu):
+ * newcomment.el:
+ * newcomment.el (indent-for-comment):
+ * newcomment.el (comment-column):
+ * newcomment.el (comment-start):
+ * newcomment.el (comment-start-skip):
+ * newcomment.el (comment-end-skip):
+ * newcomment.el (comment-end):
+ * newcomment.el (comment-indent-function):
+ * newcomment.el (comment-style):
+ * newcomment.el (comment-padding):
+ * newcomment.el (comment-multi-line):
+ * newcomment.el (comment-normalize-vars):
+ * newcomment.el (comment-indent):
+ * newcomment.el (comment-set-column):
+ * newcomment.el (comment-kill):
+ * newcomment.el (uncomment-region):
+ * newcomment.el (comment-region):
+ * newcomment.el (comment-or-uncomment-region):
+ * newcomment.el (comment-dwim):
+ * newcomment.el (comment-indent-new-line):
+ * x-win-sun.el (x-win-init-sun):
+ * x-win-xfree86.el (x-win-init-xfree86):
+ * mule/mule-composite.el:
+ * mule/mule-composite.el (reference-point-alist):
+ * mule/mule-composite.el (compose-region):
+ * mule/mule-composite.el (decompose-region):
+ * mule/mule-composite.el (compose-string):
+ * mule/mule-composite.el (decompose-string):
+ * mule/mule-composite.el (compose-chars):
+ * mule/mule-composite.el (find-composition):
+ * mule/mule-composite.el (compose-chars-after):
+ * mule/mule-composite.el (compose-last-chars):
+ * mule/mule-composite.el (decompose-composite-char):
+ Remove all autoload cookies from dumped files, they're needless
+ and confusing.
+
2011-04-30 Didier Verna <didier(a)xemacs.org>
* subr.el (looking-back): New function.
diff -r 159face738c3 -r 8861440b1aa4 lisp/buff-menu.el
--- a/lisp/buff-menu.el Sun May 01 13:51:33 2011 +0100
+++ b/lisp/buff-menu.el Sun May 01 17:43:14 2011 +0100
＠＠ -510,10 +510,7 ＠＠
(make-variable-buffer-local 'list-buffers-identification)
;; XEmacs
-;;;###autoload
(defvar list-buffers-directory nil)
-
-;;;###autoload
(make-variable-buffer-local 'list-buffers-directory)
;; #### not synched
diff -r 159face738c3 -r 8861440b1aa4 lisp/cus-file.el
--- a/lisp/cus-file.el Sun May 01 13:51:33 2011 +0100
+++ b/lisp/cus-file.el Sun May 01 17:43:14 2011 +0100
＠＠ -31,17 +31,14 ＠＠
;;; Code:
(provide 'cus-file)
-;;;###autoload
(defconst custom-file-base "custom.el"
"Base of file name for storing customization information.")
-;;;###autoload
(defvar custom-file nil
"File used for storing customization information.
If you change this from the default you need to
explicitly load that file for the settings to take effect.")
-;;;###autoload
(defun make-custom-file-name (init-file &optional force-new)
"Construct the default custom file name from the init file name.
If FORCE-NEW is non-nil, force post-migration location."
diff -r 159face738c3 -r 8861440b1aa4 lisp/menubar.el
--- a/lisp/menubar.el Sun May 01 13:51:33 2011 +0100
+++ b/lisp/menubar.el Sun May 01 17:43:14 2011 +0100
＠＠ -566,7 +566,6 ＠＠
accelerator specs -- this works even if the specs have already been added."
(menu-split-long-menu (menu-sort-menu menu)))
-;;;###autoload
(defun menu-split-long-menu (menu)
"Split MENU according to `menu-max-items' and add accelerator specs.
If MENU already has accelerator specs, they will be removed and new ones
diff -r 159face738c3 -r 8861440b1aa4 lisp/mule/mule-composite.el
--- a/lisp/mule/mule-composite.el Sun May 01 13:51:33 2011 +0100
+++ b/lisp/mule/mule-composite.el Sun May 01 17:43:14 2011 +0100
＠＠ -26,7 +26,6 ＠＠
;;; Code:
-;;;###autoload
(defconst reference-point-alist
'((tl . 0) (tc . 1) (tr . 2)
(Bl . 3) (Bc . 4) (Br . 5)
＠＠ -155,7 +154,6 ＠＠
(setq i (+ i 2))))
components)
-;;;###autoload
(defun compose-region (start end &optional components modification-func)
"UNIMPLEMENTED.
Compose characters in the current region.
＠＠ -193,7 +191,6 ＠＠
(compose-region-internal start end components modification-func)
(set-buffer-modified-p modified-p)))
-;;;###autoload
(defun decompose-region (start end)
"UNIMPLEMENTED.
Decompose text in the current region.
＠＠ -206,7 +203,6 ＠＠
(remove-text-properties start end '(composition nil))
(set-buffer-modified-p modified-p)))
-;;;###autoload
(defun compose-string (string &optional start end components modification-func)
"UNIMPLEMENTED.
Compose characters in string STRING.
＠＠ -232,14 +228,12 ＠＠
(compose-string-internal string start end components modification-func)
string)
-;;;###autoload
(defun decompose-string (string)
"UNIMPLEMENTED.
Return STRING where `composition' property is removed."
(remove-text-properties 0 (length string) '(composition nil) string)
string)
-;;;###autoload
(defun compose-chars (&rest args)
"UNIMPLEMENTED.
Return a string from arguments in which all characters are composed.
＠＠ -264,7 +258,6 ＠＠
(setq str (concat args)))
(compose-string-internal str 0 (length str) components)))
-;;;###autoload
(defun find-composition (pos &optional limit string detail-p)
"UNIMPLEMENTED.
Return information about a composition at or nearest to buffer position POS.
＠＠ -305,7 +298,6 ＠＠
result))
-;;;###autoload
(defun compose-chars-after (pos &optional limit object)
"UNIMPLEMENTED.
Compose characters in current buffer after position POS.
＠＠ -347,7 +339,6 ＠＠
(setq func nil tail (cdr tail)))))))
result))
-;;;###autoload
(defun compose-last-chars (args)
"UNIMPLEMENTED.
Compose last characters.
＠＠ -369,13 +360,12 ＠＠
(compose-region (- (point) chars) (point) (nth 2 args))
(compose-chars-after (- (point) chars) (point))))))
-;;;###autoload(global-set-key [compose-last-chars] 'compose-last-chars)
+;;;don't ###autoload(global-set-key [compose-last-chars] 'compose-last-chars)
;;; The following codes are only for backward compatibility with Emacs
;;; 20.4 and the earlier.
-;;;###autoload
(defun decompose-composite-char (char &optional type with-composition-rule)
"UNIMPLEMENTED.
Convert CHAR to string.
diff -r 159face738c3 -r 8861440b1aa4 lisp/newcomment.el
--- a/lisp/newcomment.el Sun May 01 13:51:33 2011 +0100
+++ b/lisp/newcomment.el Sun May 01 17:43:14 2011 +0100
＠＠ -64,13 +64,9 ＠＠
;;; Code:
-;;;###autoload
(defalias 'indent-for-comment 'comment-indent)
-;;;###autoload
(defalias 'set-comment-column 'comment-set-column)
-;;;###autoload
(defalias 'kill-comment 'comment-kill)
-;;;###autoload
(defalias 'indent-new-comment-line 'comment-indent-new-line)
(defgroup comment nil
＠＠ -90,7 +86,6 ＠＠
"Column to use for `comment-indent'. If nil, use `fill-column' instead."
:type '(choice (const nil) integer))
-;;;###autoload
(defcustom comment-column 32
"*Column to indent right-margin comments to.
Each mode establishes a different default value for this variable; you
＠＠ -100,26 +95,21 ＠＠
:type 'integer)
(make-variable-buffer-local 'comment-column)
-;;;###autoload
(defvar comment-start nil
"*String to insert to start a new comment, or nil if no comment syntax.")
-;;;###autoload
(defvar comment-start-skip nil
"*Regexp to match the start of a comment plus everything up to its body.
If there are any \\(...\\) pairs, the comment delimiter text is held to begin
at the place matched by the close of the first pair.")
-;;;###autoload
(defvar comment-end-skip nil
"Regexp to match the end of a comment plus everything up to its body.")
-;;;###autoload
(defvar comment-end ""
"*String to insert to end a new comment.
Should be an empty string if comments are terminated by end-of-line.")
-;;;###autoload
(defvar comment-indent-function 'comment-indent-default
"Function to compute desired indentation for a comment.
This function is called with no args with point at the beginning of
＠＠ -168,7 +158,6 ＠＠
INDENT specifies that the `comment-start' markers should not be put at the
left margin but at the current indentation of the region to comment.")
-;;;###autoload
(defcustom comment-style 'plain
"*Style to be used for `comment-region'.
See `comment-styles' for a list of available styles."
＠＠ -176,7 +165,6 ＠＠
`(choice ,＠(mapcar (lambda (s) `(const ,(car s))) comment-styles))
'symbol))
-;;;###autoload
(defcustom comment-padding " "
"Padding string that `comment-region' puts between comment chars and text.
Can also be an integer which will be automatically turned into a string
＠＠ -186,7 +174,6 ＠＠
makes the comment easier to read. Default is 1. nil means 0."
:type '(choice string integer (const nil)))
-;;;###autoload
(defcustom comment-multi-line t ; XEmacs - this works well with adaptive fill
"*Non-nil means \\[indent-new-comment-line] should continue same comment
on new line, with no new terminator or starter.
＠＠ -208,7 +195,6 ＠＠
"Return the mirror image of string S, without any trailing space."
(comment-string-strip (concat (nreverse (string-to-list s))) nil t))
-;;;###autoload
(defun comment-normalize-vars (&optional noerror)
(if (not comment-start) (or noerror (error "No comment syntax is defined"))
;; comment-use-syntax
＠＠ -431,7 +417,6 ＠＠
;;;; Commands
;;;;
-;;;###autoload
;; #### XEmacs had this: in place of just (current-column)
; (defconst comment-indent-function
＠＠ -460,7 +445,6 ＠＠
(and (> comment-add 0) (looking-at "\\s<\\S<")))
comment-column)))
-;;;###autoload
(defun comment-indent (&optional continue)
"Indent this line's comment to comment column, or insert an empty comment.
If CONTINUE is non-nil, use the `comment-continue' markers if any.
＠＠ -525,7 +509,6 ＠＠
(goto-char cpos)
(set-marker cpos nil))))
-;;;###autoload
(defun comment-set-column (arg)
"Set the comment column based on point.
With no ARG, set the comment column to the current column.
＠＠ -547,7 +530,6 ＠＠
(t (setq comment-column (current-column))
(lmessage 'command "Comment column set to %d" comment-column))))
-;;;###autoload
(defun comment-kill (arg)
"Kill the comment on this line, if any.
With prefix ARG, kill comments on that many lines starting with this one."
＠＠ -639,7 +621,6 ＠＠
(if multi (concat (regexp-quote (string c)) "*"))
(regexp-quote s))))))
-;;;###autoload
(defun uncomment-region (beg end &optional arg)
"Uncomment each line in the BEG .. END region.
The numeric prefix ARG can specify a number of chars to remove from the
＠＠ -870,7 +851,6 ＠＠
(end-of-line)
(not (or (eobp) (progn (forward-line) nil))))))))))
-;;;###autoload
(defun comment-region (beg end &optional arg)
"Comment or uncomment each line in the region.
With just \\[universal-argument] prefix arg, uncomment each line in region BEG .. END.
＠＠ -946,7 +926,6 ＠＠
(comment-region beg end (+ comment-add arg))))
-;;;###autoload
(defun comment-or-uncomment-region (beg end &optional arg)
"Call `comment-region', unless the region only consists of comments,
in which case call `uncomment-region'. If a prefix arg is given, it
＠＠ -959,7 +938,6 ＠＠
'uncomment-region 'comment-region)
beg end arg))
-;;;###autoload
(defun comment-dwim (arg)
"Call the comment command you want (Do What I Mean).
If the region is active and `transient-mark-mode' is on, call
＠＠ -1000,7 +978,6 ＠＠
(string-match (concat "\\`[ \t]*\\(?:" comment-start-skip "\\)")
fill-prefix)))
-;;;###autoload
(defun comment-indent-new-line (&optional soft)
"Break line at point and indent, continuing comment if within one.
This indents the body of the continued comment
diff -r 159face738c3 -r 8861440b1aa4 lisp/x-win-sun.el
--- a/lisp/x-win-sun.el Sun May 01 13:51:33 2011 +0100
+++ b/lisp/x-win-sun.el Sun May 01 17:43:14 2011 +0100
＠＠ -65,7 +65,6 ＠＠
(globally-declare-fboundp
'(x-keysym-on-keyboard-sans-modifiers-p))
-;;;###autoload
(defun x-win-init-sun (device)
;; help is ok
diff -r 159face738c3 -r 8861440b1aa4 lisp/x-win-xfree86.el
--- a/lisp/x-win-xfree86.el Sun May 01 13:51:33 2011 +0100
+++ b/lisp/x-win-xfree86.el Sun May 01 17:43:14 2011 +0100
＠＠ -42,7 +42,6 ＠＠
(globally-declare-fboundp
'(x-keysym-on-keyboard-p x-keysym-on-keyboard-sans-modifiers-p))
-;;;###autoload
(defun x-win-init-xfree86 (device)
;; We know this keyboard is an XFree86 keyboard. As such, we can predict
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches
- 1 participants
- 0 comments
[COMMIT] Never pass a leading + to mpz_set_string, parse_integer ().
13 years, 7 months
Aidan Kehoe
Aidan Kehoe
APPROVE COMMIT
NOTE: This patch has been committed.
# HG changeset patch
# User Aidan Kehoe <kehoea(a)parhasard.net>
# Date 1304254293 -3600
# Node ID 159face738c3bfd6691d64cc235fa13fc84e61b5
# Parent 1e544fd7be12682d959a810d0970e29107669a3f
Never pass a leading + to mpz_set_string, parse_integer ().
src/ChangeLog addition:
2011-05-01 Aidan Kehoe <kehoea(a)parhasard.net>
* lread.c (parse_integer):
GMP's mpz_set_string deals with a leading plus badly, make sure it
never sees one coming from this function.
tests/ChangeLog addition:
2011-05-01 Aidan Kehoe <kehoea(a)parhasard.net>
* automated/lisp-reader-tests.el:
If the bignum feature is available, check that a leading plus sign
is treated correctly when reading bignum integers.
diff -r 1e544fd7be12 -r 159face738c3 src/ChangeLog
--- a/src/ChangeLog Sat Apr 30 17:38:35 2011 +0200
+++ b/src/ChangeLog Sun May 01 13:51:33 2011 +0100
＠＠ -1,3 +1,9 ＠＠
+2011-05-01 Aidan Kehoe <kehoea(a)parhasard.net>
+
+ * lread.c (parse_integer):
+ GMP's mpz_set_string deals with a leading plus badly, make sure it
+ never sees one coming from this function.
+
2010-12-31 Mike Kupfer <mike.kupfer(a)xemacs.org>
* redisplay.c (pixel_to_glyph_translation):
diff -r 1e544fd7be12 -r 159face738c3 src/lread.c
--- a/src/lread.c Sat Apr 30 17:38:35 2011 +0200
+++ b/src/lread.c Sun May 01 13:51:33 2011 +0100
＠＠ -2028,6 +2028,9 ＠＠
else if (*p == '+')
{
p++;
+ /* GMP deals with a leading plus sign, badly, make sure it doesn't see
+ it. */
+ buf++;
}
if (p == lim)
diff -r 1e544fd7be12 -r 159face738c3 tests/ChangeLog
--- a/tests/ChangeLog Sat Apr 30 17:38:35 2011 +0200
+++ b/tests/ChangeLog Sun May 01 13:51:33 2011 +0100
＠＠ -1,3 +1,9 ＠＠
+2011-05-01 Aidan Kehoe <kehoea(a)parhasard.net>
+
+ * automated/lisp-reader-tests.el:
+ If the bignum feature is available, check that a leading plus sign
+ is treated correctly when reading bignum integers.
+
2011-04-29 Stephen J. Turnbull <stephen(a)xemacs.org>
* XEmacs 21.5.31 "ginger" is released.
diff -r 1e544fd7be12 -r 159face738c3 tests/automated/lisp-reader-tests.el
--- a/tests/automated/lisp-reader-tests.el Sat Apr 30 17:38:35 2011 +0200
+++ b/tests/automated/lisp-reader-tests.el Sun May 01 13:51:33 2011 +0100
＠＠ -76,3 +76,14 ＠＠
(insert string)
(Check-Error-Message invalid-read-syntax "unrecognized raw string"
(eval-buffer))))
+
+(when (featurep 'bignum)
+ ;; This failed, up to 20110501.
+ (Assert (eql (1+ most-positive-fixnum)
+ (read (format "+%d" (1+ most-positive-fixnum))))
+ "checking leading + is handled properly if reading a bignum")
+ ;; This never did.
+ (Assert (eql (1- most-positive-fixnum)
+ (read (format "+%d" (1- most-positive-fixnum))))
+ "checking leading + is handled properly if reading a fixnum"))
+
--
“Apart from the nine-banded armadillo, man is the only natural host of
Mycobacterium leprae, although it can be grown in the footpads of mice.”
-- Kumar & Clark, Clinical Medicine, summarising improbable leprosy research
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches
- 1 participants
- 0 comments
commit: Never pass a leading + to mpz_set_string, parse_integer ().
13 years, 7 months
Aidan Kehoe
Aidan Kehoe
changeset: 5489:159face738c3
tag: tip
user: Aidan Kehoe <kehoea(a)parhasard.net>
date: Sun May 01 13:51:33 2011 +0100
files: src/ChangeLog src/lread.c tests/ChangeLog tests/automated/lisp-reader-tests.el
description:
Never pass a leading + to mpz_set_string, parse_integer ().
src/ChangeLog addition:
2011-05-01 Aidan Kehoe <kehoea(a)parhasard.net>
* lread.c (parse_integer):
GMP's mpz_set_string deals with a leading plus badly, make sure it
never sees one coming from this function.
tests/ChangeLog addition:
2011-05-01 Aidan Kehoe <kehoea(a)parhasard.net>
* automated/lisp-reader-tests.el:
If the bignum feature is available, check that a leading plus sign
is treated correctly when reading bignum integers.
diff -r 1e544fd7be12 -r 159face738c3 src/ChangeLog
--- a/src/ChangeLog Sat Apr 30 17:38:35 2011 +0200
+++ b/src/ChangeLog Sun May 01 13:51:33 2011 +0100
＠＠ -1,3 +1,9 ＠＠
+2011-05-01 Aidan Kehoe <kehoea(a)parhasard.net>
+
+ * lread.c (parse_integer):
+ GMP's mpz_set_string deals with a leading plus badly, make sure it
+ never sees one coming from this function.
+
2010-12-31 Mike Kupfer <mike.kupfer(a)xemacs.org>
* redisplay.c (pixel_to_glyph_translation):
diff -r 1e544fd7be12 -r 159face738c3 src/lread.c
--- a/src/lread.c Sat Apr 30 17:38:35 2011 +0200
+++ b/src/lread.c Sun May 01 13:51:33 2011 +0100
＠＠ -2028,6 +2028,9 ＠＠
else if (*p == '+')
{
p++;
+ /* GMP deals with a leading plus sign, badly, make sure it doesn't see
+ it. */
+ buf++;
}
if (p == lim)
diff -r 1e544fd7be12 -r 159face738c3 tests/ChangeLog
--- a/tests/ChangeLog Sat Apr 30 17:38:35 2011 +0200
+++ b/tests/ChangeLog Sun May 01 13:51:33 2011 +0100
＠＠ -1,3 +1,9 ＠＠
+2011-05-01 Aidan Kehoe <kehoea(a)parhasard.net>
+
+ * automated/lisp-reader-tests.el:
+ If the bignum feature is available, check that a leading plus sign
+ is treated correctly when reading bignum integers.
+
2011-04-29 Stephen J. Turnbull <stephen(a)xemacs.org>
* XEmacs 21.5.31 "ginger" is released.
diff -r 1e544fd7be12 -r 159face738c3 tests/automated/lisp-reader-tests.el
--- a/tests/automated/lisp-reader-tests.el Sat Apr 30 17:38:35 2011 +0200
+++ b/tests/automated/lisp-reader-tests.el Sun May 01 13:51:33 2011 +0100
＠＠ -76,3 +76,14 ＠＠
(insert string)
(Check-Error-Message invalid-read-syntax "unrecognized raw string"
(eval-buffer))))
+
+(when (featurep 'bignum)
+ ;; This failed, up to 20110501.
+ (Assert (eql (1+ most-positive-fixnum)
+ (read (format "+%d" (1+ most-positive-fixnum))))
+ "checking leading + is handled properly if reading a bignum")
+ ;; This never did.
+ (Assert (eql (1- most-positive-fixnum)
+ (read (format "+%d" (1- most-positive-fixnum))))
+ "checking leading + is handled properly if reading a fixnum"))
+
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches
- 1 participants
- 0 comments