March 2011 - XEmacs-Patches - XEmacs Mailing List Archives

commit: Make listu() and listn() assemble lists in forward order. Use them. 13 years, 1 month

Jerry James

changeset: 5386:af961911bcb2 tag: tip user: Jerry James <james(a)xemacs.org> date: Tue Mar 29 15:59:56 2011 -0600 files: src/ChangeLog src/alloc.c src/dired.c src/editfns.c src/faces.c description: Make listu() and listn() assemble lists in forward order. Use them. See xemacs-patches message with ID <AANLkTi=Tnd_e8WqiGBE2DmNGmY7zhqxhVNtxECnQo8w9(a)mail.gmail.com> diff -r 436e67ca8c79 -r af961911bcb2 src/ChangeLog --- a/src/ChangeLog Tue Mar 29 17:28:34 2011 +0100 +++ b/src/ChangeLog Tue Mar 29 15:59:56 2011 -0600 ＠＠ -1,3 +1,13 ＠＠ +2011-03-24 Jerry James <james(a)xemacs.org> + + * alloc.c (listu): Assemble the list in the right order so we don't + have to reverse it. + (listn): Ditto. + * dired.c (Ffile_attributes): Use listn instead of building an array + to pass to Flist. GC protect the mode string. + * editfns.c (Fdecode_time): Use listn instead of Flist. + * faces.c (vars_of_faces): Use listu instead of Flist. + 2011-03-24 Jerry James <james(a)xemacs.org> * README.kkcc: "occured" -> "occurred". diff -r 436e67ca8c79 -r af961911bcb2 src/alloc.c --- a/src/alloc.c Tue Mar 29 17:28:34 2011 +0100 +++ b/src/alloc.c Tue Mar 29 15:59:56 2011 -0600 ＠＠ -1465,18 +1465,23 ＠＠ listu (Lisp_Object first, ...) { Lisp_Object obj = Qnil; - Lisp_Object val; - va_list va; - - va_start (va, first); - val = first; - while (!UNBOUNDP (val)) - { - obj = Fcons (val, obj); + + if (!UNBOUNDP (first)) + { + va_list va; + Lisp_Object last, val; + + last = obj = Fcons (first, Qnil); + va_start (va, first); val = va_arg (va, Lisp_Object); - } - va_end (va); - return Fnreverse (obj); + while (!UNBOUNDP (val)) + { + last = XCDR (last) = Fcons (val, Qnil); + val = va_arg (va, Lisp_Object); + } + va_end (va); + } + return obj; } /* Return a list of arbitrary length, with length specified and remaining ＠＠ -1485,15 +1490,21 ＠＠ Lisp_Object listn (int num_args, ...) { - int i; Lisp_Object obj = Qnil; - va_list va; - - va_start (va, num_args); - for (i = 0; i < num_args; i++) - obj = Fcons (va_arg (va, Lisp_Object), obj); - va_end (va); - return Fnreverse (obj); + + if (num_args > 0) + { + va_list va; + Lisp_Object last; + int i; + + va_start (va, num_args); + last = obj = Fcons (va_arg (va, Lisp_Object), Qnil); + for (i = 1; i < num_args; i++) + last = XCDR (last) = Fcons (va_arg (va, Lisp_Object), Qnil); + va_end (va); + } + return obj; } /* Return a list of arbitrary length, with length specified and an array diff -r 436e67ca8c79 -r af961911bcb2 src/dired.c --- a/src/dired.c Tue Mar 29 17:28:34 2011 +0100 +++ b/src/dired.c Tue Mar 29 15:59:56 2011 -0600 ＠＠ -845,14 +845,13 ＠＠ (filename)) { /* This function can GC. GC checked 1997.06.04. */ - Lisp_Object values[12]; Lisp_Object directory = Qnil; struct stat s; char modes[10]; - Lisp_Object handler; - struct gcpro gcpro1, gcpro2; + Lisp_Object handler, mode, modestring = Qnil, size, gid; + struct gcpro gcpro1, gcpro2, gcpro3; - GCPRO2 (filename, directory); + GCPRO3 (filename, directory, modestring); filename = Fexpand_file_name (filename, Qnil); /* If the file name has special constructs in it, ＠＠ -893,49 +892,54 ＠＠ switch (s.st_mode & S_IFMT) { default: - values[0] = Qnil; + mode = Qnil; break; case S_IFDIR: - values[0] = Qt; + mode = Qt; break; #ifdef S_IFLNK case S_IFLNK: - values[0] = Ffile_symlink_p (filename); + mode = Ffile_symlink_p (filename); break; #endif } - values[1] = make_int (s.st_nlink); - values[2] = make_int (s.st_uid); - values[3] = make_int (s.st_gid); - values[4] = make_time (s.st_atime); - values[5] = make_time (s.st_mtime); - values[6] = make_time (s.st_ctime); #ifndef HAVE_BIGNUM - values[7] = make_integer (NUMBER_FITS_IN_AN_EMACS_INT (s.st_size) ? - (EMACS_INT)s.st_size : -1); + size = make_integer (NUMBER_FITS_IN_AN_EMACS_INT (s.st_size) ? + (EMACS_INT)s.st_size : -1); #else - values[7] = make_integer (s.st_size); -#endif + size = make_integer (s.st_size); +#endif filemodestring (&s, modes); - values[8] = make_string ((Ibyte *) modes, 10); + modestring = make_string ((Ibyte *) modes, 10), + #if defined (BSD4_2) || defined (BSD4_3) /* file gid will be dir gid */ { struct stat sdir; if (!NILP (directory) && qxe_stat (XSTRING_DATA (directory), &sdir) == 0) - values[9] = (sdir.st_gid != s.st_gid) ? Qt : Qnil; + gid = (sdir.st_gid != s.st_gid) ? Qt : Qnil; else /* if we can't tell, assume worst */ - values[9] = Qt; + gid = Qt; } #else /* file gid will be egid */ - values[9] = (s.st_gid != getegid ()) ? Qt : Qnil; + gid = (s.st_gid != getegid ()) ? Qt : Qnil; #endif /* BSD4_2 or BSD4_3 */ - values[10] = make_int (s.st_ino); - values[11] = make_int (s.st_dev); - UNGCPRO; - return Flist (countof (values), values); + + RETURN_UNGCPRO (listn (12, + mode, + make_int (s.st_nlink), + make_int (s.st_uid), + make_int (s.st_gid), + make_time (s.st_atime), + make_time (s.st_mtime), + make_time (s.st_ctime), + size, + modestring, + gid, + make_int (s.st_ino), + make_int (s.st_dev))); } diff -r 436e67ca8c79 -r af961911bcb2 src/editfns.c --- a/src/editfns.c Tue Mar 29 17:28:34 2011 +0100 +++ b/src/editfns.c Tue Mar 29 15:59:56 2011 -0600 ＠＠ -1102,29 +1102,28 ＠＠ time_t time_spec; struct tm save_tm; struct tm *decoded_time; - Lisp_Object list_args[9]; if (! lisp_to_time (specified_time, &time_spec)) invalid_argument ("Invalid time specification", Qunbound); decoded_time = localtime (&time_spec); - list_args[0] = make_int (decoded_time->tm_sec); - list_args[1] = make_int (decoded_time->tm_min); - list_args[2] = make_int (decoded_time->tm_hour); - list_args[3] = make_int (decoded_time->tm_mday); - list_args[4] = make_int (decoded_time->tm_mon + 1); - list_args[5] = make_int (decoded_time->tm_year + 1900); - list_args[6] = make_int (decoded_time->tm_wday); - list_args[7] = (decoded_time->tm_isdst)? Qt : Qnil; /* Make a copy, in case gmtime modifies the struct. */ save_tm = *decoded_time; decoded_time = gmtime (&time_spec); - if (decoded_time == 0) - list_args[8] = Qnil; - else - list_args[8] = make_int (difftm (&save_tm, decoded_time)); - return Flist (9, list_args); + + return listn(9, + make_int (save_tm.tm_sec), + make_int (save_tm.tm_min), + make_int (save_tm.tm_hour), + make_int (save_tm.tm_mday), + make_int (save_tm.tm_mon + 1), + make_int (save_tm.tm_year + 1900), + make_int (save_tm.tm_wday), + save_tm.tm_isdst ? Qt : Qnil, + (decoded_time == NULL) + ? Qnil + : make_int (difftm (&save_tm, decoded_time))); } static void set_time_zone_rule (Extbyte *tzstring); diff -r 436e67ca8c79 -r af961911bcb2 src/faces.c --- a/src/faces.c Tue Mar 29 17:28:34 2011 +0100 +++ b/src/faces.c Tue Mar 29 15:59:56 2011 -0600 ＠＠ -2227,26 +2227,11 ＠＠ debug_x_faces = 0; #endif - { - Lisp_Object syms[20]; - int n = 0; - - syms[n++] = Qforeground; - syms[n++] = Qbackground; - syms[n++] = Qfont; - syms[n++] = Qdisplay_table; - syms[n++] = Qbackground_pixmap; - syms[n++] = Qbackground_placement; - syms[n++] = Qunderline; - syms[n++] = Qstrikethru; - syms[n++] = Qhighlight; - syms[n++] = Qdim; - syms[n++] = Qblinking; - syms[n++] = Qreverse; - - Vbuilt_in_face_specifiers = Flist (n, syms); - staticpro (&Vbuilt_in_face_specifiers); - } + Vbuilt_in_face_specifiers = + listu (Qforeground, Qbackground, Qfont, Qdisplay_table, Qbackground_pixmap, + Qbackground_placement, Qunderline, Qstrikethru, Qhighlight, Qdim, + Qblinking, Qreverse, Qunbound); + staticpro (&Vbuilt_in_face_specifiers); } void _______________________________________________ XEmacs-Patches mailing list XEmacs-Patches(a)xemacs.org http://lists.xemacs.org/mailman/listinfo/xemacs-patches

1 participants
0 comments

[COMMIT] Give docstrings to least-{positive, negative}-normalized-float, float-*epsilon 13 years, 1 month

Aidan Kehoe

APPROVE COMMIT NOTE: This patch has been committed. # HG changeset patch # User Aidan Kehoe <kehoea(a)parhasard.net> # Date 1301416114 -3600 # Node ID 436e67ca8c790dd9214e1a5eb72d4ab9a050df4b # Parent 3889ef1284884c2ddf74627d4bad2764dc18529e Give docstrings to least-{positive,negative}-normalized-float, float-*epsilon 2011-03-29 Aidan Kehoe <kehoea(a)parhasard.net> * cl.el: * cl.el (least-positive-float): * cl.el (least-positive-normalized-float): * cl.el (least-negative-normalized-float): * cl.el (float-epsilon): * cl.el (float-negative-epsilon): Document some previously-undocumented float constants here. * cl.el (oddp): * cl.el (evenp): Change numeric comparison to use #'eql instead of #'eq in passing. diff -r 3889ef128488 -r 436e67ca8c79 lisp/ChangeLog --- a/lisp/ChangeLog Thu Mar 24 11:00:11 2011 -0600 +++ b/lisp/ChangeLog Tue Mar 29 17:28:34 2011 +0100 ＠＠ -1,3 +1,17 ＠＠ +2011-03-29 Aidan Kehoe <kehoea(a)parhasard.net> + + * cl.el: + * cl.el (least-positive-float): + * cl.el (least-positive-normalized-float): + * cl.el (least-negative-normalized-float): + * cl.el (float-epsilon): + * cl.el (float-negative-epsilon): + Document some previously-undocumented float constants here. + * cl.el (oddp): + * cl.el (evenp): + Change numeric comparison to use #'eql instead of #'eq in + passing. + 2011-03-24 Jerry James <james(a)xemacs.org> * cl-macs.el (loop): "arbitary" -> "arbitrary". diff -r 3889ef128488 -r 436e67ca8c79 lisp/cl.el --- a/lisp/cl.el Thu Mar 24 11:00:11 2011 -0600 +++ b/lisp/cl.el Tue Mar 29 17:28:34 2011 +0100 ＠＠ -312,11 +312,11 ＠＠ (defun oddp (integer) "Return t if INTEGER is odd." - (eq (logand integer 1) 1)) + (eql (logand integer 1) 1)) (defun evenp (integer) "Return t if INTEGER is even." - (eq (logand integer 1) 0)) + (eql (logand integer 1) 0)) ;; XEmacs addition (defalias 'cl-abs 'abs) ＠＠ -329,13 +329,35 ＠＠ (defconst most-negative-float nil "The float closest in value to negative infinity.") (defconst least-positive-float nil - "The positive float closest in value to 0.") + "The positive float closest in value to zero.") (defconst least-negative-float nil - "The negative float closest in value to 0.") -(defconst least-positive-normalized-float nil) -(defconst least-negative-normalized-float nil) -(defconst float-epsilon nil) -(defconst float-negative-epsilon nil) + "The negative float closest in value to zero.") +(defconst least-positive-normalized-float nil + "The normalized positive float closest in value to zero. + +A float is normalized if the most significant bit of its mantissa is 1. +Use of denormalized (equivalently, subnormal) floats in calculations will +lead to gradual underflow, though they can be more accurate in representing +individual small values. Normal and subnormal floats are as described in +IEEE 754.") + +(defconst least-negative-normalized-float nil + "The normalized negative float closest in value to zero. + +See `least-positive-normalized-float' for details of normal and denormalized +numbers.") + +(defconst float-epsilon nil + "The smallest float guaranteed not `eql' to 1.0 when added to 1.0. + +That is, (eql 1.0 (+ 1.0 X)) will always give nil if (<= float-epsilon X) , +but it may give t for smaller values.") + +(defconst float-negative-epsilon nil + "The smallest float guaranteed not `eql' to 1.0 when subtracted from 1.0. + +That is, (eql 1.0 (- 1.0 X)) will always give nil if (<= +float-negative-epsilon X) , but it may give t for smaller values.") ;;; Sequence functions. -- “Apart from the nine-banded armadillo, man is the only natural host of Mycobacterium leprae, although it can be grown in the footpads of mice.” -- Kumar & Clark, Clinical Medicine, summarising improbable leprosy research _______________________________________________ XEmacs-Patches mailing list XEmacs-Patches(a)xemacs.org http://lists.xemacs.org/mailman/listinfo/xemacs-patches

1 participants
0 comments

commit: Give docstrings to least-{positive, negative}-normalized-float, float-*epsilon 13 years, 1 month

Aidan Kehoe

changeset: 5385:436e67ca8c79 tag: tip user: Aidan Kehoe <kehoea(a)parhasard.net> date: Tue Mar 29 17:28:34 2011 +0100 files: lisp/ChangeLog lisp/cl.el description: Give docstrings to least-{positive,negative}-normalized-float, float-*epsilon 2011-03-29 Aidan Kehoe <kehoea(a)parhasard.net> * cl.el: * cl.el (least-positive-float): * cl.el (least-positive-normalized-float): * cl.el (least-negative-normalized-float): * cl.el (float-epsilon): * cl.el (float-negative-epsilon): Document some previously-undocumented float constants here. * cl.el (oddp): * cl.el (evenp): Change numeric comparison to use #'eql instead of #'eq in passing. diff -r 3889ef128488 -r 436e67ca8c79 lisp/ChangeLog --- a/lisp/ChangeLog Thu Mar 24 11:00:11 2011 -0600 +++ b/lisp/ChangeLog Tue Mar 29 17:28:34 2011 +0100 ＠＠ -1,3 +1,17 ＠＠ +2011-03-29 Aidan Kehoe <kehoea(a)parhasard.net> + + * cl.el: + * cl.el (least-positive-float): + * cl.el (least-positive-normalized-float): + * cl.el (least-negative-normalized-float): + * cl.el (float-epsilon): + * cl.el (float-negative-epsilon): + Document some previously-undocumented float constants here. + * cl.el (oddp): + * cl.el (evenp): + Change numeric comparison to use #'eql instead of #'eq in + passing. + 2011-03-24 Jerry James <james(a)xemacs.org> * cl-macs.el (loop): "arbitary" -> "arbitrary". diff -r 3889ef128488 -r 436e67ca8c79 lisp/cl.el --- a/lisp/cl.el Thu Mar 24 11:00:11 2011 -0600 +++ b/lisp/cl.el Tue Mar 29 17:28:34 2011 +0100 ＠＠ -312,11 +312,11 ＠＠ (defun oddp (integer) "Return t if INTEGER is odd." - (eq (logand integer 1) 1)) + (eql (logand integer 1) 1)) (defun evenp (integer) "Return t if INTEGER is even." - (eq (logand integer 1) 0)) + (eql (logand integer 1) 0)) ;; XEmacs addition (defalias 'cl-abs 'abs) ＠＠ -329,13 +329,35 ＠＠ (defconst most-negative-float nil "The float closest in value to negative infinity.") (defconst least-positive-float nil - "The positive float closest in value to 0.") + "The positive float closest in value to zero.") (defconst least-negative-float nil - "The negative float closest in value to 0.") -(defconst least-positive-normalized-float nil) -(defconst least-negative-normalized-float nil) -(defconst float-epsilon nil) -(defconst float-negative-epsilon nil) + "The negative float closest in value to zero.") +(defconst least-positive-normalized-float nil + "The normalized positive float closest in value to zero. + +A float is normalized if the most significant bit of its mantissa is 1. +Use of denormalized (equivalently, subnormal) floats in calculations will +lead to gradual underflow, though they can be more accurate in representing +individual small values. Normal and subnormal floats are as described in +IEEE 754.") + +(defconst least-negative-normalized-float nil + "The normalized negative float closest in value to zero. + +See `least-positive-normalized-float' for details of normal and denormalized +numbers.") + +(defconst float-epsilon nil + "The smallest float guaranteed not `eql' to 1.0 when added to 1.0. + +That is, (eql 1.0 (+ 1.0 X)) will always give nil if (<= float-epsilon X) , +but it may give t for smaller values.") + +(defconst float-negative-epsilon nil + "The smallest float guaranteed not `eql' to 1.0 when subtracted from 1.0. + +That is, (eql 1.0 (- 1.0 X)) will always give nil if (<= +float-negative-epsilon X) , but it may give t for smaller values.") ;;; Sequence functions. _______________________________________________ XEmacs-Patches mailing list XEmacs-Patches(a)xemacs.org http://lists.xemacs.org/mailman/listinfo/xemacs-patches

1 participants
0 comments

[PATCH 21.5] Spelling corrections 13 years, 1 month

Jerry James

PATCH 21.5 Recently, a number of patches have been sent to the Linux Kernel Mailing List that korrect mispelt wurds. The patches were created by the author of codespell: http://git.profusion.mobi/cgit.cgi/lucas/codespell/ I tried running codespell over the XEmacs repository to see what it turned up. Here is the result. I corrected some grammar while I was at it. Some of these "corrections" may be due to me having an American English dictionary, instead of a British English dictionary. Feel free to point out corrections that shouldn't be made. (This doesn't mean that no misspellings remain, just that we fixed some common ones.) I'm attaching the patch, because I don't trust gmail to not mangle the whitespace if I copy and paste it. -- Jerry James http://www.jamezone.org/ _______________________________________________ XEmacs-Patches mailing list XEmacs-Patches(a)xemacs.org http://lists.xemacs.org/mailman/listinfo/xemacs-patches

2 participants
2 comments

[PATCH 21.5] listu and listn 13 years, 1 month

Jerry James

PATCH 21.5 We've had a listn() function for a year now, and nothing is using it. That function and listu() could also be made slightly more efficient by having them construct a list in forward order, rather than constructing it backwards and then reversing the result. This patch does that, and converts a few Flist callers over to listu() or listn(). diff -r 3889ef128488 src/ChangeLog --- a/src/ChangeLog Thu Mar 24 11:00:11 2011 -0600 +++ b/src/ChangeLog Thu Mar 24 15:01:13 2011 -0600 ＠＠ -1,3 +1,13 ＠＠ +2011-03-24 Jerry James <james(a)xemacs.org> + + * alloc.c (listu): Assemble the list in the right order so we don't + have to reverse it. + (listn): Ditto. + * dired.c (Ffile_attributes): Use listn instead of building an array + to pass to Flist. GC protect the mode string. + * editfns.c (Fdecode_time): Use listn instead of Flist. + * faces.c (vars_of_faces): Use listu instead of Flist. + 2011-03-24 Jerry James <james(a)xemacs.org> * README.kkcc: "occured" -> "occurred". diff -r 3889ef128488 src/alloc.c --- a/src/alloc.c Thu Mar 24 11:00:11 2011 -0600 +++ b/src/alloc.c Thu Mar 24 15:01:13 2011 -0600 ＠＠ -1465,18 +1465,23 ＠＠ listu (Lisp_Object first, ...) { Lisp_Object obj = Qnil; - Lisp_Object val; - va_list va; - - va_start (va, first); - val = first; - while (!UNBOUNDP (val)) + + if (!UNBOUNDP (first)) { - obj = Fcons (val, obj); + va_list va; + Lisp_Object last, val; + + last = obj = Fcons (first, Qnil); + va_start (va, first); val = va_arg (va, Lisp_Object); + while (!UNBOUNDP (val)) + { + last = XCDR (last) = Fcons (val, Qnil); + val = va_arg (va, Lisp_Object); + } + va_end (va); } - va_end (va); - return Fnreverse (obj); + return obj; } /* Return a list of arbitrary length, with length specified and remaining ＠＠ -1485,15 +1490,21 ＠＠ Lisp_Object listn (int num_args, ...) { - int i; Lisp_Object obj = Qnil; - va_list va; - - va_start (va, num_args); - for (i = 0; i < num_args; i++) - obj = Fcons (va_arg (va, Lisp_Object), obj); - va_end (va); - return Fnreverse (obj); + + if (num_args > 0) + { + va_list va; + Lisp_Object last; + int i; + + va_start (va, num_args); + last = obj = Fcons (va_arg (va, Lisp_Object), Qnil); + for (i = 1; i < num_args; i++) + last = XCDR (last) = Fcons (va_arg (va, Lisp_Object), Qnil); + va_end (va); + } + return obj; } /* Return a list of arbitrary length, with length specified and an array diff -r 3889ef128488 src/dired.c --- a/src/dired.c Thu Mar 24 11:00:11 2011 -0600 +++ b/src/dired.c Thu Mar 24 15:01:13 2011 -0600 ＠＠ -845,14 +845,13 ＠＠ (filename)) { /* This function can GC. GC checked 1997.06.04. */ - Lisp_Object values[12]; Lisp_Object directory = Qnil; struct stat s; char modes[10]; - Lisp_Object handler; - struct gcpro gcpro1, gcpro2; + Lisp_Object handler, mode, modestring = Qnil, size, gid; + struct gcpro gcpro1, gcpro2, gcpro3; - GCPRO2 (filename, directory); + GCPRO3 (filename, directory, modestring); filename = Fexpand_file_name (filename, Qnil); /* If the file name has special constructs in it, ＠＠ -893,49 +892,54 ＠＠ switch (s.st_mode & S_IFMT) { default: - values[0] = Qnil; + mode = Qnil; break; case S_IFDIR: - values[0] = Qt; + mode = Qt; break; #ifdef S_IFLNK case S_IFLNK: - values[0] = Ffile_symlink_p (filename); + mode = Ffile_symlink_p (filename); break; #endif } - values[1] = make_int (s.st_nlink); - values[2] = make_int (s.st_uid); - values[3] = make_int (s.st_gid); - values[4] = make_time (s.st_atime); - values[5] = make_time (s.st_mtime); - values[6] = make_time (s.st_ctime); #ifndef HAVE_BIGNUM - values[7] = make_integer (NUMBER_FITS_IN_AN_EMACS_INT (s.st_size) ? - (EMACS_INT)s.st_size : -1); + size = make_integer (NUMBER_FITS_IN_AN_EMACS_INT (s.st_size) ? + (EMACS_INT)s.st_size : -1); #else - values[7] = make_integer (s.st_size); -#endif + size = make_integer (s.st_size); +#endif filemodestring (&s, modes); - values[8] = make_string ((Ibyte *) modes, 10); + modestring = make_string ((Ibyte *) modes, 10), + #if defined (BSD4_2) || defined (BSD4_3) /* file gid will be dir gid */ { struct stat sdir; if (!NILP (directory) && qxe_stat (XSTRING_DATA (directory), &sdir) == 0) - values[9] = (sdir.st_gid != s.st_gid) ? Qt : Qnil; + gid = (sdir.st_gid != s.st_gid) ? Qt : Qnil; else /* if we can't tell, assume worst */ - values[9] = Qt; + gid = Qt; } #else /* file gid will be egid */ - values[9] = (s.st_gid != getegid ()) ? Qt : Qnil; + gid = (s.st_gid != getegid ()) ? Qt : Qnil; #endif /* BSD4_2 or BSD4_3 */ - values[10] = make_int (s.st_ino); - values[11] = make_int (s.st_dev); - UNGCPRO; - return Flist (countof (values), values); + + RETURN_UNGCPRO (listn (12, + mode, + make_int (s.st_nlink), + make_int (s.st_uid), + make_int (s.st_gid), + make_time (s.st_atime), + make_time (s.st_mtime), + make_time (s.st_ctime), + size, + modestring, + gid, + make_int (s.st_ino), + make_int (s.st_dev))); } diff -r 3889ef128488 src/editfns.c --- a/src/editfns.c Thu Mar 24 11:00:11 2011 -0600 +++ b/src/editfns.c Thu Mar 24 15:01:13 2011 -0600 ＠＠ -1102,29 +1102,28 ＠＠ time_t time_spec; struct tm save_tm; struct tm *decoded_time; - Lisp_Object list_args[9]; if (! lisp_to_time (specified_time, &time_spec)) invalid_argument ("Invalid time specification", Qunbound); decoded_time = localtime (&time_spec); - list_args[0] = make_int (decoded_time->tm_sec); - list_args[1] = make_int (decoded_time->tm_min); - list_args[2] = make_int (decoded_time->tm_hour); - list_args[3] = make_int (decoded_time->tm_mday); - list_args[4] = make_int (decoded_time->tm_mon + 1); - list_args[5] = make_int (decoded_time->tm_year + 1900); - list_args[6] = make_int (decoded_time->tm_wday); - list_args[7] = (decoded_time->tm_isdst)? Qt : Qnil; /* Make a copy, in case gmtime modifies the struct. */ save_tm = *decoded_time; decoded_time = gmtime (&time_spec); - if (decoded_time == 0) - list_args[8] = Qnil; - else - list_args[8] = make_int (difftm (&save_tm, decoded_time)); - return Flist (9, list_args); + + return listn(9, + make_int (save_tm.tm_sec), + make_int (save_tm.tm_min), + make_int (save_tm.tm_hour), + make_int (save_tm.tm_mday), + make_int (save_tm.tm_mon + 1), + make_int (save_tm.tm_year + 1900), + make_int (save_tm.tm_wday), + save_tm.tm_isdst ? Qt : Qnil, + (decoded_time == NULL) + ? Qnil + : make_int (difftm (&save_tm, decoded_time))); } static void set_time_zone_rule (Extbyte *tzstring); diff -r 3889ef128488 src/faces.c --- a/src/faces.c Thu Mar 24 11:00:11 2011 -0600 +++ b/src/faces.c Thu Mar 24 15:01:13 2011 -0600 ＠＠ -2227,26 +2227,11 ＠＠ debug_x_faces = 0; #endif - { - Lisp_Object syms[20]; - int n = 0; - - syms[n++] = Qforeground; - syms[n++] = Qbackground; - syms[n++] = Qfont; - syms[n++] = Qdisplay_table; - syms[n++] = Qbackground_pixmap; - syms[n++] = Qbackground_placement; - syms[n++] = Qunderline; - syms[n++] = Qstrikethru; - syms[n++] = Qhighlight; - syms[n++] = Qdim; - syms[n++] = Qblinking; - syms[n++] = Qreverse; - - Vbuilt_in_face_specifiers = Flist (n, syms); - staticpro (&Vbuilt_in_face_specifiers); - } + Vbuilt_in_face_specifiers = + listu (Qforeground, Qbackground, Qfont, Qdisplay_table, Qbackground_pixmap, + Qbackground_placement, Qunderline, Qstrikethru, Qhighlight, Qdim, + Qblinking, Qreverse, Qunbound); + staticpro (&Vbuilt_in_face_specifiers); } void -- Jerry James http://www.jamezone.org/ _______________________________________________ XEmacs-Patches mailing list XEmacs-Patches(a)xemacs.org http://lists.xemacs.org/mailman/listinfo/xemacs-patches

2 participants
1 comments

[COMMIT] issue 757 - tty device metric for num-color-cells 13 years, 1 month

Jeff Sparkes

NOTE: This patch has been committed. I added the min-colors specifier to defface, and it highlighted the fact that the tty device hadn't implemented the num-color-cells metric. I also added num-bit-planes since it was easy to derive. * console-tty-impl.h (struct tty_console): Add field for number of displayable colors. * device-tty.c (tty_device_system_metrics): Return metrics for num-color-cells and num-bit-planes. * device.c: There are two required args for device-system-metric. * redisplay-tty.c (init_tty_for_redisplay): Retrieve number of colors from terminal description. Default to 2 if none found. xemacs-local source patch: Diff command: hg diff --git Files affected: src/redisplay-tty.c src/device.c src/device-tty.c src/console-tty-impl.h diff --git a/src/console-tty-impl.h b/src/console-tty-impl.h --- a/src/console-tty-impl.h +++ b/src/console-tty-impl.h ＠＠ -63,6 +63,8 ＠＠ int height; int width; + int colors; + /* The count of frame number. */ int frame_count; diff --git a/src/device-tty.c b/src/device-tty.c --- a/src/device-tty.c +++ b/src/device-tty.c ＠＠ -196,6 +196,10 ＠＠ case DM_size_device: return Fcons (make_int (CONSOLE_TTY_DATA (con)->width), make_int (CONSOLE_TTY_DATA (con)->height)); + case DM_num_bit_planes: + return make_int (log2 (CONSOLE_TTY_DATA (con)->colors)); + case DM_num_color_cells: + return make_int (CONSOLE_TTY_DATA (con)->colors); default: /* No such device metric property for TTY devices */ return Qunbound; } diff --git a/src/device.c b/src/device.c --- a/src/device.c +++ b/src/device.c ＠＠ -1057,8 +1057,8 ＠＠ return DEVICE_PRINTER_P (decode_device (device)) ? Qt : Qnil; } -DEFUN ("device-system-metric", Fdevice_system_metric, 1, 3, 0, /* -Get a metric for DEVICE as provided by the system. +DEFUN ("device-system-metric", Fdevice_system_metric, 2, 3, 0, /* +Get DEVICE METRIC as provided by the system. METRIC must be a symbol specifying requested metric. Note that the metrics returned are these provided by the system internally, not read from resources, diff --git a/src/redisplay-tty.c b/src/redisplay-tty.c --- a/src/redisplay-tty.c +++ b/src/redisplay-tty.c ＠＠ -1116,6 +1116,13 ＠＠ if (CONSOLE_TTY_DATA (c)->width <= 0 || CONSOLE_TTY_DATA (c)->height <= 0) return TTY_SIZE_UNSPECIFIED; + CONSOLE_TTY_DATA (c)->colors = tgetnum("Co"); + if (CONSOLE_TTY_DATA (c)->colors == 0) + CONSOLE_TTY_DATA (c)->colors = tgetnum("colors"); + if (CONSOLE_TTY_DATA (c)->colors == 0) + /* There is always foreground and background. */ + CONSOLE_TTY_DATA (c)->colors = 2; + /* * Initialize cursor motion information. */ -- Jeff Sparkes jsparkes(a)gmail.com _______________________________________________ XEmacs-Patches mailing list XEmacs-Patches(a)xemacs.org http://lists.xemacs.org/mailman/listinfo/xemacs-patches

1 participants
0 comments

[PATCH] Remove use of keyword auto, it will be illegal in c++0x 13 years, 1 month

The XEmacs Package Smoketest

Hi, (Trying patcher for the first time ... ;-) This patch hasn't been commited. It is about the use of the auto keyword. It is, from what I know, not needed since auto is the default. In C++0x auto will get a new meaning and the current usage will be illegal. (Could it be so evil that there are compilers out there that would not place an automatic variable in a register if the auto keyword is used?) 2011-03-20 Mats Lidell <matsl(a)xemacs.org> * alloca.c (find_stack_direction): * alloca.c (xemacs_c_alloca): Remove use of auto keyword. It is default and will be illegal in C++0X. ChangeLog patch: Diff command: hg extdiff -o -U0 Files affected: src/ChangeLog --- patched-auto-c++.6c3a695f54f5/src/ChangeLog 2011-03-20 23:46:29.079105581 +0100 +++ /src/xemacs/work/patched-auto-c++/src/ChangeLog 2011-03-20 23:46:22.514215501 +0100 ＠＠ -0,0 +1,7 ＠＠ +2011-03-20 Mats Lidell <matsl(a)xemacs.org> + + * alloca.c (find_stack_direction): + * alloca.c (xemacs_c_alloca): + Remove use of auto keyword. It is default and will be illegal in + C++0X. + Source patch: Diff command: hg diff --git Files affected: src/alloca.c diff --git a/src/alloca.c b/src/alloca.c --- a/src/alloca.c +++ b/src/alloca.c ＠＠ -78,7 +78,7 ＠＠ find_stack_direction (void) { static char *addr = NULL; /* Address of first `dummy', once known. */ - auto char dummy; /* To get stack address. */ + char dummy; /* To get stack address. */ if (addr == NULL) { /* Initial entry. */ ＠＠ -131,7 +131,7 ＠＠ pointer xemacs_c_alloca (unsigned int size) { - auto char probe; /* Probes stack depth: */ + char probe; /* Probes stack depth: */ register char *depth = ADDRESS_FUNCTION (probe); #if STACK_DIRECTION == 0 Yours -- %% Mats _______________________________________________ XEmacs-Patches mailing list XEmacs-Patches(a)xemacs.org http://lists.xemacs.org/mailman/listinfo/xemacs-patches

3 participants
3 comments

[PATCH] issue 757, return system metrics num-color-cells for tty 13 years, 1 month

Jeff Sparkes

I'm wondering about the use of log2 in the patch. 1. Is it always available? Configure doesn't check for it. 2. I don't do any casting to int. This works for gcc; is it okay for other compilers? -- Jeff Sparkes jsparkes(a)gmail.com _______________________________________________ XEmacs-Patches mailing list XEmacs-Patches(a)xemacs.org http://lists.xemacs.org/mailman/listinfo/xemacs-patches

3 participants
3 comments

[COMMIT] #'custom-add-to-group: warn if GROUP is nil. 13 years, 1 month

Aidan Kehoe

APPROVE COMMIT NOTE: This patch has been committed. # HG changeset patch # User Aidan Kehoe <kehoea(a)parhasard.net> # Date 1300947745 0 # Node ID 294ab9180fad2da8aef81412c91f1a81517d64db # Parent d363790fd936879ef0414abd81afd7ea7f25f3ee #'custom-add-to-group: warn if GROUP is nil. 2011-03-24 Aidan Kehoe <kehoea(a)parhasard.net> * custom.el (custom-add-to-group): Warn if adding an option to the nil group; this is usually an error on the part of the programmer. * cmdloop.el (suggest-key-bindings): Specify a group for this variable, it didn't previously have one. diff -r d363790fd936 -r 294ab9180fad lisp/ChangeLog --- a/lisp/ChangeLog Wed Mar 23 00:08:35 2011 +0100 +++ b/lisp/ChangeLog Thu Mar 24 06:22:25 2011 +0000 ＠＠ -1,3 +1,11 ＠＠ +2011-03-24 Aidan Kehoe <kehoea(a)parhasard.net> + + * custom.el (custom-add-to-group): + Warn if adding an option to the nil group; this is usually an + error on the part of the programmer. + * cmdloop.el (suggest-key-bindings): + Specify a group for this variable, it didn't previously have one. + 2011-03-21 Aidan Kehoe <kehoea(a)parhasard.net> * cl-macs.el (revappend, nreconc): diff -r d363790fd936 -r 294ab9180fad lisp/cmdloop.el --- a/lisp/cmdloop.el Wed Mar 23 00:08:35 2011 +0100 +++ b/lisp/cmdloop.el Thu Mar 24 06:22:25 2011 +0000 ＠＠ -313,7 +313,8 ＠＠ :type '(choice (const :tag "off" nil) (integer :tag "time" 2) - (other :tag "on"))) + (other :tag "on")) +:group 'keyboard) (dontusethis-set-symbol-value-handler 'suggest-key-bindings diff -r d363790fd936 -r 294ab9180fad lisp/custom.el --- a/lisp/custom.el Wed Mar 23 00:08:35 2011 +0100 +++ b/lisp/custom.el Thu Mar 24 06:22:25 2011 +0000 ＠＠ -409,6 +409,9 ＠＠ (defun custom-add-to-group (group option widget) "To existing GROUP add a new OPTION of type WIDGET. If there already is an entry for OPTION and WIDGET, nothing is done." + (or group (display-warning 'custom + (format "custom: widget %s, option %s has no associated group" + widget option))) (let ((members (get group 'custom-group)) (entry (list option widget))) (unless (member entry members) -- “Apart from the nine-banded armadillo, man is the only natural host of Mycobacterium leprae, although it can be grown in the footpads of mice.” -- Kumar & Clark, Clinical Medicine, summarising improbable leprosy research _______________________________________________ XEmacs-Patches mailing list XEmacs-Patches(a)xemacs.org http://lists.xemacs.org/mailman/listinfo/xemacs-patches

1 participants
0 comments

commit: #'custom-add-to-group: warn if GROUP is nil. 13 years, 1 month

Aidan Kehoe

changeset: 5383:294ab9180fad tag: tip user: Aidan Kehoe <kehoea(a)parhasard.net> date: Thu Mar 24 06:22:25 2011 +0000 files: lisp/ChangeLog lisp/cmdloop.el lisp/custom.el description: #'custom-add-to-group: warn if GROUP is nil. 2011-03-24 Aidan Kehoe <kehoea(a)parhasard.net> * custom.el (custom-add-to-group): Warn if adding an option to the nil group; this is usually an error on the part of the programmer. * cmdloop.el (suggest-key-bindings): Specify a group for this variable, it didn't previously have one. diff -r d363790fd936 -r 294ab9180fad lisp/ChangeLog --- a/lisp/ChangeLog Wed Mar 23 00:08:35 2011 +0100 +++ b/lisp/ChangeLog Thu Mar 24 06:22:25 2011 +0000 ＠＠ -1,3 +1,11 ＠＠ +2011-03-24 Aidan Kehoe <kehoea(a)parhasard.net> + + * custom.el (custom-add-to-group): + Warn if adding an option to the nil group; this is usually an + error on the part of the programmer. + * cmdloop.el (suggest-key-bindings): + Specify a group for this variable, it didn't previously have one. + 2011-03-21 Aidan Kehoe <kehoea(a)parhasard.net> * cl-macs.el (revappend, nreconc): diff -r d363790fd936 -r 294ab9180fad lisp/cmdloop.el --- a/lisp/cmdloop.el Wed Mar 23 00:08:35 2011 +0100 +++ b/lisp/cmdloop.el Thu Mar 24 06:22:25 2011 +0000 ＠＠ -313,7 +313,8 ＠＠ :type '(choice (const :tag "off" nil) (integer :tag "time" 2) - (other :tag "on"))) + (other :tag "on")) +:group 'keyboard) (dontusethis-set-symbol-value-handler 'suggest-key-bindings diff -r d363790fd936 -r 294ab9180fad lisp/custom.el --- a/lisp/custom.el Wed Mar 23 00:08:35 2011 +0100 +++ b/lisp/custom.el Thu Mar 24 06:22:25 2011 +0000 ＠＠ -409,6 +409,9 ＠＠ (defun custom-add-to-group (group option widget) "To existing GROUP add a new OPTION of type WIDGET. If there already is an entry for OPTION and WIDGET, nothing is done." + (or group (display-warning 'custom + (format "custom: widget %s, option %s has no associated group" + widget option))) (let ((members (get group 'custom-group)) (entry (list option widget))) (unless (member entry members) _______________________________________________ XEmacs-Patches mailing list XEmacs-Patches(a)xemacs.org http://lists.xemacs.org/mailman/listinfo/xemacs-patches

1 participants
0 comments

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

XEmacs-Patches March 2011