July 2008 - XEmacs-Patches - XEmacs Mailing List Archives

Re: [PATCH] Don't load window-system-specific features at compile, hyperbole 15 years, 9 months

Aidan Kehoe

Ar an séú lá déag de mí Iúil, scríobh Vin Shelton: > On Wed, Jul 16, 2008 at 1:51 PM, Aidan Kehoe <kehoea(a)parhasard.net> wrote: > > [...] Immediately following is the change I was considering making in > > my last detailed mail: > > > > diff -r ec442dc06fe1 src/redisplay.c > > --- a/src/redisplay.c Thu Jul 10 23:37:52 2008 +0200 > > +++ b/src/redisplay.c Wed Jul 16 19:50:57 2008 +0200 > > ＠＠ -9753,7 +9753,6 ＠＠ > > > > if (noninteractive) > > { > > - Vwindow_system = Qstream; > > Vinitial_device_type = Qstream; > > return; > > } > > Yes, that patch fixed the problem. > > Do you intend to commit it? Committed, http://hg.debian.org/hg/xemacs/xemacs?cs=4cb7c59b5201 -- ¿Dónde estará ahora mi sobrino Yoghurtu Nghé, que tuvo que huir precipitadamente de la aldea por culpa de la escasez de rinocerontes? _______________________________________________ XEmacs-Patches mailing list XEmacs-Patches(a)xemacs.org http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches

1 participants
0 comments

Re: [PATCH] Abstract out a display-table-specific API, x-symbol 15 years, 9 months

Aidan Kehoe

Ar an ceathrú lá déag de mí Iúil, scríobh Uwe Brauer: > [...] I didn't know that I am listed as the maintainer of x-symbol. > Frankly x-symbol is far to complex for my lisp knowledges, although I > rely very much on this package. I also don't remember that patch > > Please go ahead and apply it, Thanks! > if you want me to test it before tell me, but since a while I switched to > Xemacs mule, though not 21.5 Well, testing is always welcome, but it’s not a patch I’m particularly worried about, the changes are pretty mechanical, there’s nothing subtle to go wrong. > What is this patch supposed to do? It supports character tables, as well a vectors, as display table objects. This will allow us to display incorrect UTF-8 and ISO-8859-1 sequences as Windows-1252 (in another face, to make it clear that the encoding is corrupt, of course), something I hope to commit to 21.5 soon. > Has it something to do with my complains about destroyed codings? No, sorry, you still need to move to 21.5 to avoid that. -- ¿Dónde estará ahora mi sobrino Yoghurtu Nghé, que tuvo que huir precipitadamente de la aldea por culpa de la escasez de rinocerontes? _______________________________________________ XEmacs-Patches mailing list XEmacs-Patches(a)xemacs.org http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches

1 participants
0 comments

commit: Revert to the documented behaviour with window-system and noninteractive runs. 15 years, 9 months

Aidan Kehoe

changeset: 4479:4cb7c59b5201ae584dfe081c131e5f20de3eab7e tag: tip user: Aidan Kehoe <kehoea(a)parhasard.net> date: Thu Jul 17 22:50:22 2008 +0200 files: src/ChangeLog src/redisplay.c description: Revert to the documented behaviour with window-system and noninteractive runs. 2008-07-17 Aidan Kehoe <kehoea(a)parhasard.net> * redisplay.c (init_redisplay): Don't set window-system to 'stream if running noninteractively, revert to the documented behaviour. diff -r ec442dc06fe1bc671fbe0ed0a928b294cdd45aba -r 4cb7c59b5201ae584dfe081c131e5f20de3eab7e src/ChangeLog --- a/src/ChangeLog Thu Jul 10 23:37:52 2008 +0200 +++ b/src/ChangeLog Thu Jul 17 22:50:22 2008 +0200 ＠＠ -1,3 +1,9 ＠＠ 2008-07-07 Aidan Kehoe <kehoea＠parhasa +2008-07-17 Aidan Kehoe <kehoea(a)parhasard.net> + + * redisplay.c (init_redisplay): + Don't set window-system to 'stream if running noninteractively, + revert to the documented behaviour. + 2008-07-07 Aidan Kehoe <kehoea(a)parhasard.net> Patch to make it up to the device-specific code whether diff -r ec442dc06fe1bc671fbe0ed0a928b294cdd45aba -r 4cb7c59b5201ae584dfe081c131e5f20de3eab7e src/redisplay.c --- a/src/redisplay.c Thu Jul 10 23:37:52 2008 +0200 +++ b/src/redisplay.c Thu Jul 17 22:50:22 2008 +0200 ＠＠ -9753,7 +9753,6 ＠＠ init_redisplay (void) if (noninteractive) { - Vwindow_system = Qstream; Vinitial_device_type = Qstream; return; } _______________________________________________ XEmacs-Patches mailing list XEmacs-Patches(a)xemacs.org http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches

1 participants
0 comments

Re: [PATCH] Don't load window-system-specific features at compile, hyperbole 15 years, 9 months

Aidan Kehoe

Ar an séú lá déag de mí Iúil, scríobh Vin Shelton: > On Wed, Jul 16, 2008 at 1:51 PM, Aidan Kehoe <kehoea(a)parhasard.net> wrote: > > [...] Immediately following is the change I was considering making in > > my last detailed mail: > > > > diff -r ec442dc06fe1 src/redisplay.c > > --- a/src/redisplay.c Thu Jul 10 23:37:52 2008 +0200 > > +++ b/src/redisplay.c Wed Jul 16 19:50:57 2008 +0200 > > ＠＠ -9753,7 +9753,6 ＠＠ > > > > if (noninteractive) > > { > > - Vwindow_system = Qstream; > > Vinitial_device_type = Qstream; > > return; > > } > > Yes, that patch fixed the problem. > > Do you intend to commit it? Yes; despite that I can’t reproduce your problem it restores previously documented correct behaviour. Thanks for checking this, and for your testing in general. -- ¿Dónde estará ahora mi sobrino Yoghurtu Nghé, que tuvo que huir precipitadamente de la aldea por culpa de la escasez de rinocerontes? _______________________________________________ XEmacs-Patches mailing list XEmacs-Patches(a)xemacs.org http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches

1 participants
0 comments

Re: [PATCH] Don't load window-system-specific features at compile, hyperbole 15 years, 9 months

The XEmacs Package Smoketest

>>>>> Vin wrote: Vin> Neither of the proposed patches makes a difference. Since Vin> Aidan's changes to 21.5 of 2008-07-10, I cannot use a current Vin> 21.5 to build the packages. Below you can see the error trace. Vin> I can successfully build the packages using a 2008-07-06 Vin> XEmacs-21.5. I doubled checked my environment just to find that I used the wrong version of XEmacs, sorry! Locale.rules pointed in the wrong direction. Corrected the error and tried again in the hope of seeing the same error just to find that it built fine anyway! Sigh. This is the version of xemacs I use: "XEmacs 21.5 (beta28) "fuki" ec442dc06fe1+ [Lucid] (i686-pc-linux, Mule) of Sun Jul 13 2008" Do you start from a clean state? eg make distclean; make autoloads; cd xemacs-packages/hyperbole; make Yours -- %% Mats _______________________________________________ XEmacs-Patches mailing list XEmacs-Patches(a)xemacs.org http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches

3 participants
2 comments

Re: [PATCH] Don't load window-system-specific features at compile, hyperbole 15 years, 9 months

The XEmacs Package Smoketest

>>>>> Vin wrote: Vin> I don't do 'make distclean' because I check out the packages from Vin> CVS every time. OK. So it is not that then. I see now that you are performing a no mule build. I'll build one and see if I can recreate the problem that way. Yours -- %% Mats _______________________________________________ XEmacs-Patches mailing list XEmacs-Patches(a)xemacs.org http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches

1 participants
1 comments

[PATCH] Abstract out a display-table-specific API, x-symbol 15 years, 9 months

Aidan Kehoe

Uwe, this is the patch of http://mid.gmane.org/18288.3344.67997.394271＠parhasard.net of December last year, which you didn’t apply, slightly modified with a better #'put-display-table implementation. I now have the access to apply it myself, please reply if you disagree or if you would like to be no longer listed as the maintainer of the XEmacs x-symbol package. xemacs-packages/x-symbol/ChangeLog addition: 2008-07-13 Aidan Kehoe <kehoea(a)parhasard.net> * lisp/x-symbol-nomule.el: * lisp/x-symbol-nomule.el (put-display-table): New. * lisp/x-symbol-nomule.el (get-display-table): New. * lisp/x-symbol.el (put-display-table): New. Provide with #'defun-when-void, so as not to override the 21.5 implementation. * lisp/x-symbol-nomule.el (x-symbol-nomule-display-table): * lisp/x-symbol.el (x-symbol-invisible-display-table): Use #'put-display-table, #'get-display-table instead #'aset, #'aref. XEmacs Packages source patch: Diff command: cvs -q diff -Nu Files affected: xemacs-packages/x-symbol/lisp/x-symbol.el =================================================================== RCS xemacs-packages/x-symbol/lisp/x-symbol-nomule.el =================================================================== RCS Index: xemacs-packages/x-symbol/lisp/x-symbol-nomule.el =================================================================== RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/x-symbol/lisp/x-symbol-nomule.el,v retrieving revision 1.3 diff -u -u -r1.3 x-symbol-nomule.el --- xemacs-packages/x-symbol/lisp/x-symbol-nomule.el 2003/04/02 03:18:32 1.3 +++ xemacs-packages/x-symbol/lisp/x-symbol-nomule.el 2008/07/13 14:22:11 ＠＠ -55,6 +55,18 ＠＠ (defalias 'x-symbol-encode-charsym-after 'x-symbol-nomule-encode-charsym-after) (defalias 'x-symbol-init-quail-bindings 'ignore) +(defun-when-void put-display-table (range value display-table) + "Set the value for char RANGE to VALUE in DISPLAY-TABLE. " + (if (sequencep display-table) + (aset display-table range value) + (put-char-table range value display-table))) + +(defun-when-void get-display-table (character display-table) + "Find value for CHARACTER in DISPLAY-TABLE. " + (if (sequencep display-table) + (aref display-table character) + (get-char-table character display-table))) + (defvar x-symbol-nomule-mouse-yank-function mouse-yank-function "Function that is called upon by `x-symbol-nomule-mouse-yank-function'.") ＠＠ -80,11 +92,10 ＠＠ "Internal. Face to fontify current font-lock match.") (defvar x-symbol-nomule-display-table - ;; display-table via characters table is not implemented in XEmacs yet... - (let ((table (make-vector 256 nil)) + (let ((table (make-display-table)) (i 128)) (while (< i 160) - (aset table i "") + (put-display-table i "" table) (incf i)) table) "Display table in faces with non-standard charset registry. Index: xemacs-packages/x-symbol/lisp/x-symbol.el =================================================================== RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/x-symbol/lisp/x-symbol.el,v retrieving revision 1.5 diff -u -u -r1.5 x-symbol.el --- xemacs-packages/x-symbol/lisp/x-symbol.el 2003/05/31 14:17:15 1.5 +++ xemacs-packages/x-symbol/lisp/x-symbol.el 2008/07/13 14:22:12 ＠＠ -51,8 +51,12 ＠＠ (defvar x-symbol-trace-invisible nil) ;; shows that invisible is reset but Emacs still shows it as invisible +(defun-when-void put-display-table (range value display-table) + "Set the value for char RANGE to VALUE in DISPLAY-TABLE. " + (if (sequencep display-table) + (aset display-table range value) + (put-char-table range value display-table))) - ;;;;########################################################################## ;;;; General code, default values for `x-symbol-*-function' ＠＠ -1606,7 +1610,7 ＠＠ (let ((table (make-display-table)) (i 0)) (while (< i 256) - (aset table i "") + (put-display-table i "" table) (setq i (1+ i))) table) "Internal variable. Display table for `x-symbol-invisible-face'.") -- ¿Dónde estará ahora mi sobrino Yoghurtu Nghé, que tuvo que huir precipitadamente de la aldea por culpa de la escasez de rinocerontes? _______________________________________________ XEmacs-Patches mailing list XEmacs-Patches(a)xemacs.org http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches

1 participants
1 comments

[COMMIT] Abstract out a display-table-specific API, gamegrid 15 years, 9 months

Aidan Kehoe

NOTE: This patch has been committed. Glynn, this is the patch of http://mid.gmane.org/18288.3344.67997.394271＠parhasard.net of December last year, which you didn’t apply, slightly modified with a better #'put-display-table implementation. I now have the access to apply it myself, please reply if you disagree or if you would like to be no longer listed as the maintaner of the XEmacs games package. xemacs-packages/games/ChangeLog addition: 2008-07-13 Aidan Kehoe <kehoea(a)parhasard.net> * gamegrid.el: * gamegrid.el (put-display-table): New. * gamegrid.el (get-display-table): New. Provide with #'defun-when-void, so as to not override the 21.5 implementation. * gamegrid.el (gamegrid-setup-default-font): * gamegrid.el (gamegrid-initialize-display): Use #'put-display-table, #'get-display-table instead of #'aset, #'aref. XEmacs Packages source patch: Diff command: cvs -q diff -Nu Files affected: xemacs-packages/games/gamegrid.el =================================================================== RCS Index: xemacs-packages/games/gamegrid.el =================================================================== RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/games/gamegrid.el,v retrieving revision 1.6 diff -u -u -r1.6 gamegrid.el --- xemacs-packages/games/gamegrid.el 2005/11/12 00:29:49 1.6 +++ xemacs-packages/games/gamegrid.el 2008/07/13 14:04:58 ＠＠ -38,6 +38,18 ＠＠ (eval-when-compile (require 'cl)) +(defun-when-void put-display-table (range value display-table) + "Set the value for char RANGE to VALUE in DISPLAY-TABLE. " + (if (sequencep display-table) + (aset display-table range value) + (put-char-table range value display-table))) + +(defun-when-void get-display-table (character display-table) + "Find value for CHARACTER in DISPLAY-TABLE. " + (if (sequencep display-table) + (aref display-table character) + (get-char-table character display-table))) + ;; ;;;;;;;;;;;;; buffer-local variables ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; (defvar gamegrid-use-glyphs t ＠＠ -302,7 +314,7 ＠＠ (name (font-name font-spec)) (max-height nil)) (loop for c from 0 to 255 do - (let ((glyph (aref gamegrid-display-table c))) + (let ((glyph (get-display-table c gamegrid-display-table))) (cond ((glyphp glyph) (let ((height (glyph-height glyph))) (if (or (null max-height) ＠＠ -327,7 +339,7 ＠＠ (glyph (gamegrid-make-glyph (car spec) (caddr spec))) (face (gamegrid-make-face (cadr spec) (caddr spec)))) (aset gamegrid-face-table c face) - (aset gamegrid-display-table c glyph))) + (put-display-table c glyph gamegrid-display-table))) (gamegrid-setup-default-font) (gamegrid-set-display-table) (gamegrid-hide-cursor)) -- ¿Dónde estará ahora mi sobrino Yoghurtu Nghé, que tuvo que huir precipitadamente de la aldea por culpa de la escasez de rinocerontes? _______________________________________________ XEmacs-Patches mailing list XEmacs-Patches(a)xemacs.org http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches

1 participants
0 comments

[COMMIT] Abstract out a display-table-specific API, calendar 15 years, 9 months

Aidan Kehoe

NOTE: This patch has been committed. Jeff, this is the patch of http://mid.gmane.org/18288.3344.67997.394271＠parhasard.net of December last year, which you didn’t apply. I now have the access to do so myself, please reply if you disagree or if you would like to be no longer listed as the maintaner of the XEmacs calendar package. xemacs-packages/calendar/ChangeLog addition: 2007-12-24 Aidan Kehoe <kehoea(a)parhasard.net> * cal-french.el (french-calendar-accents): Diacritical marks are always available under XEmacs. XEmacs Packages source patch: Diff command: cvs -q diff -Nu Files affected: xemacs-packages/calendar/cal-french.el =================================================================== RCS Index: xemacs-packages/calendar/cal-french.el =================================================================== RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/calendar/cal-french.el,v retrieving revision 1.6 diff -u -u -r1.6 cal-french.el --- xemacs-packages/calendar/cal-french.el 2007/04/16 02:12:25 1.6 +++ xemacs-packages/calendar/cal-french.el 2008/07/13 14:00:57 ＠＠ -54,9 +54,9 ＠＠ "True if diacritical marks are available." (and (or window-system (terminal-coding-system)) - (not (featurep 'xemacs) - (or enable-multibyte-characters - (and (char-table-p standard-display-table) + (or (featurep 'xemacs) + (and enable-multibyte-characters + (and (char-table-p standard-display-table) (equal (aref standard-display-table 161) [161]))))) t) -- ¿Dónde estará ahora mi sobrino Yoghurtu Nghé, que tuvo que huir precipitadamente de la aldea por culpa de la escasez de rinocerontes? _______________________________________________ XEmacs-Patches mailing list XEmacs-Patches(a)xemacs.org http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches

1 participants
0 comments

Re: [PATCH] Don't load window-system-specific features at compile, hyperbole 15 years, 9 months

Aidan Kehoe

Hi Mats, Ar an triú lá déag de mí Iúil, scríobh Mats Lidell: > Hi Aidan > > You wrote: > > Aidan> This is a good and sane change provoked by the packages build > Aidan> failure of > Aidan> http://mid.gmane.org/20a807210807101850l173cefa6vcd4b9650733b34b5＠mail.gm... > Aidan> I suspect that it will fix the packages build, but I don’t know > Aidan> for sure, because I have to fight with the infrastructure of > Aidan> the autoload-operators.el and the new VM build structure to get > Aidan> the packages to the point of building at all, and I would > Aidan> prefer to do that tomorrow. Either way, it should be a useful > Aidan> thing to apply--there is no need to prevent an XEmacs without > Aidan> X11 support from building Hyperbole. > > I don't understand why the patch is needed? What has changed now that > makes it necessary? Hyperbole workes under many different window > systems, not all actively supported now, but that has never stopped it > from beeing byte compiled under one of them!? > > I also fail to recreate the same error situation. With the latest > version of xemacs and the packages I get other problems. Problems that > are fixed by this patch: (The problems beeing failure to load term and > jka-comp so I needed to introduce dependency on eterm and os-utils.) > > --- working directory: "/src/xemacs/packages/xemacs-packages/hyperbole/" > % cvs diff > cvs server: Diffing . > Index: Makefile > =================================================================== > RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/hyperbole/Makefile,v > retrieving revision 1.13 > diff -r1.13 Makefile > 28c28 > < sh-script net-utils ecrypto > --- > > sh-script net-utils ecrypto eterm os-utils > cvs server: Diffing kotl > cvs server: Diffing man > > Hyperbole is a package that would benefit from beeing lazy in what > packages it requires for byte compiling so I'm not against the idea. I > just can't understand what is going on here. And you seem to be in > hurry hence this quick answer before analysing the problem > furher. Maybe you can even speed the process by enlightening me. Weirdly enough, I’m in your position too, the packages build fine for me, not choking on this problem. (Or indeed on the issues that your change addresses.) But I do see the logic of why Vin’s build is failing--at compile time, Hyperbole calls #'sm-window-sys-term to work out what window system support is available. This is incorrect, as far as I’m concerned, because the window system support available at compile time is orthogonal to that available at run time. My change set the window-system variable to 'stream, on noninteractive runs. This is a mistake, on further consideration, because the window-system variable is there for GNU compatibility, and under GNU the value of it is either nil for TTY or noninteractive use, or some platform-specfic symbol value; 'mac on carbon, for example. I don’t know what they do since they integrated multi-tty support. Anyway, since this is a compatibility variable, and since we have our own sane API, it doesn’t make sense to change its behaviour to conflict with GNU. So, the problem is that these two incorrect approaches now intersect in a way that breaks the compile. If #'sm-window-sys-term finds a non-nil value for window-system, it assumes mouse support, and tries to load mouse-specific functions at compile time. I’ve prepared a change to the trunk that doesn’t set window-system to 'stream on noninteractive runs. However, on investigating further, it should have been set to nil by the code in console.c:select_console_1 anyway. Vin, could you do a M-x report-emacs-bug from the build that’s failing? I want to be reasonably sure I’m actually addressing the problem before sending on another patch. -- ¿Dónde estará ahora mi sobrino Yoghurtu Nghé, que tuvo que huir precipitadamente de la aldea por culpa de la escasez de rinocerontes?OB _______________________________________________ XEmacs-Patches mailing list XEmacs-Patches(a)xemacs.org http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches

1 participants
0 comments

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

XEmacs-Patches July 2008