[PATCH] Update my bio
15 years, 4 months
Vin Shelton
Since Francisco has been keeping me too busy to do much on the
project, he at least deserves some credit!
lisp/ChangeLog addition:
2008-12-24 Vin Shelton <acs(a)xemacs.org>
* about.el: Add Francisco to my bio!
21.4 source patch:
Diff command: cvs -q diff -u
Files affected: lisp/about.el
Index: lisp/about.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/about.el,v
retrieving revision 1.45.2.13
diff -a -u -u -r1.45.2.13 about.el
--- lisp/about.el 2007/11/23 17:22:11 1.45.2.13
+++ lisp/about.el 2008/12/26 02:09:21
＠＠ -1391,11 +1391,12 ＠＠
where he is a professor of economics at the University of Tsukuba.\n"))
(vin
(widget-insert "\
-I'm a software engineer and manager for Adaptive Optics Associates in
-Cambridge, Massachusetts. I used to play a lot of Ultimate (see\n")
+I'm a software engineer and manager for Adaptive Optics Associates
+in Cambridge, Massachusetts. I used to play a lot of Ultimate (see\n")
(about-url-link 'vin nil "Visit the Ultimate Players Association homepage")
- (widget-insert " for more details), but nowadays I'm a family man,
-so I spend a lot of time with my wife, Becky, and my son, Noah.\n"))
+ (widget-insert " for more details), but I don't have time to
+play much any more. Nowadays I'm a family man, so I spend most of
+my time with my wife, Becky, and our sons, Noah and Francisco.\n"))
(vladimir
(widget-insert "\
Former technical lead for XEmacs at Sun. He is now writing a book on
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
[COMMIT] mmm-mode changes
15 years, 4 months
Marcus Harnisch
Hi all
I checked in the changes to mmm-mode. The relevant change is an
upstream sync to the latest version, 0.4.8. This version seems to have
fixed a keymap issue in buffers with multiple submode regions.
2008-11-15 Marcus Harnisch <marcus.harnisch(a)gmx.net>
* Makefile (MAINTAINER): New maintainer
Marcus Harnisch <marcus.harnisch(a)gmx.net>
* Merged changes from upstream version 0.4.8
* ChangeLog:
* ChangeLog-upstream: Split ChangeLog to track upstream changes
separately.
Regards and Merry Christmas
Marcus
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
[COMMIT] Distinguish vars and functions in #'symbol-file, #'describe-{function, variable}
15 years, 4 months
Aidan Kehoe
APPROVE COMMIT
NOTE; this patch has been committed.
This addresses a bug that became more evidenty with my merge of the GNU code
for integrating C functions and variables into #'symbol-file and the various
help screens. I’ve also just made a change in the packages that takes
advantage of it.
# HG changeset patch
# User Aidan Kehoe <kehoea(a)parhasard.net>
# Date 1229954868 0
# Node ID 69a1eda3da06721407d3085ed7aabd1112b22173
# Parent f32c7f843961dee21a36b15b232b8ee66c009bb4
Distinguish vars and functions in #'symbol-file, #'describe-{function,variable}
lisp/ChangeLog addition:
2008-12-22 Aidan Kehoe <kehoea(a)parhasard.net>
* loadhist.el (symbol-file):
Add support for differentiating between variables and functions to
#'symbol-file.
* help.el (describe-function-1):
(describe-variable):
Call #'symbol-function explicitly with a 'defun or 'defvar
argument, depending on whether we're looking for a variable or a
function.
* cus-face.el (custom-declare-face):
Record information about the face in the load history; code taken
from GNU, pre-GPLv3 revision 1.45.
src/ChangeLog addition:
2008-12-22 Aidan Kehoe <kehoea(a)parhasard.net>
* symbols.c (Fdefine_function):
* eval.c (define_function):
Record explicitly that we're defining a function in the load
history, in both these files.
diff -r f32c7f843961 -r 69a1eda3da06 lisp/ChangeLog
--- a/lisp/ChangeLog Mon Dec 22 12:09:08 2008 +0000
+++ b/lisp/ChangeLog Mon Dec 22 14:07:48 2008 +0000
＠＠ -1,3 +1,17 ＠＠
+2008-12-22 Aidan Kehoe <kehoea(a)parhasard.net>
+
+ * loadhist.el (symbol-file):
+ Add support for differentiating between variables and functions to
+ #'symbol-file.
+ * help.el (describe-function-1):
+ (describe-variable):
+ Call #'symbol-function explicitly with a 'defun or 'defvar
+ argument, depending on whether we're looking for a variable or a
+ function.
+ * cus-face.el (custom-declare-face):
+ Record information about the face in the load history; code taken
+ from GNU, pre-GPLv3 revision 1.45.
+
2008-10-29 Stephen J. Turnbull <stephen(a)xemacs.org>
* bytecomp.el (byte-compile-file): Protect encoding from latin-unity.
diff -r f32c7f843961 -r 69a1eda3da06 lisp/cus-face.el
--- a/lisp/cus-face.el Mon Dec 22 12:09:08 2008 +0000
+++ b/lisp/cus-face.el Mon Dec 22 14:07:48 2008 +0000
＠＠ -50,6 +50,9 ＠＠
frames (cdr frames))
(face-display-set face value frame '(custom)))
(init-face-from-resources face)))
+ ;; Don't record SPEC until we see it causes no errors.
+ (put face 'face-defface-spec spec)
+ (push (cons 'defface face) current-load-list)
(when (and doc (null (face-doc-string face)))
(set-face-doc-string face doc))
(custom-handle-all-keywords face args 'custom-face)
diff -r f32c7f843961 -r 69a1eda3da06 lisp/help.el
--- a/lisp/help.el Mon Dec 22 12:09:08 2008 +0000
+++ b/lisp/help.el Mon Dec 22 14:07:48 2008 +0000
＠＠ -1425,7 +1425,7 ＠＠
nil)))
(princ "\n")
(or file-name
- (setq file-name (symbol-file function)))
+ (setq file-name (symbol-file function 'defun)))
(when file-name
(princ " -- loaded from \"")
(if (not (bufferp standard-output))
＠＠ -1651,7 +1651,7 ＠＠
(princ (built-in-variable-doc variable))
(princ ".\n")
(require 'hyper-apropos)
- (let ((file-name (symbol-file variable))
+ (let ((file-name (symbol-file variable 'defvar))
opoint e)
(when file-name
(princ " -- loaded from \"")
diff -r f32c7f843961 -r 69a1eda3da06 lisp/loadhist.el
--- a/lisp/loadhist.el Mon Dec 22 12:09:08 2008 +0000
+++ b/lisp/loadhist.el Mon Dec 22 14:07:48 2008 +0000
＠＠ -48,11 +48,12 ＠＠
are acceptable.
If TYPE is `defvar', then variable definitions are acceptable.
-#### For the moment the difference is not implemented for non-autoloaded
-Lisp symbols."
+`defface' specifies a face definition only, and for the moment, it won't
+return faces created with `make-face' or `copy-face', just those created
+with `defface' and `custom-declare-face'."
(interactive "SFind source file for symbol: ") ; XEmacs
(block look-up-symbol-file
- (let (built-in-file autoload-cons)
+ (let (built-in-file autoload-cons symbol-details)
(when (and
(eq 'autoload
(car-safe (setq autoload-cons
＠＠ -64,9 +65,25 ＠＠
(memq (fifth autoload-cons) '(nil macro)))))
(return-from look-up-symbol-file
(locate-library (second autoload-cons))))
- (dolist (entry load-history)
- (when (memq sym (cdr entry))
- (return-from look-up-symbol-file (car entry))))
+ (cond ((eq 'defvar type)
+ ;; Load history entries corresponding to variables are just
+ ;; symbols.
+ (dolist (entry load-history)
+ (when (memq sym (cdr entry))
+ (return-from look-up-symbol-file (car entry)))))
+ ((not (null type))
+ ;; Non-variables have the type stored as the car of the entry.
+ (dolist (entry load-history)
+ (when (and (setq symbol-details (rassq sym (cdr entry)))
+ (eq type (car symbol-details)))
+ (return-from look-up-symbol-file (car entry)))))
+ (t
+ ;; If TYPE hasn't been specified, we need to check both for
+ ;; variables and other symbols.
+ (dolist (entry load-history)
+ (when (or (memq sym (cdr entry))
+ (rassq sym (cdr entry)))
+ (return-from look-up-symbol-file (car entry))))))
(setq built-in-file (built-in-symbol-file sym type))
(if built-in-file (concat source-directory "/src/" built-in-file)))))
diff -r f32c7f843961 -r 69a1eda3da06 src/ChangeLog
--- a/src/ChangeLog Mon Dec 22 12:09:08 2008 +0000
+++ b/src/ChangeLog Mon Dec 22 14:07:48 2008 +0000
＠＠ -1,3 +1,10 ＠＠
+2008-12-22 Aidan Kehoe <kehoea(a)parhasard.net>
+
+ * symbols.c (Fdefine_function):
+ * eval.c (define_function):
+ Record explicitly that we're defining a function in the load
+ history, in both these files.
+
2008-12-22 Aidan Kehoe <kehoea(a)parhasard.net>
* faces.c (Fbuilt_in_face_specifiers):
diff -r f32c7f843961 -r 69a1eda3da06 src/eval.c
--- a/src/eval.c Mon Dec 22 12:09:08 2008 +0000
+++ b/src/eval.c Mon Dec 22 14:07:48 2008 +0000
＠＠ -1223,7 +1223,7 ＠＠
define_function (Lisp_Object name, Lisp_Object defn)
{
Ffset (name, defn);
- LOADHIST_ATTACH (name);
+ LOADHIST_ATTACH (Fcons (Qdefun, name));
return name;
}
diff -r f32c7f843961 -r 69a1eda3da06 src/symbols.c
--- a/src/symbols.c Mon Dec 22 12:09:08 2008 +0000
+++ b/src/symbols.c Mon Dec 22 14:07:48 2008 +0000
＠＠ -718,7 +718,7 ＠＠
{
/* This function can GC */
Ffset (symbol, newdef);
- LOADHIST_ATTACH (symbol);
+ LOADHIST_ATTACH (Fcons (Qdefun, symbol));
return newdef;
}
--
¿Dónde estará ahora mi sobrino Yoghurtu Nghé, que tuvo que huir
precipitadamente de la aldea por culpa de la escasez de rinocerontes?
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
commit: Distinguish vars and functions in #'symbol-file, #'describe-{function, variable}
15 years, 4 months
Aidan Kehoe
changeset: 4535:69a1eda3da06721407d3085ed7aabd1112b22173
tag: tip
user: Aidan Kehoe <kehoea(a)parhasard.net>
date: Mon Dec 22 14:07:48 2008 +0000
files: lisp/ChangeLog lisp/cus-face.el lisp/help.el lisp/loadhist.el src/ChangeLog src/eval.c src/symbols.c
description:
Distinguish vars and functions in #'symbol-file, #'describe-{function,variable}
lisp/ChangeLog addition:
2008-12-22 Aidan Kehoe <kehoea(a)parhasard.net>
* loadhist.el (symbol-file):
Add support for differentiating between variables and functions to
#'symbol-file.
* help.el (describe-function-1):
(describe-variable):
Call #'symbol-function explicitly with a 'defun or 'defvar
argument, depending on whether we're looking for a variable or a
function.
* cus-face.el (custom-declare-face):
Record information about the face in the load history; code taken
from GNU, pre-GPLv3 revision 1.45.
src/ChangeLog addition:
2008-12-22 Aidan Kehoe <kehoea(a)parhasard.net>
* symbols.c (Fdefine_function):
* eval.c (define_function):
Record explicitly that we're defining a function in the load
history, in both these files.
diff -r f32c7f843961dee21a36b15b232b8ee66c009bb4 -r 69a1eda3da06721407d3085ed7aabd1112b22173 lisp/ChangeLog
--- a/lisp/ChangeLog Mon Dec 22 12:09:08 2008 +0000
+++ b/lisp/ChangeLog Mon Dec 22 14:07:48 2008 +0000
＠＠ -1,3 +1,17 ＠＠ 2008-10-29 Stephen J. Turnbull <stephe
+2008-12-22 Aidan Kehoe <kehoea(a)parhasard.net>
+
+ * loadhist.el (symbol-file):
+ Add support for differentiating between variables and functions to
+ #'symbol-file.
+ * help.el (describe-function-1):
+ (describe-variable):
+ Call #'symbol-function explicitly with a 'defun or 'defvar
+ argument, depending on whether we're looking for a variable or a
+ function.
+ * cus-face.el (custom-declare-face):
+ Record information about the face in the load history; code taken
+ from GNU, pre-GPLv3 revision 1.45.
+
2008-10-29 Stephen J. Turnbull <stephen(a)xemacs.org>
* bytecomp.el (byte-compile-file): Protect encoding from latin-unity.
diff -r f32c7f843961dee21a36b15b232b8ee66c009bb4 -r 69a1eda3da06721407d3085ed7aabd1112b22173 lisp/cus-face.el
--- a/lisp/cus-face.el Mon Dec 22 12:09:08 2008 +0000
+++ b/lisp/cus-face.el Mon Dec 22 14:07:48 2008 +0000
＠＠ -50,6 +50,9 ＠＠
frames (cdr frames))
(face-display-set face value frame '(custom)))
(init-face-from-resources face)))
+ ;; Don't record SPEC until we see it causes no errors.
+ (put face 'face-defface-spec spec)
+ (push (cons 'defface face) current-load-list)
(when (and doc (null (face-doc-string face)))
(set-face-doc-string face doc))
(custom-handle-all-keywords face args 'custom-face)
diff -r f32c7f843961dee21a36b15b232b8ee66c009bb4 -r 69a1eda3da06721407d3085ed7aabd1112b22173 lisp/help.el
--- a/lisp/help.el Mon Dec 22 12:09:08 2008 +0000
+++ b/lisp/help.el Mon Dec 22 14:07:48 2008 +0000
＠＠ -1425,7 +1425,7 ＠＠ part of the documentation of internal su
nil)))
(princ "\n")
(or file-name
- (setq file-name (symbol-file function)))
+ (setq file-name (symbol-file function 'defun)))
(when file-name
(princ " -- loaded from \"")
(if (not (bufferp standard-output))
＠＠ -1651,7 +1651,7 ＠＠ there is no variable around that point,
(princ (built-in-variable-doc variable))
(princ ".\n")
(require 'hyper-apropos)
- (let ((file-name (symbol-file variable))
+ (let ((file-name (symbol-file variable 'defvar))
opoint e)
(when file-name
(princ " -- loaded from \"")
diff -r f32c7f843961dee21a36b15b232b8ee66c009bb4 -r 69a1eda3da06721407d3085ed7aabd1112b22173 lisp/loadhist.el
--- a/lisp/loadhist.el Mon Dec 22 12:09:08 2008 +0000
+++ b/lisp/loadhist.el Mon Dec 22 14:07:48 2008 +0000
＠＠ -48,11 +48,12 ＠＠ are acceptable.
are acceptable.
If TYPE is `defvar', then variable definitions are acceptable.
-#### For the moment the difference is not implemented for non-autoloaded
-Lisp symbols."
+`defface' specifies a face definition only, and for the moment, it won't
+return faces created with `make-face' or `copy-face', just those created
+with `defface' and `custom-declare-face'."
(interactive "SFind source file for symbol: ") ; XEmacs
(block look-up-symbol-file
- (let (built-in-file autoload-cons)
+ (let (built-in-file autoload-cons symbol-details)
(when (and
(eq 'autoload
(car-safe (setq autoload-cons
＠＠ -64,9 +65,25 ＠＠ Lisp symbols."
(memq (fifth autoload-cons) '(nil macro)))))
(return-from look-up-symbol-file
(locate-library (second autoload-cons))))
- (dolist (entry load-history)
- (when (memq sym (cdr entry))
- (return-from look-up-symbol-file (car entry))))
+ (cond ((eq 'defvar type)
+ ;; Load history entries corresponding to variables are just
+ ;; symbols.
+ (dolist (entry load-history)
+ (when (memq sym (cdr entry))
+ (return-from look-up-symbol-file (car entry)))))
+ ((not (null type))
+ ;; Non-variables have the type stored as the car of the entry.
+ (dolist (entry load-history)
+ (when (and (setq symbol-details (rassq sym (cdr entry)))
+ (eq type (car symbol-details)))
+ (return-from look-up-symbol-file (car entry)))))
+ (t
+ ;; If TYPE hasn't been specified, we need to check both for
+ ;; variables and other symbols.
+ (dolist (entry load-history)
+ (when (or (memq sym (cdr entry))
+ (rassq sym (cdr entry)))
+ (return-from look-up-symbol-file (car entry))))))
(setq built-in-file (built-in-symbol-file sym type))
(if built-in-file (concat source-directory "/src/" built-in-file)))))
diff -r f32c7f843961dee21a36b15b232b8ee66c009bb4 -r 69a1eda3da06721407d3085ed7aabd1112b22173 src/ChangeLog
--- a/src/ChangeLog Mon Dec 22 12:09:08 2008 +0000
+++ b/src/ChangeLog Mon Dec 22 14:07:48 2008 +0000
＠＠ -1,3 +1,10 ＠＠ 2008-12-22 Aidan Kehoe <kehoea＠parhasa
+2008-12-22 Aidan Kehoe <kehoea(a)parhasard.net>
+
+ * symbols.c (Fdefine_function):
+ * eval.c (define_function):
+ Record explicitly that we're defining a function in the load
+ history, in both these files.
+
2008-12-22 Aidan Kehoe <kehoea(a)parhasard.net>
* faces.c (Fbuilt_in_face_specifiers):
diff -r f32c7f843961dee21a36b15b232b8ee66c009bb4 -r 69a1eda3da06721407d3085ed7aabd1112b22173 src/eval.c
--- a/src/eval.c Mon Dec 22 12:09:08 2008 +0000
+++ b/src/eval.c Mon Dec 22 14:07:48 2008 +0000
＠＠ -1223,7 +1223,7 ＠＠ define_function (Lisp_Object name, Lisp_
define_function (Lisp_Object name, Lisp_Object defn)
{
Ffset (name, defn);
- LOADHIST_ATTACH (name);
+ LOADHIST_ATTACH (Fcons (Qdefun, name));
return name;
}
diff -r f32c7f843961dee21a36b15b232b8ee66c009bb4 -r 69a1eda3da06721407d3085ed7aabd1112b22173 src/symbols.c
--- a/src/symbols.c Mon Dec 22 12:09:08 2008 +0000
+++ b/src/symbols.c Mon Dec 22 14:07:48 2008 +0000
＠＠ -718,7 +718,7 ＠＠ Associates the function with the current
{
/* This function can GC */
Ffset (symbol, newdef);
- LOADHIST_ATTACH (symbol);
+ LOADHIST_ATTACH (Fcons (Qdefun, symbol));
return newdef;
}
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
[COMMIT] Differentiate between symbol variables and functions, find-func
15 years, 4 months
Aidan Kehoe
APPROVE COMMIT
NOTE: This patch has been committed.
xemacs-packages/xemacs-devel/ChangeLog addition:
2008-12-22 Aidan Kehoe <kehoea(a)parhasard.net>
* find-func.el (find-function-noselect):
(find-variable-noselect):
(find-definition-noselect):
Call #'symbol-file with two arguments if that is allowing,
allowing us to differentiate between variables and functions with
the same symbol name.
XEmacs Packages source patch:
Diff command: cvs -q diff -Nu
Files affected: xemacs-packages/xemacs-devel/find-func.el
===================================================================
RCS
Index: xemacs-packages/xemacs-devel/find-func.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/xemacs-devel/find-func.el,v
retrieving revision 1.12
diff -u -u -r1.12 find-func.el
--- xemacs-packages/xemacs-devel/find-func.el 2007/12/30 14:24:59 1.12
+++ xemacs-packages/xemacs-devel/find-func.el 2008/12/22 14:03:33
＠＠ -289,7 +289,9 ＠＠
(let ((library
(cond ((eq (car-safe def) 'autoload)
(nth 1 def))
- ((symbol-file function))
+ ((if (function-allows-args 'symbol-file 2)
+ (symbol-file function 'defun)
+ (symbol-file function)))
;; XEmacs addition: function annotations
((fboundp 'compiled-function-annotation)
(cond ((compiled-function-p def)
＠＠ -408,7 +410,9 ＠＠
`find-function-source-path', if non nil, otherwise in `load-path'."
(if (not variable)
(error "You didn't specify a variable"))
- (let ((library (or file (symbol-file variable))))
+ (let ((library (or file (if (function-allows-args 'symbol-file 2)
+ (symbol-file variable 'defvar)
+ (symbol-file variable)))))
(unless (and (null library) (built-in-variable-type variable))
(error "%s is a primitive variable" variable))
(find-function-search-for-symbol variable 'variable library)))
＠＠ -449,7 +453,7 ＠＠
(defun find-definition-noselect (symbol type &optional file)
"Return a pair `(BUFFER . POINT)' pointing to the definition of SYMBOL.
TYPE says what type of definition: nil for a function,
-`defvar' or `defface' for a variable or face. This functoin
+`defvar' or `defface' for a variable or face. This function
does not switch to the buffer or display it.
The library where SYMBOL is defined is searched for in FILE or
＠＠ -458,7 +462,10 ＠＠
(error "You didn't specify a symbol"))
(if (null type)
(find-function-noselect symbol)
- (let ((library (or file (symbol-file symbol))))
+ (let ((library (or file
+ (if (function-allows-args 'symbol-file 2)
+ (symbol-file symbol type)
+ (symbol-file symbol)))))
(find-function-search-for-symbol symbol type library))))
;; RMS says:
--
¿Dónde estará ahora mi sobrino Yoghurtu Nghé, que tuvo que huir
precipitadamente de la aldea por culpa de la escasez de rinocerontes?
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
commit: #'built-in-face-specifiers; document that we're returning a copy.
15 years, 4 months
Aidan Kehoe
changeset: 4534:f32c7f843961dee21a36b15b232b8ee66c009bb4
tag: tip
user: Aidan Kehoe <kehoea(a)parhasard.net>
date: Mon Dec 22 12:09:08 2008 +0000
files: src/ChangeLog src/faces.c
description:
#'built-in-face-specifiers; document that we're returning a copy.
2008-12-22 Aidan Kehoe <kehoea(a)parhasard.net>
* faces.c (Fbuilt_in_face_specifiers):
Document that we're returning a copy.
diff -r 4a7c4ccac2fe43b0e94d0273722f569258eae608 -r f32c7f843961dee21a36b15b232b8ee66c009bb4 src/ChangeLog
--- a/src/ChangeLog Mon Dec 22 12:05:47 2008 +0000
+++ b/src/ChangeLog Mon Dec 22 12:09:08 2008 +0000
＠＠ -1,3 +1,8 ＠＠ 2008-12-21 Aidan Kehoe <kehoea＠parhasa
+2008-12-22 Aidan Kehoe <kehoea(a)parhasard.net>
+
+ * faces.c (Fbuilt_in_face_specifiers):
+ Document that we're returning a copy.
+
2008-12-21 Aidan Kehoe <kehoea(a)parhasard.net>
* faces.c (Fbuilt_in_face_specifiers):
diff -r 4a7c4ccac2fe43b0e94d0273722f569258eae608 -r f32c7f843961dee21a36b15b232b8ee66c009bb4 src/faces.c
--- a/src/faces.c Mon Dec 22 12:05:47 2008 +0000
+++ b/src/faces.c Mon Dec 22 12:09:08 2008 +0000
＠＠ -703,6 +703,9 ＠＠ Return the name of the given face.
DEFUN ("built-in-face-specifiers", Fbuilt_in_face_specifiers, 0, 0, 0, /*
Return a list of all built-in face specifier properties.
+
+This is a copy; there is no way to modify XEmacs' idea of the built-in face
+specifier properties from Lisp.
*/
())
{
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
[COMMIT] Return a list copy in #'built-in-face-specifiers, pre-empting modification.
15 years, 4 months
Aidan Kehoe
Small change, prevention is a better mechanism than admonishment.
# HG changeset patch
# User Aidan Kehoe <kehoea(a)parhasard.net>
# Date 1229880186 0
# Branch bytecomp-coding-system-2008-10-29
# Node ID 16906fefc8df0d642aec6fd43d78637af0054965
# Parent b58af9a9765dec7ac331ed18350012172389688d
Return a list copy in #'built-in-face-specifiers, pre-empting modification.
2008-12-21 Aidan Kehoe <kehoea(a)parhasard.net>
* faces.c (Fbuilt_in_face_specifiers):
Don't simply warn the user not to modify
Vbuilt_in_face_specifiers, enforce this by returning a copy of the
list.
diff -r b58af9a9765d -r 16906fefc8df src/ChangeLog
--- a/src/ChangeLog Sun Nov 02 03:59:54 2008 +0900
+++ b/src/ChangeLog Sun Dec 21 17:23:06 2008 +0000
＠＠ -1,3 +1,10 ＠＠
+2008-12-21 Aidan Kehoe <kehoea(a)parhasard.net>
+
+ * faces.c (Fbuilt_in_face_specifiers):
+ Don't simply warn the user not to modify
+ Vbuilt_in_face_specifiers, enforce this by returning a copy of the
+ list.
+
2008-11-02 Stephen J. Turnbull <stephen(a)xemacs.org>
G++ 4.3 complains a lot about implicit conversions of string
diff -r b58af9a9765d -r 16906fefc8df src/faces.c
--- a/src/faces.c Sun Nov 02 03:59:54 2008 +0900
+++ b/src/faces.c Sun Dec 21 17:23:06 2008 +0000
＠＠ -703,11 +703,10 ＠＠
DEFUN ("built-in-face-specifiers", Fbuilt_in_face_specifiers, 0, 0, 0, /*
Return a list of all built-in face specifier properties.
-Don't modify this list!
*/
())
{
- return Vbuilt_in_face_specifiers;
+ return Fcopy_list(Vbuilt_in_face_specifiers);
}
/* These values are retrieved so often that we make a special
--
¿Dónde estará ahora mi sobrino Yoghurtu Nghé, que tuvo que huir
precipitadamente de la aldea por culpa de la escasez de rinocerontes?
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
commit: Return a list copy in #'built-in-face-specifiers, pre-empting modification.
15 years, 4 months
Aidan Kehoe
changeset: 4532:16906fefc8df0d642aec6fd43d78637af0054965
tag: tip
user: Aidan Kehoe <kehoea(a)parhasard.net>
date: Sun Dec 21 17:23:06 2008 +0000
files: src/ChangeLog src/faces.c
description:
Return a list copy in #'built-in-face-specifiers, pre-empting modification.
2008-12-21 Aidan Kehoe <kehoea(a)parhasard.net>
* faces.c (Fbuilt_in_face_specifiers):
Don't simply warn the user not to modify
Vbuilt_in_face_specifiers, enforce this by returning a copy of the
list.
diff -r b58af9a9765dec7ac331ed18350012172389688d -r 16906fefc8df0d642aec6fd43d78637af0054965 src/ChangeLog
--- a/src/ChangeLog Sun Nov 02 03:59:54 2008 +0900
+++ b/src/ChangeLog Sun Dec 21 17:23:06 2008 +0000
＠＠ -1,3 +1,10 ＠＠ 2008-11-02 Stephen J. Turnbull <stephe
+2008-12-21 Aidan Kehoe <kehoea(a)parhasard.net>
+
+ * faces.c (Fbuilt_in_face_specifiers):
+ Don't simply warn the user not to modify
+ Vbuilt_in_face_specifiers, enforce this by returning a copy of the
+ list.
+
2008-11-02 Stephen J. Turnbull <stephen(a)xemacs.org>
G++ 4.3 complains a lot about implicit conversions of string
diff -r b58af9a9765dec7ac331ed18350012172389688d -r 16906fefc8df0d642aec6fd43d78637af0054965 src/faces.c
--- a/src/faces.c Sun Nov 02 03:59:54 2008 +0900
+++ b/src/faces.c Sun Dec 21 17:23:06 2008 +0000
＠＠ -703,11 +703,10 ＠＠ Return the name of the given face.
DEFUN ("built-in-face-specifiers", Fbuilt_in_face_specifiers, 0, 0, 0, /*
Return a list of all built-in face specifier properties.
-Don't modify this list!
*/
())
{
- return Vbuilt_in_face_specifiers;
+ return Fcopy_list(Vbuilt_in_face_specifiers);
}
/* These values are retrieved so often that we make a special
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches