[AC] Misuse of the list widget type
17 years, 1 month
Didier Verna
NOTE: This patch has been committed. The version below is
informational only (whitespace differences have been removed).
Dear reviewers,
the following patch fixes some misuses of the list widget type.
xemacs-packages/liece/lisp/ChangeLog addition:
2007-09-04 Didier Verna <didier(a)xemacs.org>
* liece-hilit.el (liece-quoted-colors-ircle): Fix misuse of the
list widget type.
* liece-hilit.el (liece-quoted-colors-mirc): Ditto.
* liece-tcp.el (liece-tcp-rlogin-parameters): Ditto.
XEmacs Packages source patch:
Diff command: cvs -q diff -u -t -b -B -w
Files affected: xemacs-packages/liece/lisp/liece-tcp.el xemacs-packages/liece/lisp/liece-hilit.el
Index: xemacs-packages/liece/lisp/liece-hilit.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/liece/lisp/liece-hilit.el,v
retrieving revision 1.1
diff -u -u -t -b -B -w -r1.1 liece-hilit.el
--- xemacs-packages/liece/lisp/liece-hilit.el 23 Mar 2002 05:51:28 -0000 1.1
+++ xemacs-packages/liece/lisp/liece-hilit.el 4 Sep 2007 09:03:48 -0000
@@ -131,7 +131,7 @@
"cyan4" "turquoise" "blue" "black" "black" "black" "black" "black"
"DarkBlue" "purple1" "purple2" "purple3" "magenta")
"Color list for displaying \003 quoted string."
-:type '(list (radio string face))
+:type '(repeat (radio string face))
:group 'liece-highlight)
(defcustom liece-quoted-colors-mirc
@@ -139,7 +139,7 @@
"orange" "yellow" "green" "cyan4" "turquoise" "RoyalBlue" "HotPink"
"gray50" "gray75" "black" "black" "black" "black")
"Color list for displaying \013 quoted string."
-:type '(list (radio string face))
+:type '(repeat (radio string face))
:group 'liece-highlight)
(defcustom liece-highlight-jingle-function nil
Index: xemacs-packages/liece/lisp/liece-tcp.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/liece/lisp/liece-tcp.el,v
retrieving revision 1.1
diff -u -u -t -b -B -w -r1.1 liece-tcp.el
--- xemacs-packages/liece/lisp/liece-tcp.el 23 Mar 2002 05:51:36 -0000 1.1
+++ xemacs-packages/liece/lisp/liece-tcp.el 4 Sep 2007 09:03:48 -0000
@@ -98,7 +98,7 @@
(defcustom liece-tcp-rlogin-parameters '("socket" "-q")
"Parameters to `liece-tcp-open-rlogin'."
-:type 'list
+:type '(repeat string)
:group 'liece-tcp)
(defcustom liece-tcp-rlogin-user-name nil
--
MySpace: http://www.myspace.com/didierverna
Didier Verna, didier(a)lrde.epita.fr, http://www.lrde.epita.fr/~didier
EPITA / LRDE, 14-16 rue Voltaire Tel.+33 (1) 44 08 01 85
94276 Le Kremlin-Bicêtre, France Fax.+33 (1) 53 14 59 22 didier(a)xemacs.org
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
[AC] Misuse of the list widget type
17 years, 1 month
Didier Verna
NOTE: This patch has been committed. The version below is
informational only (whitespace differences have been removed).
Dear reviewers,
the following patch fixes some misuses of the list widget type.
xemacs-packages/hm--html-menus/ChangeLog addition:
2007-09-04 Didier Verna <didier(a)xemacs.org>
* internal-drag-and-drop.el (idd-actions): Fix misuse of the list
widget type.
* hm--html-configuration.el (hm--html-idd-actions): Ditto.
XEmacs Packages source patch:
Diff command: cvs -q diff -u -t -b -B -w
Files affected: xemacs-packages/hm--html-menus/hm--html-configuration.el xemacs-packages/hm--html-menus/internal-drag-and-drop.el
Index: xemacs-packages/hm--html-menus/internal-drag-and-drop.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/hm--html-menus/internal-drag-and-drop.el,v
retrieving revision 6.22
diff -u -u -t -b -B -w -r6.22 internal-drag-and-drop.el
--- xemacs-packages/hm--html-menus/internal-drag-and-drop.el 6 Oct 2000 08:46:00 -0000 6.22
+++ xemacs-packages/hm--html-menus/internal-drag-and-drop.el 4 Sep 2007 09:01:50 -0000
@@ -243,7 +243,7 @@
of `idd-action-copy-region' and `idd-action-copy-replace-region'. They are
examples for such actions."
:group 'idd-drag-and-drop
-:type 'list)
+:type 'sexp)
(make-variable-buffer-local 'idd-actions)
Index: xemacs-packages/hm--html-menus/hm--html-configuration.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/hm--html-menus/hm--html-configuration.el,v
retrieving revision 6.23
diff -u -u -t -b -B -w -r6.23 hm--html-configuration.el
--- xemacs-packages/hm--html-menus/hm--html-configuration.el 27 Jun 2003 18:50:36 -0000 6.23
+++ xemacs-packages/hm--html-menus/hm--html-configuration.el 4 Sep 2007 09:01:50 -0000
@@ -879,7 +879,7 @@
"The action list for the destination mode `hm--html-mode'.
Look at the description of the variable idd-actions."
:group 'hm--html-keys
-:type 'list)
+:type 'sexp)
;;; The font lock keywords
--
MySpace: http://www.myspace.com/didierverna
Didier Verna, didier(a)lrde.epita.fr, http://www.lrde.epita.fr/~didier
EPITA / LRDE, 14-16 rue Voltaire Tel.+33 (1) 44 08 01 85
94276 Le Kremlin-Bicêtre, France Fax.+33 (1) 53 14 59 22 didier(a)xemacs.org
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
[AC] Misuse of the list widget type
17 years, 1 month
Didier Verna
NOTE: This patch has been committed. The version below is
informational only (whitespace differences have been removed).
Dear reviewers,
the following patch fixes a misuse of the list widget type.
xemacs-packages/eshell/ChangeLog addition:
2007-09-04 Didier Verna <didier(a)xemacs.org>
* esh-util.el (eshell-ange-ls-uids): Fix misuse of the list widget
type.
XEmacs Packages source patch:
Diff command: cvs -q diff -u -t -b -B -w
Files affected: xemacs-packages/eshell/esh-util.el
Index: xemacs-packages/eshell/esh-util.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/eshell/esh-util.el,v
retrieving revision 1.4
diff -u -u -t -b -B -w -r1.4 esh-util.el
--- xemacs-packages/eshell/esh-util.el 13 May 2007 17:07:18 -0000 1.4
+++ xemacs-packages/eshell/esh-util.el 4 Sep 2007 08:58:42 -0000
@@ -98,7 +98,7 @@
(defcustom eshell-ange-ls-uids nil
"*List of user/host/id strings, used to determine remote ownership."
-:type '(list (cons :tag "Host/User Pair"
+:type '(repeat (cons :tag "Host/User Pair"
(string :tag "Hostname")
(repeat (cons :tag "User/UID List"
(string :tag "Username")
--
MySpace: http://www.myspace.com/didierverna
Didier Verna, didier(a)lrde.epita.fr, http://www.lrde.epita.fr/~didier
EPITA / LRDE, 14-16 rue Voltaire Tel.+33 (1) 44 08 01 85
94276 Le Kremlin-Bicêtre, France Fax.+33 (1) 53 14 59 22 didier(a)xemacs.org
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
[PATCH] savehist.el don't try to print unprintable values
17 years, 1 month
Robert Pluim
savehist-minibuffer-history-variables sometimes contains buffer objects,
which are a bit hard to prin1 ;-)
Robert
2007-08-30 Robert Pluim <rpluim(a)gmail.com>
* savehist.el (savehist-save): don't try to print unprintable values
diff -u c:\Program
Files\XEmacs\xemacs-packages\lisp\edit-utils\savehist.el.~1~ c:\Program
Files\XEmacs\xemacs-packages\lisp\edit-utils\savehist.el
--- c:\Program
Files\XEmacs\xemacs-packages\lisp\edit-utils\savehist.el.~1~ 2007-08-30
10:19:43.187500000 +0200
+++ c:\Program Files\XEmacs\xemacs-packages\lisp\edit-utils\savehist.el
2007-08-30 10:19:43.187500000 +0200
@@ -306,9 +306,10 @@
(dolist (symbol savehist-minibuffer-history-variables)
(when (boundp symbol)
(let ((value (savehist-trim-history (symbol-value symbol))))
- (when value ; don't save empty histories
- (prin1 `(setq ,symbol ',value) (current-buffer))
- (insert ?\n))))))
+ (and value ; don't save empty histories
+ (savehist-printable value)
+ (prin1 `(setq ,symbol ',value) (current-buffer))
+ (insert ?\n))))))
;; Save the additional variables.
(dolist (symbol savehist-additional-variables)
(when (boundp symbol)
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches