Re: [Q] Import Edward O'Connor's json.el.
17 years, 9 months
Aidan Kehoe
Ar an chéad lá de mí Eanair, scríobh Stephen J. Turnbull:
> Damn, I don't know how I missed this. It's in my (now 200 posts long,
> which I've finally found time to weed out) xemacs-todo folder, but not
> in any of my list-specific folders :-(
>
> You have my apologies; you did respond to my QUERY. Still, you should
> have waited for a retraction before committing (ie, pinging me because
> I seemed to be ignoring you).
Heh, I thought it was a good sign--no energetic criticism means you agree,
right?
> Having looked more carefully, my veto stands; you will need to collect
> votes to override it (though that is probably easier than I thought).
Not something I’m super-optimistic about--that would involve at least two
other active reviewers taking an interest in the thing.
> Aidan Kehoe writes:
>
> > Ar an triú lá déag de mí na Nollaig, scríobh Stephen J. Turnbull:
>
> > > This doesn't belong in net-utils. Nor does xml.el, for that matter.
> > > We'll have to think about the implications of moving xml.el, but let's
> > > not follow that precedent here.
> > >
> > > The existing package that fits best is prog-modes,
>
> > It doesn't fit in prog-modes at all. JSON is a data format, like ASN.1,
> > S-expressions, and XML.
>
> I don't entirely agree with classing JSON, ASN.1, s-exprs, and XML
> together in that way, but you're right, it doesn't fit into
> prog-modes.
For the sake of my understanding your thinking, why don’t you agree with
classing the four together in that way? If I’m going to pass data structures
between programs, I’m going to use one of the four, when not Berkeley DB or
a relational DB.
> > This is not a mode. This is a library for Lisp programming.
>
> OK, having looked more closely, I agree with that. For that very
> reason, it doesn't belong in net-utils. net-utils is mostly user
> interactive utilities. Other *-utils such as edit-utils and os-utils
> are mostly interactive user stuff or user configuration utilities,
> too.
Except that at least two existing files in net-utils are libraries for Lisp
programming, and there’s no such separation enforced in the rest of the
tree.
Honestly, reorganising the packages tree to group net-oriented Lisp
libraries together is a worthy thing to do, but it’s a distinct, separate
task from importing json.el. Pressuring me to do it by means of your veto
will work, and my sense of perspective means I’m not about to hold a grudge
on it, but in a general sense it is the wrong way to go about this. The
right way would be to take the half-hour to do it yourself after the commit;
adding json.el to net-utils now doesn’t conflict with that.
Your argument about shadowing doesn’t hold as an objection, since it applies
equally to xml.el, which is already in the tree in an undesirable place, and
would be moved if we were to implement a net-lib package. (And ‘net-lib’ as
a name, parallel to ‘mail-lib’ is one real option.)
--
When I was in the scouts, the leader told me to pitch a tent. I couldn't
find any pitch, so I used creosote.
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
Re: [COMMIT] Import Edward O'Connor's json.el
17 years, 9 months
Aidan Kehoe
Ar an chéad lá de mí Eanair, scríobh Stephen J. Turnbull:
> dns.el, shadowfile.el, and mozmail.el are all utilities intended to
> facilitate certain kinds of communication over the network. json.el,
> like xml.el, is an editor package providing an editor mode for a certain
> language
No it’s not. Did you read my response where I made that clear?
17793.19077.50295.840813(a)parhasard.net:
“JSON is a data format, like ASN.1, S-expressions, and XML. (Though
closest in spirit to S-expressions; the ability to do an eval() in
JavaScript is one of its selling points.) The library converts
JSON-encoded data to Lisp data types, and vice-versa. It doesn’t add
support for interactively editing JSON files in XEmacs, since
javascript-mode already provides that adequately.”
This is not a mode. This is a library for Lisp programming. net-utils fits
best, though I agree that it’s not ideal.”
> (which happens to be associated with the WWW). The
> former, not the latter, is what net-utils is for. Since you've made
> no argument at all that json.el belongs in net-utils, I'm not willing
> to retract my veto.
The mail made that argument and is in Gmane, and the web archive; check your
mail delivery infrastructure for problems if it didn’t get to you.
--
When I was in the scouts, the leader told me to pitch a tent. I couldn't
find any pitch, so I used creosote.
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
Re: [COMMIT] Import Edward O'Connor's json.el
17 years, 9 months
Aidan Kehoe
Ar an t-aonú lá is triochad de mí na Nollaig, scríobh Stephen J. Turnbull:
> VETO
>
> Get this OUT of net-utils!
No! If dns.el, shadowfile.el, xml.el and mozmail.el all fit comfortably in
net-utils, which they do, this should too.
> Aidan Kehoe writes:
>
> > Ted, this makes your json.el more easily available to XEmacs users.
> > Included is a tweak to have it better work on non-Mule XEmacs
> > invocations.
> >
> > APPROVE COMMIT
> >
> > NOTE: This patch has been committed.
> >
> > SUPERSEDES 17793.19077.50295.840813(a)parhasard.net
> >
> > xemacs-packages/net-utils/ChangeLog addition:
> >
--
When I was in the scouts, the leader told me to pitch a tent. I couldn't
find any pitch, so I used creosote.
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
[COMMIT] Provide native-coding-systems for some language environments that didn't have them
17 years, 9 months
Aidan Kehoe
Also changes a line in ChangeLog where ‘to’ was repeated needlessly.
APPROVE COMMIT
NOTE: This patch has been committed.
lisp/ChangeLog addition:
2006-12-30 Aidan Kehoe <kehoea(a)parhasard.net>
* mule/cyrillic.el ("Cyrillic-ISO"):
* mule/english.el ("English"):
* mule/greek.el ("Greek"):
Specify a native-coding-system for each of these language
environments--since that is what is examined and relevant when
sniffing the locale at startup.
* mule/mule-cmds.el (create-variant-language-environment):
A language environment's coding-priority is a list of coding
systems, not coding categories. Treat it as such.
XEmacs Trunk source patch:
Diff command: cvs -q diff -Nu
Files affected: lisp/mule/mule-cmds.el
===================================================================
RCS lisp/mule/greek.el
===================================================================
RCS lisp/mule/english.el
===================================================================
RCS lisp/mule/cyrillic.el
===================================================================
RCS
Index: lisp/mule/cyrillic.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/mule/cyrillic.el,v
retrieving revision 1.13
diff -u -u -r1.13 cyrillic.el
--- lisp/mule/cyrillic.el 2006/12/29 18:09:46 1.13
+++ lisp/mule/cyrillic.el 2006/12/30 17:00:50
＠＠ -127,6 +127,7 ＠＠
"Cyrillic-ISO" '((charset cyrillic-iso8859-5)
(tutorial . "TUTORIAL.ru")
(coding-system iso-8859-5)
+ (native-coding-system iso-8859-5)
(coding-priority iso-8859-5)
(input-method . "cyrillic-yawerty")
(features cyril-util)
Index: lisp/mule/english.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/mule/english.el,v
retrieving revision 1.7
diff -u -u -r1.7 english.el
--- lisp/mule/english.el 2006/11/05 22:31:37 1.7
+++ lisp/mule/english.el 2006/12/30 17:00:50
＠＠ -50,6 +50,9 ＠＠
"English" '((tutorial . "TUTORIAL")
(locale "en" "C")
(charset ascii)
+ (coding-system iso-8859-1)
+ (coding-priority iso-8859-1)
+ (native-coding-system iso-8859-1)
(sample-text . "Hello!, Hi!, How are you?")
(documentation . "\
Nothing special is needed to handle English.")
Index: lisp/mule/greek.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/mule/greek.el,v
retrieving revision 1.7
diff -u -u -r1.7 greek.el
--- lisp/mule/greek.el 2006/12/29 18:09:46 1.7
+++ lisp/mule/greek.el 2006/12/30 17:00:50
＠＠ -130,6 +130,7 ＠＠
"Greek" '((charset greek-iso8859-7)
(coding-system iso-8859-7)
(coding-priority iso-8859-7)
+ (native-coding-system iso-8859-7)
(locale "el_GR.iso88597" "el_GR.greek8" "el_GR" "greek" "el")
(input-method . "greek")
(sample-text . "Greek (,FGkk]mija(B) ,FCei\(B ,Fsar(B")
Index: lisp/mule/mule-cmds.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/mule/mule-cmds.el,v
retrieving revision 1.30
diff -u -u -r1.30 mule-cmds.el
--- lisp/mule/mule-cmds.el 2006/12/29 18:09:47 1.30
+++ lisp/mule/mule-cmds.el 2006/12/30 17:00:51
＠＠ -1093,7 +1093,7 ＠＠
coding-system)
'coding-system (cons coding-system
(cdr (assoc 'coding-system (cdr langenv)))))
- 'coding-priority (cons (coding-system-category coding-system)
+ 'coding-priority (cons coding-system
(cdr (assq 'coding-priority (cdr langenv))))))))
(defun get-language-environment-from-locale (locale)
--
When I was in the scouts, the leader told me to pitch a tent. I couldn't
find any pitch, so I used creosote.
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
[PATCH] Support German, Spanish, French, Russian in morse.el
17 years, 9 months
Aidan Kehoe
Of the many things remaining to do in XEmacs development, it did strike me
when writing it that there could be few more useless than adding incomplete
multilingual support to morse-region and unmorse-region. But, on discovering
that Wikipedia has complete articles in several languages on the subject, it
seemed the thing to do.
Yes, I need to test this with non-Mule. No, it doesn’t yet have Japanese or
Chinese support; I can recognise Kana enough to do the former, but not
enough Hanzi for the latter.
--- morse.el.orig 2006-12-14 18:08:31.218750000 +0100
+++ morse.el 2006-12-14 18:13:10.750000000 +0100
＠＠ -1,6 +1,6 ＠＠
;;; morse.el --- convert text to morse code and back
-;; Copyright (C) 1995 Free Software Foundation, Inc.
+;; Copyright (C) 1995, 2006 Free Software Foundation, Inc.
;; Author: Rick Farnbach <rick_farnbach(a)MENTORG.COM>
;; Keywords: games
＠＠ -29,55 +29,153 ＠＠
;;; Code:
-(defvar morse-code '(("a" . ".-")
- ("b" . "-...")
- ("c" . "-.-.")
- ("d" . "-..")
- ("e" . ".")
- ("f" . "..-.")
- ("g" . "--.")
- ("h" . "....")
- ("i" . "..")
- ("j" . ".---")
- ("k" . "-.-")
- ("l" . ".-..")
- ("m" . "--")
- ("n" . "-.")
- ("o" . "---")
- ("p" . ".--.")
- ("q" . "--.-")
- ("r" . ".-.")
- ("s" . "...")
- ("t" . "-")
- ("u" . "..-")
- ("v" . "...-")
- ("w" . ".--")
- ("x" . "-..-")
- ("y" . "-.--")
- ("z" . "--..")
- ;; Punctuation
- ("=" . "-...-")
- ("?" . "..--..")
- ("/" . "-..-.")
- ("," . "--..--")
- ("." . ".-.-.-")
- (":" . "---...")
- ("'" . ".----.")
- ("-" . "-....-")
- ("(" . "-.--.-")
- (")" . "-.--.-")
- ;; Numbers
- ("0" . "-----")
- ("1" . ".----")
- ("2" . "..---")
- ("3" . "...--")
- ("4" . "....-")
- ("5" . ".....")
- ("6" . "-....")
- ("7" . "--...")
- ("8" . "---..")
- ("9" . "----."))
- "Morse code character set.")
+(defvar english-alphabet-morse-code '(("a" . ".-")
+ ("b" . "-...")
+ ("c" . "-.-.")
+ ("d" . "-..")
+ ("e" . ".")
+ ("f" . "..-.")
+ ("g" . "--.")
+ ("h" . "....")
+ ("i" . "..")
+ ("j" . ".---")
+ ("k" . "-.-")
+ ("l" . ".-..")
+ ("m" . "--")
+ ("n" . "-.")
+ ("o" . "---")
+ ("p" . ".--.")
+ ("q" . "--.-")
+ ("r" . ".-.")
+ ("s" . "...")
+ ("t" . "-")
+ ("u" . "..-")
+ ("v" . "...-")
+ ("w" . ".--")
+ ("x" . "-..-")
+ ("y" . "-.--")
+ ("z" . "--.."))
+ "Morse code, as used for the letters of English.")
+
+(defvar german-alphabet-morse-code (nconc
+ '(("ä" . ".-.-")
+ ("ö" . "---.")
+ ("ü" . "..--")
+ ("ß" . "...--..")
+ ("ch". "----"))
+ english-alphabet-morse-code)
+ "Morse code, as used for the letters of German.")
+
+(defvar spanish-alphabet-morse-code (nconc
+ '(("ch". "----")
+ ("ñ" . "--.--")
+ ("ü" . "..--"))
+ english-alphabet-morse-code)
+ "Morse code, as used for the letters of Spanish.")
+
+(defvar french-alphabet-morse-code (nconc
+ '(("ç". "-.-..")
+ ("è". ".-..-")
+ ("é" . "..-..")
+ ("à" . ".--.-"))
+ english-alphabet-morse-code))
+
+(defvar swedish-alphabet-morse-code (nconc
+ '(("ä" . ".-.-")
+ ("ö" . "---.")
+ ("å" . ".--.-"))
+ english-alphabet-morse-code)
+ "Morse code, as used for the letters of Swedish. ")
+
+(when (featurep 'mule)
+ (defvar cyrillic-alphabet-morse-code
+ (mapcar (lambda (entry)
+ (cons (string (make-char 'cyrillic-iso8859-5 (pop entry)))
+ (pop entry)))
+ '((#xb0 ".-")
+ (#xb1 "-...")
+ (#xb2 ".--")
+ (#xb3 "--.")
+ (#xb4 "-..")
+ (#xb5 ".")
+ (#xb6 "...-")
+ (#xb7 "--..")
+ (#xb8 "..")
+ (#xb9 ".---")
+ (#xba "-.-")
+ (#xbb ".-..")
+ (#xbc "--")
+ (#xbd "-.")
+ (#xbe "---")
+ (#xbf ".--.")
+ (#xc0 ".-.")
+ (#xc1 "...")
+ (#xc2 "-")
+ (#xc3 "..-")
+ (#xc4 "..-.")
+ (#xc5 "....")
+ (#xc6 "-.-.")
+ (#xc7 "---.")
+ (#xc8 "----")
+ (#xc9 "--.-")
+ (#xcc "-..-")
+ (#xcb "-.--")
+ (#xcd "..-..")
+ (#xce "..--")
+ (#xcf ".-.-")))
+ "Morse code, as used for the letters of Russian."))
+
+(defvar digits-punctuation-morse-code '(("0" . "-----")
+ ("1" . ".----")
+ ("2" . "..---")
+ ("3" . "...--")
+ ("4" . "....-")
+ ("5" . ".....")
+ ("6" . "-....")
+ ("7" . "--...")
+ ("8" . "---..")
+ ("9" . "----.")
+ ;; Punctuation
+ ("=" . "-...-")
+ ("?" . "..--..")
+ ("/" . "-..-.")
+ ("," . "--..--")
+ ("." . ".-.-.-")
+ (":" . "---...")
+ ("'" . ".----.")
+ ("-" . "-....-")
+ ("(" . "-.--.-")
+ (")" . "-.--.-")
+ ("＠" . ".--.-.")
+ ("+" . ".-.-."))
+ "The digits and punctuation in morse code, as used internationally.")
+
+(defvar active-morse-code nil
+ "The active Morse alphabet, digits, and puncuation, as an alist.")
+
+(defun choose-active-morse-code ()
+ "Work out what `active-morse-code' should be.
+Depends on the current language environment."
+ (let ((alphabet-sym (intern-soft
+ (format "%s-alphabet-morse-code"
+ (if (and (boundp 'current-language-environment)
+ current-language-environment)
+ (downcase
+ (car (split-string
+ current-language-environment
+ "[- ]")))
+ "english")))))
+ (if (and alphabet-sym (boundp alphabet-sym))
+ (setq active-morse-code
+ (append (symbol-value alphabet-sym)
+ digits-punctuation-morse-code))
+ (setq active-morse-code
+ (append english-alphabet-morse-code
+ digits-punctuation-morse-code)))))
+
+(choose-active-morse-code)
+
+(add-hook 'set-language-environment-hook 'choose-active-morse-code)
;;;###autoload
(defun morse-region (beg end)
＠＠ -94,7 +192,7 ＠＠
(cond ((looking-at "\\s-+")
(goto-char (match-end 0))
(setq sep ""))
- ((setq morse (assoc str morse-code))
+ ((setq morse (assoc str active-morse-code))
(delete-char 1)
(insert sep (cdr morse))
(setq sep "/"))
＠＠ -104,7 +202,7 ＠＠
;;;###autoload
(defun unmorse-region (beg end)
- "Convert morse coded text in region to ordinary ASCII text."
+ "Convert morse coded text in region to ordinary text."
(interactive "r")
(if (integerp end)
(setq end (copy-marker end)))
＠＠ -115,7 +213,7 ＠＠
(if (null (looking-at "[-.]+"))
(forward-char 1)
(setq str (buffer-substring (match-beginning 0) (match-end 0)))
- (if (null (setq morse (rassoc str morse-code)))
+ (if (null (setq morse (rassoc str active-morse-code)))
(goto-char (match-end 0))
(replace-match
(if (string-equal "(" (car morse))
--
“No one can guarantee that any course of action in Iraq at this point will
stop sectarian warfare, growing violence, or a slide toward chaos.”
(Iraq Study Group Report, Dec. 6, 2006)
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
Re: [Q] Import Edward O'Connor's json.el.
17 years, 9 months
Aidan Kehoe
Ar an triú lá déag de mí na Nollaig, scríobh Stephen J. Turnbull:
> > An issue with this is that the package uses encode-char and
> > decode-char with 'ucs as an argument, something 21.4 doesn’t have
> > without Mule-UCS, and which non-Mule builds don’t have at all. This
> > means I have to edit it to be compilable by non-Mule 21.4, but if
> > anyone has objections to the other aspects of the import, I’d love to
> > hear them.
>
> Non-mule is basically a non-starter for 'net content-related work
> these days for precisely that reason. I wouldn't have a problem with
> moving it to a Mule package.
>
> This doesn't belong in net-utils. Nor does xml.el, for that matter.
> We'll have to think about the implications of moving xml.el, but let's
> not follow that precedent here.
>
> The existing package that fits best is prog-modes,
It doesn’t fit in prog-modes at all. JSON is a data format, like ASN.1,
S-expressions, and XML. (Though closest in spirit to S-expressions; the
ability to do an eval() in JavaScript is one of its selling points.) The
library converts JSON-encoded data to Lisp data types, and vice-versa. It
doesn’t add support for interactively editing JSON files in XEmacs, since
javascript-mode already provides that adequately.
This is not a mode. This is a library for Lisp programming. net-utils fits
best, though I agree that it’s not ideal.
> but that's not a good idea because I expect there must be several of
> these guys around;
There doesn’t appear to be. The intersection of Emacs Lisp coders with
Web-2.0 enthusiasts is a lonely place.
> they should be collected in one, reasonably well-named place. I
> suggest consulting with Norbert, and Ville and Steve Youngs if they're
> around, about creating a new package "web-content-modes". (Probably
> you can come up with a better name. Maybe it should be "-utils" for a
> collection of small things.) Or if we've got other js-related
> libraries, a javascript-modes package.
JSON is intended to be used independently of JavaScript; it doesn’t make a
huge amount of sense to create a javascript-modes package for its sake. From
json.org:
“JSON (JavaScript Object Notation) is a lightweight data-interchange
format. It is easy for humans to read and write. It is easy for machines
to parse and generate. It is based on a subset of the JavaScript
Programming Language, Standard ECMA-262 3rd Edition - December 1999. JSON
is a text format that is completely language independent but uses
conventions that are familiar to programmers of the C-family of languages,
including C, C++, C#, Java, JavaScript, Perl, Python, and many others.
These properties make JSON an ideal data-interchange language.”
It’s ideal when you’re passing server-side data to client-side web
applications, and since server-side programs can be in almost any language,
and since support for JSON is not complicated to implement, a long list of
languages supports the format.
--
“No one can guarantee that any course of action in Iraq at this point will
stop sectarian warfare, growing violence, or a slide toward chaos.”
(Iraq Study Group Report, Dec. 6, 2006)
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
[PATCH] Fix compilation --with-debug-malloc && --with-error-checking=malloc; better dlmalloc overhead
17 years, 9 months
Nix
XEmacs's definition of xfree() as a macro taking two arguments collides
violently with <dmalloc.h>'s definition of xmalloc() as a (quite
different) macro taking one argument.
Given that all including <dmalloc.h> is giving us is reporting of line
numbers of allocations, and that even that is only provided in alloc.c,
and that those line numbers are basically always going to be one of a
very small set in XEmacs, the easiest way to fix this is to simply not
bother including <dmalloc.h> at all: dmalloc still works as long as
XEmacs is linked with -ldmalloc (which it still is when
--with-debug-malloc is on.)
(Some parts of lwlib still include it, but all include files which may
be included by XEmacs proper are dmalloc.h-clean. If we want better
coverage, we can add it to lwlib alone, rather than polluting XEmacs
with it.)
As an additional wrinkle, the Doug Lea malloc() has always had an
overhead of at least 4 bytes per allocated chunk (8 bytes per chunk for
machines with 8-bit pointers, more if this is a large request satisfied
via mmap() rather than via arena allocation). For now, 4 bytes is more
accurate than the previous figure of, um, 0. (What malloc() has no bytes
of overhead?! How on earth would it track blocks?)
(Note that with that patch XEmacs compiles, but crashes down inside
libfontconfig as soon as it starts under dmalloc. This may be a
fontconfig-specific weirdness. Investigating.)
lwlib changelog:
2006-12-28 Nix <nix(a)esperi.org.uk>
* lwlib-utils.h (USE_DEBUG_MALLOC): Do not include dmalloc.h.
src changelog:
2006-12-28 Nix <nix(a)esperi.org.uk>
* alloc.c (USE_DEBUG_MALLOC): Do not include dmalloc.h.
* gc.h: Improve overhead estimate for dlmalloc.
Index: 21.5/lwlib/lwlib-utils.h
===================================================================
--- 21.5.orig/lwlib/lwlib-utils.h 2001-04-16 23:21:29.000000000 +0100
+++ 21.5/lwlib/lwlib-utils.h 2006-12-28 22:23:57.000000000 +0000
＠＠ -18,8 +18,4 ＠＠
void XtSafelyDestroyWidget (Widget);
-#ifdef USE_DEBUG_MALLOC
-#include <dmalloc.h>
-#endif
-
#endif /* INCLUDED_lwlib_utils_h_ */
Index: 21.5/src/alloc.c
===================================================================
--- 21.5.orig/src/alloc.c 2006-10-24 19:28:56.000000000 +0100
+++ 21.5/src/alloc.c 2006-12-28 22:03:46.000000000 +0000
＠＠ -84,7 +84,6 ＠＠
the hope being that some debugging tools may help detect
freed memory references */
#ifdef USE_DEBUG_MALLOC /* Taking the above comment at face value -slb */
-#include <dmalloc.h>
#define ALLOC_NO_POOLS
#endif
Index: 21.5/src/gc.h
===================================================================
--- 21.5.orig/src/gc.h 2006-03-28 18:43:54.000000000 +0100
+++ 21.5/src/gc.h 2006-12-28 22:05:18.000000000 +0000
＠＠ -85,7 +85,9 ＠＠
/************************************************************************/
#ifndef MALLOC_OVERHEAD
-#ifdef GNU_MALLOC
+#if defined (DOUG_LEA_MALLOC)
+#define MALLOC_OVERHEAD 4 /* Minimum, assuming 4-byte pointers */
+#elif defined (GNU_MALLOC)
#define MALLOC_OVERHEAD 0
#elif defined (rcheck)
#define MALLOC_OVERHEAD 20
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
Re: [COMMIT] Add case support for Cyrillic, change various syntax choices
17 years, 9 months
Aidan Kehoe
Ar an t-ochtú lá déag de mí na Nollaig, scríobh Stephen J. Turnbull:
> Aidan Kehoe writes:
>
> > NO BREAK SPACE is whitespace.
>
> For my information, not an objection to the patch. I seem to recall
> that this is "standard", but do you have a reference for that? I've
> always thought that was stupid, especially in Emacsen. It should be a
> symbol constituent. That permits navigating by words but enforces the
> non-breaking syntax.
My strategy w.r.t. syntax tables was wrong in that patch. What I should have
done was copied the syntax from the corresponding Latin 1 character; and the
same should be done for most of the characters in european.el.
NO BREAK SPACE is currently a symbol constituent in Latin 1.
--
When I was in the scouts, the leader told me to pitch a tent. I couldn't
find any pitch, so I used creosote.
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
[AC] [PATCH] Workaround problems with autoconf 2.60's config.status --recheck.
17 years, 9 months
Malcolm Purvis
APPROVE COMMIT
It turns out that there is a simple work around for the problems with
'config.status --recheck' under autoconf 2.60 and 2.61. By default the
autoconf variable ac_configure_args contains a leading space, but we strip
this off via a call to XE_SPACE. The solution is to restore the space.
ChangeLog addition:
2006-12-28 Malcolm Purvis <malcolmp(a)xemacs.org>
* configure.ac: Ensure ac_configure_args contains a leading space
to work around problems with 'config.status --recheck' under
autoconf 2.60 and 2.61.
xemacs-autoconf-2.60 source patch:
Diff command: cvs -q diff -u
Files affected: configure.ac
Index: configure.ac
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/configure.ac,v
retrieving revision 1.53
diff -u -r1.53 configure.ac
--- configure.ac 2006/12/28 12:23:57 1.53
+++ configure.ac 2006/12/28 12:42:22
＠＠ -5815,6 +5815,9 ＠＠
fi
XE_SPACE(ac_configure_args, $ac_configure_args)
+dnl Put back the leading space to work around problems with
+dnl 'config.status --recheck' under autoconf 2.60 and 2.61.
+ac_configure_args=" $ac_configure_args"
AC_DEFINE_UNQUOTED(EMACS_CONFIGURATION, "$ac_cv_build")
AC_DEFINE_UNQUOTED(EMACS_CONFIG_OPTIONS, "$ac_configure_args")
--
Malcolm Purvis <malcolmp(a)xemacs.org>
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
