>>>> "Andy" == Andy Piper
<andy(a)xemacs.org> writes:
> This is probably another bug from Andy's
"optimization" of
> buffer reversion. If so, it is at least the third, maybe
> fourth, I can remember. I think we should revert Andy's patch.
Andy> And I fixed all of them
After people ran into trouble. Why make the users suffer?
And basically what is happening is that you are duplicating the
original functionality, with the added complexity of saving state
around the changes needed to make your optimization work. The
function was pretty ugly to start with; now I don't think anybody but
you is likely to understand it on a quick read-through.
Andy> I don't think you should. Its also not clear to me why my
Andy> patch is to blame here. font-lock doesn't get run if the
Andy> reversion is "optimized", otherwise the normal rules apply.
Let's revert it, and find out. ;-)
Look, there's a simple way to have our cake and eat it, too. Revert
the patch, and optionally hang your version of the function on the
default value of `revert-buffer-function' for those who specifically
request it. Since that variable is permanent-local, it shouldn't
interfere with its main purpose (allowing non-file buffers to be
reverted) as that is implemented in buffer-local values.
This puts the risk of bugs where it belongs: on the people who want
the optimization.
--
Institute of Policy and Planning Sciences
http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Ask not how you can "do" free software business;
ask what your business can "do for" free software.