"Vladimir G. Ivanovic" <vladimir(a)acm.org> writes:
Running XEmacs thusly
xemacs -vanilla -eval "(add-hook 'text-mode-hook
'turn-on-auto-fill)"
produces this error
Signaling: (end-of-buffer)
fill-region-as-paragraph(3809 4025 left nosqueeze)
fill-region(3809 4025 left nosqueeze)
fill-flowed()
mm-inline-text((#<buffer " *mm*"> ("text/plain" (charset .
"us-ascii") (format . "flowed")) 7bit nil nil nil nil nil))
mm-display-inline((#<buffer " *mm*"> ("text/plain"
(charset . "us-ascii") (format . "flowed")) 7bit nil nil nil nil
nil))
mm-display-part((#<buffer " *mm*"> ("text/plain" (charset
. "us-ascii") (format . "flowed")) 7bit nil nil nil nil nil))
mh-mime-display-single((#<buffer " *mm*"> ("text/plain"
(charset . "us-ascii") (format . "flowed")) 7bit nil nil nil nil
nil))
mh-mime-display-part((#<buffer " *mm*"> ("text/plain"
(charset . "us-ascii") (format . "flowed")) 7bit nil nil nil nil
nil))
mh-mime-display()
mh-display-msg(1 "+problem_messages")
mh-show-msg(nil)
mh-show(nil)
mh-maybe-show()
mh-previous-undeleted-msg(1)
call-interactively(mh-previous-undeleted-msg)
when I read just a few (out of many hundreds) mail messages with MH-E.
(I have kept about a dozen of these messages.) I am using MH-E 7.1, but
it also occurred with MH-E 7.0 (and possibly before).
It is a known bug in flow-fill.el. Incorporating the current Gnus CVS
version or Emacs CVS version in the XEmacs gnus package should be
safe.
2003-02-03 Simon Josefsson <jas(a)extundo.com>
* flow-fill.el: Sync with Oort to fix a bug.
Index: flow-fill.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/gnus/gnus/lisp/flow-fill.el,v
retrieving revision 1.2
diff -u -p -u -w -r1.2 flow-fill.el
--- flow-fill.el 8 Feb 2001 08:57:12 -0000 1.2
+++ flow-fill.el 3 Feb 2003 01:21:45 -0000
@@ -1,6 +1,6 @@
;;; flow-fill.el --- interprete RFC2646 "flowed" text
-;; Copyright (C) 2000 Free Software Foundation, Inc.
+;; Copyright (C) 2000, 2001, 2002 Free Software Foundation, Inc.
;; Author: Simon Josefsson <jas(a)pdc.kth.se>
;; Keywords: mail
@@ -35,22 +35,40 @@
;; paragraph and we let `fill-region' fill the long line into several
;; lines with the quote prefix as `fill-prefix'.
-;; Todo: encoding, implement basic `fill-region' (Emacs and XEmacs
+;; Todo: implement basic `fill-region' (Emacs and XEmacs
;; implementations differ..)
-;; History:
+;;; History:
;; 2000-02-17 posted on ding mailing list
;; 2000-02-19 use `point-at-{b,e}ol' in XEmacs
;; 2000-03-11 no compile warnings for point-at-bol stuff
-;; 2000-03-26 commited to gnus cvs
+;; 2000-03-26 committed to gnus cvs
;; 2000-10-23 don't flow "-- " lines, make "quote-depth wins"
rule
;; work when first line is at level 0.
+;; 2002-01-12 probably incomplete encoding support
;;; Code:
(eval-when-compile (require 'cl))
+(defcustom fill-flowed-display-column 'fill-column
+ "Column beyond which format=flowed lines are wrapped, when displayed.
+This can be a lisp expression or an integer."
+:type '(choice (const :tag "Standard `fill-column'" fill-column)
+ (const :tag "Fit Window" (- (window-width) 5))
+ (sexp)
+ (integer)))
+
+(defcustom fill-flowed-encode-column 66
+ "Column beyond which format=flowed lines are wrapped, in outgoing messages.
+This can be a lisp expression or an integer.
+RFC 2646 suggests 66 characters for readability."
+:type '(choice (const :tag "Standard fill-column" fill-column)
+ (const :tag "RFC 2646 default (66)" 66)
+ (sexp)
+ (integer)))
+
(eval-and-compile
(defalias 'fill-flowed-point-at-bol
(if (fboundp 'point-at-bol)
@@ -62,6 +80,27 @@
'point-at-eol
'line-end-position)))
+(defun fill-flowed-encode (&optional buffer)
+ (with-current-buffer (or buffer (current-buffer))
+ ;; No point in doing this unless hard newlines is used.
+ (when use-hard-newlines
+ (let ((start (point-min)) end)
+ ;; Go through each paragraph, filling it and adding SPC
+ ;; as the last character on each line.
+ (while (setq end (text-property-any start (point-max) 'hard 't))
+ (let ((fill-column (eval fill-flowed-encode-column)))
+ (fill-region start end t 'nosqueeze 'to-eop))
+ (goto-char start)
+ ;; `fill-region' probably distorted end.
+ (setq end (text-property-any start (point-max) 'hard 't))
+ (while (and (< (point) end)
+ (re-search-forward "$" (1- end) t))
+ (insert " ")
+ (setq end (1+ end))
+ (forward-char))
+ (goto-char (setq start (1+ end)))))
+ t)))
+
(defun fill-flowed (&optional buffer)
(save-excursion
(set-buffer (or (current-buffer) buffer))
@@ -70,7 +109,8 @@
(when (save-excursion
(beginning-of-line)
(looking-at "^\\(>*\\)\\( ?\\)"))
- (let ((quote (match-string 1)) sig)
+ (let ((quote (match-string 1))
+ sig)
(if (string= quote "")
(setq quote nil))
(when (and quote (string= (match-string 2) ""))
@@ -79,6 +119,7 @@
(beginning-of-line)
(when (> (skip-chars-forward ">") 0)
(insert " "))))
+ ;; XXX slightly buggy handling of "-- "
(while (and (save-excursion
(ignore-errors (backward-char 3))
(setq sig (looking-at "-- "))
@@ -86,17 +127,25 @@
(save-excursion
(unless (eobp)
(forward-char 1)
- (looking-at (format "^\\(%s\\)\\([^>]\\)" (or quote "
?"))))))
+ (looking-at (format "^\\(%s\\)\\([^>]\\)"
+ (or quote " ?"))))))
(save-excursion
(replace-match (if (string= (match-string 2) " ")
"" "\\2")))
(backward-delete-char -1)
(end-of-line))
(unless sig
- (let ((fill-prefix (when quote (concat quote " "))))
+ (condition-case nil
+ (let ((fill-prefix (when quote (concat quote " ")))
+ (fill-column (eval fill-flowed-display-column))
+ filladapt-mode)
(fill-region (fill-flowed-point-at-bol)
- (fill-flowed-point-at-eol)
- 'left 'nosqueeze))))))))
+ (min (1+ (fill-flowed-point-at-eol))
+ (point-max))
+ 'left 'nosqueeze))
+ (error
+ (forward-line 1)
+ nil))))))))
(provide 'flow-fill)