4:10 p.m.
On 8/18/06, Robert Pluim <rpluim(a)gmail.com> wrote:
4. The balloon-help frame actually has a title. I was expecting it to
just be a tooltippy kind of window. Perhaps it should be a dialog
rather than a window?
Ok, we could fix this by removing WS_CAPTION from MSWINDOWS_POPUP_STYLE, I
think. If we wanted to, that is.
Robert
10:37 p.m.
New subject: [Bug: 21.4.19] balloon help niggles on Windows
"Robert Pluim" <rpluim(a)gmail.com> writes:
On 8/18/06, Robert Pluim <rpluim(a)gmail.com> wrote:
4. The balloon-help frame actually has a title. I was expecting it to
just be a tooltippy kind of window. Perhaps it should be a dialog
rather than a window?
Ok, we could fix this by removing WS_CAPTION from MSWINDOWS_POPUP_STYLE, I
think. If we wanted to, that is.
Hi Robert, do you have a patch for this for me to try out?
Adrian
Robert
--
Adrian Aichner
mailto:adrian＠xemacs.org
http://www.xemacs.org/
9:37 a.m.
New subject: [Bug: 21.4.19] balloon help niggles on Windows
I'm away from the office at the moment, so I'm afraid this will have to wait
a week or so. Sorry about the delay.
Robert
On 8/25/06, Adrian Aichner <adrian(a)xemacs.org> wrote:
"Robert Pluim" <rpluim(a)gmail.com> writes:
> On 8/18/06, Robert Pluim <rpluim(a)gmail.com> wrote:
>
> 4. The balloon-help frame actually has a title. I was expecting it
to
> just be a tooltippy kind of window. Perhaps it should be a dialog
> rather than a window?
>
> Ok, we could fix this by removing WS_CAPTION from
MSWINDOWS_POPUP_STYLE, I
> think. If we wanted to, that is.
Hi Robert, do you have a patch for this for me to try out?
Adrian
>
> Robert
>
--
Adrian Aichner
mailto:adrian＠xemacs.org
http://www.xemacs.org/
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta
10:17 a.m.
New subject: [Bug: 21.4.19] balloon help niggles on Windows
Here it is, against 21.4 CVS (let me know if gmail mangles the patch).
Robert
pcl-cvs: descending directory
Index: frame-msw.c
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/src/frame-msw.c,v
retrieving revision 1.33.2.4
diff -u -p -r1.33.2.4 frame-msw.c
--- frame-msw.c 2003/03/20 03:53:37 1.33.2.4
+++ frame-msw.c 2006/08/22 08:35:09
＠＠ -45,7 +45,7 ＠＠ Boston, MA 02111-1307, USA. */
#define MSWINDOWS_FRAME_STYLE (WS_CLIPCHILDREN | WS_CLIPSIBLINGS |
WS_OVERLAPPEDWINDOW)
#define MSWINDOWS_POPUP_STYLE (WS_CLIPCHILDREN | WS_CLIPSIBLINGS | WS_POPUP
\
- | WS_CAPTION | WS_BORDER | WS_SYSMENU | WS_MINIMIZEBOX)
+ | WS_BORDER | WS_SYSMENU | WS_MINIMIZEBOX)
#define MSWINDOWS_FRAME_EXSTYLE WS_EX_OVERLAPPEDWINDOW
#define MSWINDOWS_POPUP_EXSTYLE WS_EX_PALETTEWINDOW
On 8/25/06, Adrian Aichner <adrian(a)xemacs.org> wrote:
"Robert Pluim" <rpluim(a)gmail.com> writes:
> On 8/18/06, Robert Pluim <rpluim(a)gmail.com> wrote:
>
> 4. The balloon-help frame actually has a title. I was expecting it
to
> just be a tooltippy kind of window. Perhaps it should be a dialog
> rather than a window?
>
> Ok, we could fix this by removing WS_CAPTION from
MSWINDOWS_POPUP_STYLE, I
> think. If we wanted to, that is.
Hi Robert, do you have a patch for this for me to try out?
Adrian
>
> Robert
>
--
Adrian Aichner
mailto:adrian＠xemacs.org
http://www.xemacs.org/
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta
10:16 p.m.
New subject: [Bug: 21.4.19] balloon help niggles on Windows
Ugggh! This whole thing is pretty ugly! Here are some observations:
1. This patch:
diff --git a/balloon-help.el b/balloon-help.el
index 1fa53b4..09504c7 100755
--- a/balloon-help.el
+++ b/balloon-help.el
＠＠ -466,7 +466,7 ＠＠ (defun balloon-help-resize-help-frame ()
(and (not done) (setq lines (1+ lines))))
(setq width (/ longest font-width)
width (if (> longest (* width font-width)) (1+ width) width))
- (set-frame-size balloon-help-frame (+ 0 width) lines))))
+ (set-frame-size balloon-help-frame (+ 1 width) lines))))
(defun balloon-help-compute-help-frame-y-location ()
(let* ((device-bottom (device-pixel-height
only works for me on the 2nd balloon-help; the first balloon-help is
still 2 lines high. As you observed, Robert, there's some difference
in behavior between the first and subsequent invocations.
2. That extra frame is really hideous. It appears in both 21.4 and
21.5. I have a sneaking suspicion this has something to do with the
detached minibuffer code I wrote many years ago.
3. The patch to remove the caption works and I'm leaning towards
applying it for 21.4. Are there other windows that would be affected?
- Vin
--
The Journey by Mary Oliver
http://www.poemhunter.com/p/m/poem.asp?poet=6771&poem=30506
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta
8:56 a.m.
New subject: [Bug: 21.4.19] balloon help niggles on Windows
On 12/21/06, Vin Shelton <acs(a)alumni.princeton.edu> wrote:
Ugggh! This whole thing is pretty ugly! Here are some observations:
1. This patch:
diff --git a/balloon-help.el b/balloon-help.el
index 1fa53b4..09504c7 100755
--- a/balloon-help.el
+++ b/balloon-help.el
＠＠ -466,7 +466,7 ＠＠ (defun balloon-help-resize-help-frame ()
(and (not done) (setq lines (1+ lines))))
(setq width (/ longest font-width)
width (if (> longest (* width font-width)) (1+ width) width))
- (set-frame-size balloon-help-frame (+ 0 width) lines))))
+ (set-frame-size balloon-help-frame (+ 1 width) lines))))
(defun balloon-help-compute-help-frame-y-location ()
(let* ((device-bottom (device-pixel-height
only works for me on the 2nd balloon-help; the first balloon-help is
still 2 lines high. As you observed, Robert, there's some difference
in behavior between the first and subsequent invocations.
Even on 21.5? I don't see this there.
2. That extra frame is really hideous. It appears in both 21.4 and
21.5. I have a sneaking suspicion this has something to do with the
detached minibuffer code I wrote many years ago.
I lean more towards the "frames under mswindows don't support
'initially-unmapped" myself. That property is checked in frame-msw.c, but
then never actually used. Trial patch against 21.5 attached. (Is that
really the way you're supposed to indent if-statements in gnu-c-mode? gag).
3. The patch to remove the caption works and I'm leaning towards
applying it for 21.4. Are there other windows that would be
affected?
All popup windows, but the only users I can see offhand are balloon-help and
floating-toolbar. Oh, and dialog boxes, probably (I have those turned off).
Robert
--
2006-12-22 <rpluim(a)gmail.com>
* frame-msw.c (mswindows_init_frame_1): Honour 'initially-unmapped.
(mswindows_init_frame_3): ditto.
pcl-cvs: descending directory src/
Index: frame-msw.c
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/src/frame-msw.c,v
retrieving revision 1.59
diff -u -r1.59 frame-msw.c
--- frame-msw.c 2005/11/25 01:42:02 1.59
+++ frame-msw.c 2006/12/22 08:39:03
＠＠ -151,6 +151,16 ＠＠
/* Pick up relevant properties */
initially_unmapped = Fplist_get (props, Qinitially_unmapped, Qnil);
+
+ if (!NILP(initially_unmapped))
+ {
+ f->visible = 0;
+ }
+ else
+ {
+ f->visible = 1;
+ }
+
name = Fplist_get (props, Qname, Qnil);
popup = Fplist_get (props, Qpopup, Qnil);
＠＠ -305,7 +315,8 ＠＠
mswindows_init_frame_3 (struct frame *f)
{
/* Don't do this earlier or we get a WM_PAINT before the frame is ready
*/
- ShowWindow (FRAME_MSWINDOWS_HANDLE (f), SW_SHOWNORMAL);
+ if (f->visible == 1)
+ ShowWindow (FRAME_MSWINDOWS_HANDLE (f), SW_SHOWNORMAL);
SetForegroundWindow (FRAME_MSWINDOWS_HANDLE (f));
DragAcceptFiles (FRAME_MSWINDOWS_HANDLE (f), TRUE);
}
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta
6329
days inactive
6455
days old
5 comments
3 participants
participants (3)
-
Adrian Aichner -
Robert Pluim -
Vin Shelton