1 p.m.
(I answered to xemacs-patches first, I'm resending my comment here. As
mail-lib maintainer I don't have a problem with accepting this, but I
think the real issue is if the XEmacs core should change, so any insight
on that would be good.)
On Mon, 10 Sep 2001, Björn Torkelsson wrote:
Superseeds my earlier patch to menubar-items.
Moving the "Options->Internet->Open URLs With" to browse-url. I think
it's more logical to have it there than in the core, and it's easier to
update when the package changes.
Patch to menubar-items will follow if/when this patch has been accepted.
(These are generic comments, I haven't really looked at the patch.)
FWIW my feelings are that having XEmacs internal stuff in (supposedly)
externally maintained files (browse-url.el) is less than perfect.
(Synching the file with the external source becomes a pain, someone
need to look over the XEmacs specific and decide that they indeed are
XEmacs specific and that they are still valid even after the other
changes. This review has to be done every time the file is synched.
There are more fun things to do..)
But I wouldn't have anything against putting this in a new file,
e.g. xemacs-url.el, in the mail-lib package, since I agree it may be
easier to maintain this in a package than in the core.
So assuming the patch is good (I didn't look at it, sorry) and that it
doesn't _have_ to be in browse-url.el but just in any package (and I
guess mail-lib would be a suitable place), MHO is to move it into a
mail-lib/xemacs-url.el.
$.2 idea..
9:26 p.m.
New subject: [PATCH] moving Open URL menu to browse-url
Simon Josefsson <jas(a)extundo.com> writes:
(I answered to xemacs-patches first, I'm resending my comment
here. As
mail-lib maintainer I don't have a problem with accepting this, but I
think the real issue is if the XEmacs core should change, so any insight
on that would be good.)
Well, why keep stuff in the core that depends on a package, designed for
one package only, and (probably) needs to be updated when the package
change? Isn't the idea to just keep the "core" functionality in the core
and the rest as packages?
/torkel
10:01 p.m.
New subject: [PATCH] moving Open URL menu to browse-url
torkel(a)acc.umu.se (Björn Torkelsson) writes:
Simon Josefsson <jas(a)extundo.com> writes:
> (I answered to xemacs-patches first, I'm resending my comment here. As
> mail-lib maintainer I don't have a problem with accepting this, but I
> think the real issue is if the XEmacs core should change, so any insight
> on that would be good.)
Well, why keep stuff in the core that depends on a package, designed for
one package only, and (probably) needs to be updated when the package
change? Isn't the idea to just keep the "core" functionality in the core
and the rest as packages?
I agree, just wanted to see if anyone disagreed. :-)
So, is this OK? (CVS history seem to be limited so I couldn't check
the copyright situation, I simply copied it from menubar-items.el.)
2001-09-13 Simon Josefsson <jas(a)extundo.com>
* browse-url-xemacs.el: New file.
2001-09-10 Björn Torkelsson <torkel(a)acc.umu.se>
* browse-url.el: added menus for choosing which browser to open
URL:s with (moved from menubar-items)
;;; browse-url-xemacs.el --- browse-url stuff for XEmacs
;; Copyright (C) 1991-1995, 1997-1998 Free Software Foundation, Inc.
;; Copyright (C) 1995 Tinker Systems and INS Engineering Corp.
;; Copyright (C) 1995 Sun Microsystems.
;; Copyright (C) 1995, 1996, 2000 Ben Wing.
;; Copyright (C) 1997 MORIOKA Tomohiko.
;; Maintainer: XEmacs Development Team
;; This file is part of XEmacs.
;; XEmacs is free software; you can redistribute it and/or modify
;; it under the terms of the GNU General Public License as published by
;; the Free Software Foundation; either version 2, or (at your option)
;; any later version.
;; XEmacs is distributed in the hope that it will be useful,
;; but WITHOUT ANY WARRANTY; without even the implied warranty of
;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
;; GNU General Public License for more details.
;; You should have received a copy of the GNU General Public License
;; along with XEmacs; see the file COPYING. If not, write to the
;; Free Software Foundation, Inc., 59 Temple Place - Suite 330,
;; Boston, MA 02111-1307, USA.
;;; Commentary:
;; This code comes from menubar-items.el in XEmacs core.
;;; Code:
(defvar browse-url-menu)
;;;###autoload
(progn
(defun browse-url-xemacs-init-menu ()
(if (featurep 'menubar)
(add-submenu '("Options" "Internet") browse-url-menu)
)))
(cond ((featurep 'xemacs)
(defvar browse-url-menu
'("%_Open URLs With"
["%_Emacs-W3"
(customize-set-variable 'browse-url-browser-function 'browse-url-w3)
:style radio
:selected (eq browse-url-browser-function 'browse-url-w3)
:active (and (fboundp 'browse-url-w3)
(fboundp 'w3-fetch))]
["Emacs-%_W3 (gnudoit)"
(customize-set-variable 'browse-url-browser-function 'browse-url-w3-gnudoit)
:style radio
:selected (eq browse-url-browser-function 'browse-url-w3-gnudoit)
:active (fboundp 'browse-url-w3-gnudoit)]
["%_Netscape"
(customize-set-variable 'browse-url-browser-function
'browse-url-netscape)
:style radio
:selected (eq browse-url-browser-function 'browse-url-netscape)
:active (fboundp 'browse-url-netscape)]
["%_Mosaic"
(customize-set-variable 'browse-url-browser-function
'browse-url-mosaic)
:style radio
:selected (eq browse-url-browser-function 'browse-url-mosaic)
:active (fboundp 'browse-url-mosaic)]
["Mosaic (%_CCI)"
(customize-set-variable 'browse-url-browser-function 'browse-url-cci)
:style radio
:selected (eq browse-url-browser-function 'browse-url-cci)
:active (fboundp 'browse-url-cci)]
["%_IXI Mosaic"
(customize-set-variable 'browse-url-browser-function
'browse-url-iximosaic)
:style radio
:selected (eq browse-url-browser-function 'browse-url-iximosaic)
:active (fboundp 'browse-url-iximosaic)]
["%_Lynx (xterm)"
(customize-set-variable 'browse-url-browser-function
'browse-url-lynx-xterm)
:style radio
:selected (eq browse-url-browser-function 'browse-url-lynx-xterm)
:active (fboundp 'browse-url-lynx-xterm)]
["L%_ynx (xemacs)"
(customize-set-variable 'browse-url-browser-function
'browse-url-lynx-emacs)
:style radio
:selected (eq browse-url-browser-function 'browse-url-lynx-emacs)
:active (fboundp 'browse-url-lynx-emacs)]
["%_Grail"
(customize-set-variable 'browse-url-browser-function
'browse-url-grail)
:style radio
:selected (eq browse-url-browser-function 'browse-url-grail)
:active (fboundp 'browse-url-grail)]
["%_Kde"
(customize-set-variable 'browse-url-browser-function
'browse-url-kde)
:style radio
:selected (eq browse-url-browser-function 'browse-url-kde)
:active (fboundp 'browse-url-kde)]
["Mo%_zilla"
(customize-set-variable 'browse-url-browser-function
'browse-url-gnome-moz)
:style radio
:selected (eq browse-url-browser-function 'browse-url-gnome-moz)
:active (fboundp 'browse-url-gnome-moz)]
["G%_aleon"
(customize-set-variable 'browse-url-browser-function
'browse-url-galeon)
:style radio
:selected (eq browse-url-browser-function 'browse-url-galeon)
:active (fboundp 'browse-url-galeon)]
["%_MMM"
(customize-set-variable 'browse-url-browser-function
'browse-url-mmm)
:style radio
:selected (eq browse-url-browser-function 'browse-url-mmm)
:active (fboundp 'browse-url-mmm)]
["MS-Windows Default %_Browser"
(customize-set-variable 'browse-url-browser-function
'browse-url-default-windows-browser)
:style radio
:selected (eq browse-url-browser-function 'browse-url-default-windows-browser)
:active (and (fboundp 'mswindows-shell-execute)
(fboundp 'browse-url-default-windows-browser))]
["G%_eneric Browser"
(customize-set-variable 'browse-url-browser-function
'browse-url-generic)
:style radio
:selected (eq browse-url-browser-function 'browse-url-generic)
:active (and (boundp 'browse-url-generic-program)
browse-url-generic-program
(fboundp 'browse-url-generic))]
))
(browse-url-xemacs-init-menu)
))
(provide 'browse-url-xemacs)
;;; browse-url-xemacs.el ends here
2:15 a.m.
New subject: [PATCH] moving Open URL menu to browse-url
>>>> (SJ)Simon Josefsson <jas(a)extundo.com> Sep/13/01
05:01pm:
SJ> So, is this OK? (CVS history seem to be limited so I couldn't check
SJ> the copyright situation, I simply copied it from menubar-items.el.)
On a slightly different note, several of these browsers I've never
heard of and certainly do not have on my machine. (I have
netscape/lynx/w3 on unix and IE/lynx/w3 on windows).
So, my suggestion is to change the browse-url-menu to something that
checks for which browsers are installed on the machine.
(defvar browse-url-menu
'("%_Open URLs With"
[w3...]
[netscape ...]
,＠(if (and mosaic-program (executable-find mosaic-program))
`([mosaic ...]))
,＠(if (and grail-program (executable-find grail-program))
`([grail ...]))
,＠(if (and kde-program (executable-find kde-program))
`([kde ...]))
...))
-jeff
SJ> (cond ((featurep 'xemacs)
SJ> (defvar browse-url-menu
SJ> '("%_Open URLs With"
SJ> ["%_Emacs-W3"
SJ> (customize-set-variable 'browse-url-browser-function
'browse-url-w3)
SJ> :style radio
SJ> :selected (eq browse-url-browser-function 'browse-url-w3)
SJ> :active (and (fboundp 'browse-url-w3)
SJ> (fboundp 'w3-fetch))]...
SJ> ["%_Netscape"
SJ> (customize-set-variable 'browse-url-browser-function
SJ> 'browse-url-netscape)
SJ> :style radio
SJ> :selected (eq browse-url-browser-function 'browse-url-netscape)
SJ> :active (fboundp 'browse-url-netscape)]
SJ> ["%_Mosaic"
SJ> (customize-set-variable 'browse-url-browser-function
SJ> 'browse-url-mosaic)
SJ> :style radio
SJ> :selected (eq browse-url-browser-function 'browse-url-mosaic)
SJ> :active (fboundp 'browse-url-mosaic)] ...
SJ> ["%_Lynx (xterm)"
SJ> (customize-set-variable 'browse-url-browser-function
SJ> 'browse-url-lynx-xterm)
SJ> :style radio
SJ> :selected (eq browse-url-browser-function 'browse-url-lynx-xterm)
SJ> :active (fboundp 'browse-url-lynx-xterm)]
SJ> ["L%_ynx (xemacs)"
SJ> (customize-set-variable 'browse-url-browser-function
SJ> 'browse-url-lynx-emacs)
SJ> :style radio
SJ> :selected (eq browse-url-browser-function 'browse-url-lynx-emacs)
SJ> :active (fboundp 'browse-url-lynx-emacs)]
SJ> ["%_Grail"
SJ> (customize-set-variable 'browse-url-browser-function
SJ> 'browse-url-grail)
SJ> :style radio
SJ> :selected (eq browse-url-browser-function 'browse-url-grail)
SJ> :active (fboundp 'browse-url-grail)]
SJ> ["%_Kde"
SJ> (customize-set-variable 'browse-url-browser-function
SJ> 'browse-url-kde)
SJ> :style radio
SJ> :selected (eq browse-url-browser-function 'browse-url-kde)
SJ> :active (fboundp 'browse-url-kde)]
SJ> ["Mo%_zilla"
SJ> (customize-set-variable 'browse-url-browser-function
SJ> 'browse-url-gnome-moz)
SJ> :style radio
SJ> :selected (eq browse-url-browser-function 'browse-url-gnome-moz)
SJ> :active (fboundp 'browse-url-gnome-moz)]
SJ> ["G%_aleon"
SJ> (customize-set-variable 'browse-url-browser-function
SJ> 'browse-url-galeon)
SJ> :style radio
SJ> :selected (eq browse-url-browser-function 'browse-url-galeon)
SJ> :active (fboundp 'browse-url-galeon)]
SJ> ["%_MMM"
SJ> (customize-set-variable 'browse-url-browser-function
SJ> 'browse-url-mmm)
SJ> :style radio
SJ> :selected (eq browse-url-browser-function 'browse-url-mmm)
SJ> :active (fboundp 'browse-url-mmm)]
SJ> ["MS-Windows Default %_Browser"
SJ> (customize-set-variable 'browse-url-browser-function
SJ> 'browse-url-default-windows-browser)
SJ> :style radio
SJ> :selected (eq browse-url-browser-function
'browse-url-default-windows-browser)
SJ> :active (and (fboundp 'mswindows-shell-execute)
SJ> (fboundp 'browse-url-default-windows-browser))]
SJ> ["G%_eneric Browser"
SJ> (customize-set-variable 'browse-url-browser-function
SJ> 'browse-url-generic)
SJ> :style radio
SJ> :selected (eq browse-url-browser-function 'browse-url-generic)
SJ> :active (and (boundp 'browse-url-generic-program)
SJ> browse-url-generic-program
SJ> (fboundp 'browse-url-generic))]
SJ> ))
...
2:07 a.m.
New subject: [PATCH] moving Open URL menu to browse-url
|--==> "JM" == Jeff Mincy <jeff(a)delphioutpost.com> writes:
JM> On a slightly different note, several of these browsers I've never
JM> heard of and certainly do not have on my machine. (I have
JM> netscape/lynx/w3 on unix and IE/lynx/w3 on windows).
JM> So, my suggestion is to change the browse-url-menu to something that
JM> checks for which browsers are installed on the machine.
I like the sound of that.
--
|---<Steve Youngs>---------------<GnuPG KeyID: 9E7E2820>---|
| XEmacs - It's not just an editor. |
| It's a way of life. |
|------------------------------------<youngs(a)xemacs.org>---|
3:22 p.m.
New subject: [PATCH] moving Open URL menu to browse-url
|--==> "JM" == Jeff Mincy <jeff(a)delphioutpost.com> writes:
JM> On a slightly different note, several of these browsers I've never
JM> heard of and certainly do not have on my machine. (I have
JM> netscape/lynx/w3 on unix and IE/lynx/w3 on windows).
JM> So, my suggestion is to change the browse-url-menu to something that
JM> checks for which browsers are installed on the machine.
From: Steve Youngs <youngs(a)xemacs.org>
Date: Sun, 16 Sep 2001 11:07:57 +1000
I like the sound of that.
From: Simon Josefsson <jas(a)extundo.com>
Date: Sun, 16 Sep 2001 12:58:03 +0200
I like the idea. Hm, could you please send a patch?
Yes, but, it will be a little while though....
I'm kind of swamped right now.
-jeff
11:58 a.m.
New subject: [PATCH] moving Open URL menu to browse-url
Jeff Mincy <jeff(a)delphioutpost.com> writes:
>>>>> (SJ)Simon Josefsson <jas(a)extundo.com>
Sep/13/01 05:01pm:
SJ> So, is this OK? (CVS history seem to be limited so I couldn't check
SJ> the copyright situation, I simply copied it from menubar-items.el.)
On a slightly different note, several of these browsers I've never
heard of and certainly do not have on my machine. (I have
netscape/lynx/w3 on unix and IE/lynx/w3 on windows).
So, my suggestion is to change the browse-url-menu to something that
checks for which browsers are installed on the machine.
I like the idea. Hm, could you please send a patch?
2:13 a.m.
New subject: [PATCH] moving Open URL menu to browse-url
|--==> "SJ" == Simon Josefsson <jas(a)extundo.com> writes:
SJ> torkel(a)acc.umu.se (Björn Torkelsson) writes:
>Well, why keep stuff in the core that depends on a package,
designed for
>one package only, and (probably) needs to be updated when the package
>change? Isn't the idea to just keep the "core" functionality in the
core
>and the rest as packages?
SJ> I agree, just wanted to see if anyone disagreed. :-)
I agree too.
SJ> So, is this OK? (CVS history seem to be limited so I couldn't check
SJ> the copyright situation, I simply copied it from menubar-items.el.)
You won't get any opposition from me. Did you remove this code from
menubar-items.el as well? (no point in duplication).
--
|---<Steve Youngs>---------------<GnuPG KeyID: 9E7E2820>---|
| XEmacs - It's not just an editor. |
| It's a way of life. |
|------------------------------------<youngs(a)xemacs.org>---|
11:04 a.m.
New subject: [PATCH] moving Open URL menu to browse-url
Steve Youngs <youngs(a)xemacs.org> writes:
|--==> "SJ" == Simon Josefsson <jas(a)extundo.com>
writes:
SJ> torkel(a)acc.umu.se (Björn Torkelsson) writes:
>>Well, why keep stuff in the core that depends on a package, designed for
>>one package only, and (probably) needs to be updated when the package
>>change? Isn't the idea to just keep the "core" functionality in
the core
>>and the rest as packages?
SJ> I agree, just wanted to see if anyone disagreed. :-)
I agree too.
Great :-)
SJ> So, is this OK? (CVS history seem to be limited so I
couldn't check
SJ> the copyright situation, I simply copied it from menubar-items.el.)
You won't get any opposition from me. Did you remove this code from
menubar-items.el as well? (no point in duplication).
I will make a patch for removing the stuff from menubar-items.el. But I
think that the updated mail-lib package should be in at least pre-release
before menubar-items is updated. (not that browse-url-xemacs is in
cvs/mail-lib yet. Hopefully I will send a patch for b-u-x later today).
Are there any guidelines for adding new files to packages?
/torkel
8465
days inactive
8471
days old
8 comments
4 participants
participants (4)
-
Björn Torkelsson -
Jeff Mincy -
Simon Josefsson -
Steve Youngs