Sounds great to be, please goahead and look at it. Cheers Jesper. On Saturday 14 July 2007, Adrian Aichner wrote: | Norbert Koch <viteno(a)xemacs.org&gt; writes: | > * "Jesper K. Pedersen" <blackie(a)blackie.dk&gt;: | > | > Hi! | > | >> Hello. Please find attached the latest version of wide-edit. | > | > Thanks. I've added it to my local copy of the xemacs-packages. It | > builds (at least). | > | > I'm wondering whether a 'provide' statement would be preferable to a | > (load "wide-edit.el"). Any objections to this? Or autoload cookies? | | Hi Jesper, Norbert, thanks for getting wide-edit into XEmacs package | edit-utils! | | I see three areas of improvement: | | Yes, `provide' and autoload cookies should be used in wide-edit.el as | well, and documentation updated accordingly (require instead of | load). Any objections, Jesper? | | wide-edit.el should not execute top-level code upon load. | I would suggest to wrap the top-level code in a defun like | `wide-edit-enable'. | The behaviors feature in XEmacs 21.5 can make direct use of that function | and another one to `wide-edit-disable'. See (info "(lispref)Enabling | Behavior") | I might be able to provide a patch which would not break current uses | of wide-edit. | | Finally, I found an issue when I discussed and tested wide-edit while | online with Jesper in #xemacs over a year ago. When user adds | newlines to the matches in the *grep* buffer, then C-x C-s is getting | unexpected content for all but the first match per file. While | implementing this fully would be a feature, I think the user should be | kept from falling into this trap. I might look into that one as well, | I just want to hear, Jesper, whether you would be in favor of these | changes. | | If anyone else wants to tackle any of the above, I'd be a happy tester. | | Best regards! | | Adrian | | > Thanks, | > norbert. | > | > _______________________________________________ | > XEmacs-Services mailing list | > XEmacs-Services(a)xemacs.org | > http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-services -- Having trouble finding a given image in your collection containing thousands of images? http://www.kphotoalbum.org might be the answer. _______________________________________________ XEmacs-Beta mailing list XEmacs-Beta(a)xemacs.org http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta