>>>> "AH" == Alastair J Houghton
<ajhoughton(a)lineone.net> writes:
AH> Here's a patch that modifies the clipboard support in
AH> XEmacs. It provides for an mswindows-style multi-format
AH> selections (e.g. you could keep an integer and its string
AH> representation in a selection and pull out whichever was
AH> most appropriate). It also adds the ability to register
AH> new data types with the host window system (only implemented
AH> for mswindows at the moment), as well as the ability to
AH> look up the names of external formats and the ability
AH> to get a conservative list of available selection formats
AH> for a given selection. Oh, and the append code has been
AH> changed from the *horrible* kludge that was used before.
This sounds exciting!
So I tried applying your patch.
Please produce unified diffs if your diff programs supports this
format (usually via the -u switch). This makes patches smaller and
much easier to read.
Here is what I get when applying your patch against latest CVS
sources:
cd d:\tmp\21.2\xemacs\
patch --strip=2 < d:\tmp\selection.diff
Compilation started at Mon Jul 10 01:33:22 2000 +0200 (W. Europe Daylight Time)
patching file `src/console.h'
Hunk #1 FAILED at 91.
1 out of 1 hunk FAILED -- saving rejects to src/console.h.rej
patching file `src/select-msw.c'
patching file `src/select-x.c'
patching file `src/select.c'
patching file `src/select.h'
patching file `lisp/select.el'
Compilation exited abnormally with code 1 at Mon Jul 10 01:33:27
So, there's a conflict with src/console.h.
Fortunately this was a simple matter. I patched manually.
The src/console.h you based your changes on is from before
2000-07-05 Kirill 'Big K' Katsnelson <kkm(a)dtmx.com>
* console-msw.h (struct mswindows_device): Removed unnecessary
cached device geometry values.
Added update_tick and an accessor macro.
(Lisp_Devmode): Added lrecord declaration.
(struct msprinter_device): Contain devmode as a Lisp object.
Added mswindows_get_selected_frame_hwnd();
* console.h (struct console_methods): Indentation nitpicking.
Correct?
I'm building right now.
AH> Additionally, the mswindows code for selection handling has
AH> been rewritten - it is now much cleaner, and uses the new
AH> functionality.
AH> I've tested it quite a bit on mswindows, but there might
AH> be some obscure problem that I haven't noticed yet (or
AH> even something obvious I've missed). However, as I'm now
AH> using a version containing this patch, I'm bound to
AH> notice anything wrong with it sooner or later...
I'm testing a native NT build.
XEmacs from latest CVS sources does not build after applying your
patch!
Can you please refresh your source-base and see what's wrong?
Here's what I get:
link.exe @C:\TEMP\nmb00348.
specifier.obj : error LNK2005: _Qappend already defined in select.obj
..\src\temacs.exe : fatal error LNK1169: one or more multiply defined symbols found
NMAKE : fatal error U1077: 'link.exe' : return code '0x491'
Stop.
Is there a patch to specifier.c which you forgot to include?
Best regards,
Adrian
--
Adrian Aichner <adrian(a)xemacs.org>