Hi,
This is not a serious patch, thus not posted to patches, but is to set
focus on a problem, and probably not a serious one ;-), in the making
of ps-print.
The mule sources are ifeq'ed but before the inclusion of
XEmacs.rules. Thus all el-files are included when building ps-print
without mule. (As it happens this seems to be OK. The files are
compiled.)
On the other hand when XEmacs.rules is included before the ifeq, so
that the files are left out in a none mule build, I found out that
ps-mule is actually needed by ps-print.
Apparently there is some problem in ps-print with the split of
functionality into a mule and a non-mule part.
----------------------------------------------------------------------
"cvs diff" in /usr/local/src/packages/xemacs-packages/ps-print/
Index: Makefile
===================================================================
RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/ps-print/Makefile,v
retrieving revision 1.4
diff -u -r1.4 Makefile
--- Makefile 2002/02/13 01:03:46 1.4
+++ Makefile 2002/04/03 15:36:38
@@ -27,22 +27,22 @@
REQUIRES = text-modes
CATEGORY = standard
-ELCS = lpr.elc ps-print.elc
+ELCS = lpr.elc ps-print.elc ps-mule.elc
-ifeq ($(BUILD_WITHOUT_MULE),)
-ELCS += ps-mule.elc ps-bdf.elc
-endif
-
EXTRA_SOURCES = README ps-print-20.new ps-print-21.new
DATA_FILES = $(wildcard etc/$(PACKAGE)/*.ps)
DATA_DEST = $(PACKAGE)
-include ../../XEmacs.rules
-
GENERATED += custom-load.elc
PRELOADS = -eval "(setq ps-postscript-code-directory
\"./etc/ps-print/\")"
+
+include ../../XEmacs.rules
+
+ifeq ($(BUILD_WITHOUT_MULE),)
+ELCS += ps-bdf.elc
+endif
all:: auto-autoloads.elc $(ELCS) custom-load.elc
----------------------------------------------------------------------
Yours
--
%% Mats
Show replies by date
|--==> "ML" == Mats Lidell <matsl(a)contactor.se> writes:
ML> Hi,
ML> This is not a serious patch, thus not posted to patches, but is to set
ML> focus on a problem, and probably not a serious one ;-), in the making
ML> of ps-print.
Just checked the other packages... ps-print is the only one with this
problem. Phew! No huge sweeping patches. :-)
ML> The mule sources are ifeq'ed but before the inclusion of
ML> XEmacs.rules. Thus all el-files are included when building ps-print
ML> without mule. (As it happens this seems to be OK. The files are
ML> compiled.)
ML> On the other hand when XEmacs.rules is included before the ifeq, so
ML> that the files are left out in a none mule build, I found out that
ML> ps-mule is actually needed by ps-print.
[...]
ML> -ELCS = lpr.elc ps-print.elc
ML> +ELCS = lpr.elc ps-print.elc ps-mule.elc
ML> -ifeq ($(BUILD_WITHOUT_MULE),)
ML> -ELCS += ps-mule.elc ps-bdf.elc
ML> -endif
[...]
ML> +
ML> +include ../../XEmacs.rules
ML> +
ML> +ifeq ($(BUILD_WITHOUT_MULE),)
ML> +ELCS += ps-bdf.elc
ML> +endif
Just wondering, how much trouble would we get into if we were to not
try to make any distinction between Mule and non-Mule? In other
words, include both ps-mule.el and ps-bdf.el in non-Mule builds.
Could somebody with a bit of Mule savvy have a look at that for me and
let me know if it would be OK. Steve T?
Mats, thanks for bringing this up.
--
|---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---|
| XEmacs - It's not just an editor. |
| It's a way of life. |
|------------------------------------<youngs(a)xemacs.org>---|