8:03 a.m.
Hi,
Please evaluate the following four Lisp forms one by one:
(defun hello-world ()
"Hello World")
(hello-world)
(byte-compile 'hello-world)
(hello-world)
I got the string "Hello World" by the second form, but nil by
the fourth form. I am at a loss for words...
10:02 a.m.
>>>> "Katsumi" == Katsumi Yamaoka
<yamaoka(a)jpl.org> writes:
Katsumi> Hi,
Katsumi> Please evaluate the following four Lisp forms one by one:
Katsumi> (defun hello-world ()
Katsumi> "Hello World")
Katsumi> (hello-world)
Katsumi> (byte-compile 'hello-world)
Katsumi> (hello-world)
Katsumi> I got the string "Hello World" by the second form, but nil by
Katsumi> the fourth form. I am at a loss for words...
Hi Katsumi!
I get the same in
(emacs-version)
"XEmacs 21.5 (beta14) \"cassava\" [Lucid] (i586-pc-win32, Mule) of Fri Jun
13 2003 on D5DC120J"
(disassemble 'hello-world)
leads this:
This suggests the byte-compiler takes "Hello World" to be the
docstring, leaving no body for the function.
This of course is in contradiction with the spec
arguments: (NAME ARGLIST [DOCSTRING] BODY...)
where docstring is optional but body is not.
Which is confirmed by
(defun nada)
leading
Wrong number of arguments: defun, 1
I'd say this is a byte-compiler bug.
--
Adrian Aichner
mailto:adrian＠xemacs.org
http://www.xemacs.org/
11:23 a.m.
New subject: [21.5R21.4] Re: byte-compiler bug?
For 21.4 and 21.5. This is safe.
>>>> "KY" == Katsumi Yamaoka
<yamaoka(a)jpl.org> writes:
KY> Please evaluate the following four Lisp forms one by one:
KY> (defun hello-world () "Hello World")
KY> (hello-world)
KY> (byte-compile 'hello-world)
KY> (hello-world)
KY> I got the string "Hello World" by the second form, but nil by
KY> the fourth form. I am at a loss for words...
I really never wanted to learn about the byte compiler....
This should be OK, it turns out that GNU Emacs uses exactly the same
test in that function. Since 1996. :-(
Index: lisp/ChangeLog
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/ChangeLog,v
retrieving revision 1.509
diff -u -U0 -r1.509 ChangeLog
--- lisp/ChangeLog 1 Jun 2003 05:10:19 -0000 1.509
+++ lisp/ChangeLog 17 Jun 2003 10:14:03 -0000
＠＠ -0,0 +1,5 ＠＠
+2003-06-17 Stephen J. Turnbull <stephen(a)xemacs.org>
+
+ * bytecomp.el (byte-compile-lambda): Discard docstring only if it
+ is not also the value of the lambda.
+
Index: lisp/bytecomp.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/bytecomp.el,v
retrieving revision 1.16
diff -u -r1.16 bytecomp.el
--- lisp/bytecomp.el 20 Feb 2003 08:19:29 -0000 1.16
+++ lisp/bytecomp.el 17 Jun 2003 10:14:11 -0000
＠＠ -2453,7 +2453,10 ＠＠
(body (cdr (cdr fun)))
(doc (if (stringp (car body))
(prog1 (car body)
- (setq body (cdr body)))))
+ ;; Discard the doc string
+ ;; only if it is not the only element of the body.
+ (if (cdr body)
+ (setq body (cdr body))))))
(int (assq 'interactive body)))
(dolist (arg arglist)
(cond ((not (symbolp arg))
--
Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Ask not how you can "do" free software business;
ask what your business can "do for" free software.
11:43 a.m.
New subject: [21.5R21.4] Re: byte-compiler bug?
>>>> In <87fzm9uhnq.fsf(a)tleepslib.sk.tsukuba.ac.jp>
>>>> "Stephen J. Turnbull" <stephen(a)xemacs.org> wrote:
Stephen> I really never wanted to learn about the byte compiler....
Stephen> This should be OK, it turns out that GNU Emacs uses exactly
Stephen> the same test in that function. Since 1996. :-(
Thanks. Although I think developers ought to write doc-strings
normally, it is not always necessary for machine originated
functions. Will it be CVS committed?
--
Katsumi Yamaoka <yamaoka(a)jpl.org>
2 p.m.
New subject: [21.5R21.4] Re: byte-compiler bug?
>>>> "KY" == Katsumi Yamaoka
<yamaoka(a)jpl.org> writes:
KY> Will it be CVS committed?
To 21.5, yes. (I just have to figure out why Sunsite won't talk to
the box these changes are on; it's gotta be local config since my
other box works fine.)
To 21.4, ask Vin. My guess is "yes". However, since Vin just
released 21.4.13, it'll probably be weeks before it gets into a
release, and may or may not be committed to CVS until he's ready to do
a release.
--
Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Ask not how you can "do" free software business;
ask what your business can "do for" free software.
2:09 p.m.
New subject: [21.5R21.4] Re: byte-compiler bug?
>>>> In <874r2ouae5.fsf(a)tleepslib.sk.tsukuba.ac.jp>
>>>> "Stephen J. Turnbull" <stephen(a)xemacs.org> wrote:
KY> Will it be CVS committed?
Stephen> To 21.5, yes.
Stephen> To 21.4, ask Vin. My guess is "yes". However, since Vin
Stephen> just released 21.4.13, it'll probably be weeks before it gets
Stephen> into a release, and may or may not be committed to CVS until
Stephen> he's ready to do a release.
Thanks. We are modifying some programs in order to prevent the
problem since it is needed for old XEmacs and Emacs 19 users at
all.:)
--
Katsumi Yamaoka <yamaoka(a)jpl.org>
9 a.m.
New subject: [21.5R21.4] Re: byte-compiler bug?
Hi,
I found another problem which may also be related to the
byte-compiler. Please evaluate the following two programs in
the *scratch* buffer:
(progn
(with-temp-buffer
(funcall
(lambda nil
(make-variable-buffer-local 'foo-bar-baz-1)
(defvar foo-bar-baz-1 nil))))
foo-bar-baz-1)
(progn
(with-temp-buffer
(funcall
(byte-compile
(lambda nil
(make-variable-buffer-local 'foo-bar-baz-2)
(defvar foo-bar-baz-2 nil)))))
foo-bar-baz-2)
You will see the later does not bind the variable for all
buffers. The same thing is in edebug.el:
(make-variable-buffer-local 'edebug-form-data)
(defvar edebug-form-data nil)
Because of this, I often got the following error when I use the
edebug-defun command in a newly created buffer, although
edebug.elc has already been loaded:
Symbol's value as variable is void: edebug-form-data
--
Katsumi Yamaoka <yamaoka(a)jpl.org>
3:36 a.m.
New subject: Byte-compiled defvar doesn't set the default value
NOTE: I changed the subject line to something more appropriate, also
getting rid of the approval of the patch for the previous problem to
avoid confusion.
Katsumi Yamaoka <yamaoka(a)jpl.org> wrote:
I found another problem which may also be related to the
byte-compiler. Please evaluate the following two programs in
the *scratch* buffer:
(progn
(with-temp-buffer
(funcall
(lambda nil
(make-variable-buffer-local 'foo-bar-baz-1)
(defvar foo-bar-baz-1 nil))))
foo-bar-baz-1)
(progn
(with-temp-buffer
(funcall
(byte-compile
(lambda nil
(make-variable-buffer-local 'foo-bar-baz-2)
(defvar foo-bar-baz-2 nil)))))
foo-bar-baz-2)
You will see the later does not bind the variable for all
buffers.
[snip edebug stuff]
This is not due to the byte compiler. Emacs produces (effectively)
identical byte code. What's different is that, when interpreted, the
defvar form does this:
if (NILP (Fdefault_boundp (sym)))
{
struct gcpro gcpro1;
GCPRO1 (val);
val = Feval (val);
Fset_default (sym, val);
UNGCPRO;
}
but when byte-compiled invokes a varset, which does this:
if (!SYMBOL_VALUE_MAGIC_P (old_value) || UNBOUNDP (old_value))
symbol_ptr->value = new_value;
else
Fset (symbol, new_value);
But varset is used for setq too, isn't it? So I'm not sure how to
modify that to fix the problem you've noted without breaking other
stuff.
--
Jerry James
http://www.ittc.ku.edu/~james/
1:26 a.m.
New subject: [A21.4] Re: byte-compiler bug?
APPROVE
"Stephen J. Turnbull" <stephen(a)xemacs.org> writes:
For 21.4 and 21.5. This is safe.
>>>>> "KY" == Katsumi Yamaoka <yamaoka(a)jpl.org> writes:
KY> Please evaluate the following four Lisp forms one by one:
KY> (defun hello-world () "Hello World")
KY> (hello-world)
KY> (byte-compile 'hello-world)
KY> (hello-world)
KY> I got the string "Hello World" by the second form, but nil by
KY> the fourth form. I am at a loss for words...
I really never wanted to learn about the byte compiler....
This should be OK, it turns out that GNU Emacs uses exactly the same
test in that function. Since 1996. :-(
Index: lisp/ChangeLog
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/ChangeLog,v
retrieving revision 1.509
diff -u -U0 -r1.509 ChangeLog
--- lisp/ChangeLog 1 Jun 2003 05:10:19 -0000 1.509
+++ lisp/ChangeLog 17 Jun 2003 10:14:03 -0000
＠＠ -0,0 +1,5 ＠＠
+2003-06-17 Stephen J. Turnbull <stephen(a)xemacs.org>
+
+ * bytecomp.el (byte-compile-lambda): Discard docstring only if it
+ is not also the value of the lambda.
+
Index: lisp/bytecomp.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/bytecomp.el,v
retrieving revision 1.16
diff -u -r1.16 bytecomp.el
--- lisp/bytecomp.el 20 Feb 2003 08:19:29 -0000 1.16
+++ lisp/bytecomp.el 17 Jun 2003 10:14:11 -0000
＠＠ -2453,7 +2453,10 ＠＠
(body (cdr (cdr fun)))
(doc (if (stringp (car body))
(prog1 (car body)
- (setq body (cdr body)))))
+ ;; Discard the doc string
+ ;; only if it is not the only element of the body.
+ (if (cdr body)
+ (setq body (cdr body))))))
(int (assq 'interactive body)))
(dolist (arg arglist)
(cond ((not (symbolp arg))
--
Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Ask not how you can "do" free software business;
ask what your business can "do for" free software.
3:31 a.m.
New subject: [C21.4] Re: byte-compiler bug?
COMMIT 21.4
Vin Shelton <acs(a)xemacs.org> writes:
APPROVE
"Stephen J. Turnbull" <stephen(a)xemacs.org> writes:
> For 21.4 and 21.5. This is safe.
>
>>>>>> "KY" == Katsumi Yamaoka <yamaoka(a)jpl.org>
writes:
>
> KY> Please evaluate the following four Lisp forms one by one:
>
> KY> (defun hello-world () "Hello World")
>
> KY> (hello-world)
>
> KY> (byte-compile 'hello-world)
>
> KY> (hello-world)
>
> KY> I got the string "Hello World" by the second form, but nil by
> KY> the fourth form. I am at a loss for words...
>
> I really never wanted to learn about the byte compiler....
>
> This should be OK, it turns out that GNU Emacs uses exactly the same
> test in that function. Since 1996. :-(
>
> Index: lisp/ChangeLog
> ===================================================================
> RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/ChangeLog,v
> retrieving revision 1.509
> diff -u -U0 -r1.509 ChangeLog
> --- lisp/ChangeLog 1 Jun 2003 05:10:19 -0000 1.509
> +++ lisp/ChangeLog 17 Jun 2003 10:14:03 -0000
> ＠＠ -0,0 +1,5 ＠＠
> +2003-06-17 Stephen J. Turnbull <stephen(a)xemacs.org>
> +
> + * bytecomp.el (byte-compile-lambda): Discard docstring only if it
> + is not also the value of the lambda.
> +
>
> Index: lisp/bytecomp.el
> ===================================================================
> RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/bytecomp.el,v
> retrieving revision 1.16
> diff -u -r1.16 bytecomp.el
> --- lisp/bytecomp.el 20 Feb 2003 08:19:29 -0000 1.16
> +++ lisp/bytecomp.el 17 Jun 2003 10:14:11 -0000
> ＠＠ -2453,7 +2453,10 ＠＠
> (body (cdr (cdr fun)))
> (doc (if (stringp (car body))
> (prog1 (car body)
> - (setq body (cdr body)))))
> + ;; Discard the doc string
> + ;; only if it is not the only element of the body.
> + (if (cdr body)
> + (setq body (cdr body))))))
> (int (assq 'interactive body)))
> (dolist (arg arglist)
> (cond ((not (symbolp arg))
>
>
> --
> Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp
> University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
> Ask not how you can "do" free software business;
> ask what your business can "do for" free software.
10:23 a.m.
New subject: [21.5R21.4] Re: byte-compiler bug?
APPROVE COMMIT 21.5
Index: lisp/ChangeLog
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/ChangeLog,v
retrieving revision 1.509
diff -u -U0 -r1.509 ChangeLog
--- lisp/ChangeLog 1 Jun 2003 05:10:19 -0000 1.509
+++ lisp/ChangeLog 17 Jun 2003 10:14:03 -0000
＠＠ -0,0 +1,5 ＠＠
+2003-06-17 Stephen J. Turnbull <stephen(a)xemacs.org>
+
+ * bytecomp.el (byte-compile-lambda): Discard docstring only if it
+ is not also the value of the lambda.
+
--
Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Ask not how you can "do" free software business;
ask what your business can "do for" free software.
7582
days inactive
7619
days old
10 comments
5 participants
participants (5)
-
Adrian Aichner -
Jerry James -
Katsumi Yamaoka -
Stephen J. Turnbull -
Vin Shelton