Re: NAS related source code error?
- First Post
- Replies
- Stats
-
Go to
- ----- 2024 -----
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2023 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2022 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2013 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2012 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2011 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2010 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2009 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2008 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2007 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2006 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2005 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2004 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2003 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2002 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2001 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2000 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1999 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1998 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
Thank you for this patch. It has been applied to the 21.1 branch of
XEmacs and will appear in XEmacs 21.1.12.
- vin
>>>> On Mon, 24 Jul 2000, ewiles(a)mclean.sterling.com
(Edwin Wiles) said:
Edwin> Folks,
Edwin> First, I don't read this list, so you'll have to reply to me
Edwin> directly.
Edwin> Second, I think this is the first time I've tried compiling
Edwin> XEmacs (I've done Emacs many times, Perl many times, etc...).
Edwin> Third, if this isn't the right place to post this, then there's
Edwin> a hole in the documentation on 'bug' reporting.
Edwin> Version: 21.1.11 - just downloaded today.
Edwin> Problem: LITTLE_ENDIAN is not defined in "src/nas.c".
Edwin> Resolution: The NAS include files define "NAS_LITTLE_ENDIAN" and
Edwin> "NAS_BIG_ENDIAN", not "LITTLE_ENDIAN" and
"BIG_ENDIAN".
Edwin> Fix: Changed "src/nas.c" to use "NAS_*".
Edwin> Patch attached.
Edwin> Hopefully Helpful!
Edwin> Edwin Wiles
Edwin> --
Edwin> Edwin Wiles | Computer Associates | McLean, VA, USA
Edwin> Preferred..: ewiles(a)mclean.sterling.com
Edwin> Alternative: Edwin_Wiles(a)sterling.com
Edwin> "The light at the end of the History Tunnel, is the oncoming train of
events."
Tuesday, 1 August
Tue, 1 Aug
5:37 a.m.
New subject: NAS related source code error?
>>>> "vin" == Vin Shelton <acs(a)xemacs.org>
writes:
vin> Thank you for this patch. It has been applied to the 21.1
vin> branch of XEmacs and will appear in XEmacs 21.1.12.
NOOOOOOoooooooo! (That's not a veto, I'm not on -review.)
>>>> On Mon, 24 Jul 2000, ewiles(a)mclean.sterling.com
(Edwin Wiles) said:
Edwin> Problem: LITTLE_ENDIAN is not defined in "src/nas.c".
Sure it is, in <audio/fileutil.h>, NAS 1.2p5.
Edwin> Resolution: The NAS include files define
Edwin> "NAS_LITTLE_ENDIAN" and "NAS_BIG_ENDIAN", not
Edwin> "LITTLE_ENDIAN" and "BIG_ENDIAN".
Not in 1.2p5. Those headers define only "LITTLE_ENDIAN" and
"BIG_ENDIAN".
Edwin> Fix: Changed "src/nas.c" to use "NAS_*".
Breaking all systems with 1.2p5 or earlier installed. This is true of
Debian Linux (woody), for example.
Please revert this patch and figure out how to do it without breaking
older systems. This can be easily done with
#ifndef NAS_BIG_ENDIAN
#define NAS_BIG_ENDIAN BIG_ENDIAN
#endif
etc after the #includes, but it is probably preferable to fix it so
that modern NAS installations don't have to suffer with the #undef
BIG_ENDIAN breakage. I don't see how to do that simply in the source,
you'll probably have to do it via configure.
--
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Institute of Policy and Planning Sciences Tel/fax: +81 (298) 53-5091
_________________ _________________ _________________ _________________
What are those straight lines for? "XEmacs rules."
8879
days inactive
8879
days old
1 comments
2 participants
tags (0)
participants (2)
-
Stephen J. Turnbull -
Vin Shelton