9:39 a.m.
Hi Steve,
here it is.
Please take it from here.
I have not tested this.
Best regards,
Adrian
xemacs-packages/calc/ChangeLog addition:
2001-12-18 Adrian Aichner <adrian(a)xemacs.org>
* calc.el (calc): window and frame width and height fixes by Alan
Wehmann, as posted on comp.emacs.xemacs.
* calc.el (calc-quit): Ditto.
* calc.el (calc-trail-here): Ditto.
packages Patch (cvs -f -z3 -q diff -u xemacs-packages/calc/calc.el):
Index: xemacs-packages/calc/calc.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/calc/calc.el,v
retrieving revision 1.7
diff -u -r1.7 calc.el
--- xemacs-packages/calc/calc.el 2001/05/14 06:14:29 1.7
+++ xemacs-packages/calc/calc.el 2001/12/18 09:36:21
＠＠ -1199,7 +1199,7 ＠＠
(save-excursion
(set-buffer (calc-trail-buffer))
(and calc-display-trail
- (= (window-width) (frame-width))
+ (= (window-width) (1+ frame-width))
(calc-trail-display 1 t)))
(message "Welcome to the GNU Emacs Calculator! Press `?' or `h' for help,
`q' to quit.")
(run-hooks 'calc-start-hook)
＠＠ -1265,7 +1265,7 ＠＠
(delete-windows-on (calc-trail-buffer))
(if (and win
(< (window-height win) (1- (frame-height)))
- (= (window-width win) (frame-width)) ; avoid calc-keypad
+ (= (window-width win) (1+ frame-width)) ; avoid calc-keypad
(not (get-buffer-window "*Calc Keypad*")))
(setq calc-window-height (- (window-height win) 2)))
(if calc-was-split
＠＠ -1541,7 +1541,7 ＠＠
(if win
(progn
(calc-cursor-stack-index 0)
- (vertical-motion (- 2 (window-height win)))
+ (vertical-motion (- 3 (window-height win)))
(set-window-start win (point)))))
(calc-cursor-stack-index 0)
(if (looking-at " *\\.$")
＠＠ -1901,7 +1901,7 ＠＠
(if win
(save-excursion
(forward-line (/ (window-height win) 2))
- (forward-line (- 1 (window-height win)))
+ (forward-line (- 2 (window-height win)))
(set-window-start win (point))
(set-window-point win (+ calc-trail-pointer 4))
(set-buffer calc-main-buffer)
--
Adrian Aichner
mailto:adrian＠xemacs.org
http://www.xemacs.org/
2:58 p.m.
|--==> "APA" == Adrian Aichner <aichner(a)ecf.teradyne.com> writes:
APA> Hi Steve,
APA> here it is.
APA> Please take it from here.
Thanks, Adrian. Yep, no problem.
--
|---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---|
| XEmacs - It's not just an editor. |
| It's a way of life. |
|------------------------------------<youngs(a)xemacs.org>---|
9:21 p.m.
|--==> "APA" == Adrian Aichner <aichner(a)ecf.teradyne.com> writes:
APA> 2001-12-18 Adrian Aichner <adrian(a)xemacs.org>
APA> * calc.el (calc): window and frame width and height fixes by Alan
APA> Wehmann, as posted on comp.emacs.xemacs.
APA> * calc.el (calc-quit): Ditto.
APA> * calc.el (calc-trail-here): Ditto.
Just out of curiosity, what is it that this is supposed to fix? For
me, calc works fine without this patch. And with this patch, calc
dies on startup, complaining about a void variable 'frame-width'.
Adrian, I don't have access to Usenet so could I ask you to forward
this to the patch's author, if you think we should take this further.
Thanks.
APA> packages Patch (cvs -f -z3 -q diff -u xemacs-packages/calc/calc.el):
APA> Index: xemacs-packages/calc/calc.el
APA> ===================================================================
APA> RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/calc/calc.el,v
APA> retrieving revision 1.7
APA> diff -u -r1.7 calc.el
APA> --- xemacs-packages/calc/calc.el 2001/05/14 06:14:29 1.7
APA> +++ xemacs-packages/calc/calc.el 2001/12/18 09:36:21
APA> ＠＠ -1199,7 +1199,7 ＠＠
APA> (save-excursion
APA> (set-buffer (calc-trail-buffer))
APA> (and calc-display-trail
APA> - (= (window-width) (frame-width))
APA> + (= (window-width) (1+ frame-width))
APA> (calc-trail-display 1 t)))
APA> (message "Welcome to the GNU Emacs Calculator! Press `?' or `h'
for help, `q' to quit.")
APA> (run-hooks 'calc-start-hook)
APA> ＠＠ -1265,7 +1265,7 ＠＠
APA> (delete-windows-on (calc-trail-buffer))
APA> (if (and win
APA> (< (window-height win) (1- (frame-height)))
APA> - (= (window-width win) (frame-width)) ; avoid calc-keypad
APA> + (= (window-width win) (1+ frame-width)) ; avoid calc-keypad
APA> (not (get-buffer-window "*Calc Keypad*")))
APA> (setq calc-window-height (- (window-height win) 2)))
APA> (if calc-was-split
APA> ＠＠ -1541,7 +1541,7 ＠＠
APA> (if win
APA> (progn
APA> (calc-cursor-stack-index 0)
APA> - (vertical-motion (- 2 (window-height win)))
APA> + (vertical-motion (- 3 (window-height win)))
APA> (set-window-start win (point)))))
APA> (calc-cursor-stack-index 0)
APA> (if (looking-at " *\\.$")
APA> ＠＠ -1901,7 +1901,7 ＠＠
APA> (if win
APA> (save-excursion
APA> (forward-line (/ (window-height win) 2))
APA> - (forward-line (- 1 (window-height win)))
APA> + (forward-line (- 2 (window-height win)))
APA> (set-window-start win (point))
APA> (set-window-point win (+ calc-trail-pointer 4))
APA> (set-buffer calc-main-buffer)
--
|---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---|
| XEmacs - It's not just an editor. |
| It's a way of life. |
|------------------------------------<youngs(a)xemacs.org>---|
9:45 p.m.
>>>> "SY" == Steve Youngs
<youngs(a)xemacs.org> writes:
SY> |--==> "APA" == Adrian Aichner <aichner(a)ecf.teradyne.com>
writes:
APA> 2001-12-18 Adrian Aichner <adrian(a)xemacs.org>
APA> * calc.el (calc): window and frame width and height fixes by Alan
APA> Wehmann, as posted on comp.emacs.xemacs.
APA> * calc.el (calc-quit): Ditto.
APA> * calc.el (calc-trail-here): Ditto.
SY> Just out of curiosity, what is it that this is supposed to
SY> fix? For me, calc works fine without this patch. And with
SY> this patch, calc dies on startup, complaining about a void
SY> variable 'frame-width'.
SY> Adrian, I don't have access to Usenet so could I ask you to
SY> forward this to the patch's author, if you think we should
SY> take this further.
Hello Alan,
could you please comment on your original patch?
What is the breakage you found without the patch?
To what extent have you tested your patch?
Thanks!
Steve, I don't have any further info than what I forwarded under
From: Adrian.Aichner(a)t-online.de (Adrian Aichner)
Subject: [comp.emacs.xemacs] Calc fixes (for cygwin XEmacs)
To: XEmacs Beta List <xemacs-beta(a)xemacs.org>
Date: 17 Dec 2001 21:57:04 +0100
Organization: The XEmacs Project
Message-ID: <itb5zhsv.fsf(a)mailto.t-online.de>
Best regards,
Adrian
SY> Thanks.
APA> packages Patch (cvs -f -z3 -q diff -u xemacs-packages/calc/calc.el):
APA> Index: xemacs-packages/calc/calc.el
APA> ===================================================================
APA> RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/calc/calc.el,v
APA> retrieving revision 1.7
APA> diff -u -r1.7 calc.el
APA> --- xemacs-packages/calc/calc.el 2001/05/14 06:14:29 1.7
APA> +++ xemacs-packages/calc/calc.el 2001/12/18 09:36:21
APA> ＠＠ -1199,7 +1199,7 ＠＠
APA> (save-excursion
APA> (set-buffer (calc-trail-buffer))
APA> (and calc-display-trail
APA> - (= (window-width) (frame-width))
APA> + (= (window-width) (1+ frame-width))
APA> (calc-trail-display 1 t)))
APA> (message "Welcome to the GNU Emacs Calculator! Press `?' or `h'
for help, `q' to quit.")
APA> (run-hooks 'calc-start-hook)
APA> ＠＠ -1265,7 +1265,7 ＠＠
APA> (delete-windows-on (calc-trail-buffer))
APA> (if (and win
APA> (< (window-height win) (1- (frame-height)))
APA> - (= (window-width win) (frame-width)) ; avoid calc-keypad
APA> + (= (window-width win) (1+ frame-width)) ; avoid calc-keypad
APA> (not (get-buffer-window "*Calc Keypad*")))
APA> (setq calc-window-height (- (window-height win) 2)))
APA> (if calc-was-split
APA> ＠＠ -1541,7 +1541,7 ＠＠
APA> (if win
APA> (progn
APA> (calc-cursor-stack-index 0)
APA> - (vertical-motion (- 2 (window-height win)))
APA> + (vertical-motion (- 3 (window-height win)))
APA> (set-window-start win (point)))))
APA> (calc-cursor-stack-index 0)
APA> (if (looking-at " *\\.$")
APA> ＠＠ -1901,7 +1901,7 ＠＠
APA> (if win
APA> (save-excursion
APA> (forward-line (/ (window-height win) 2))
APA> - (forward-line (- 1 (window-height win)))
APA> + (forward-line (- 2 (window-height win)))
APA> (set-window-start win (point))
APA> (set-window-point win (+ calc-trail-pointer 4))
APA> (set-buffer calc-main-buffer)
SY> --
SY> |---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---|
SY> | XEmacs - It's not just an editor. |
SY> | It's a way of life. |
SY> |------------------------------------<youngs(a)xemacs.org>---|
--
Adrian Aichner
mailto:adrian＠xemacs.org
http://www.xemacs.org/
10:04 p.m.
|--==> "APA" == Adrian Aichner <Adrian.Aichner(a)t-online.de> writes:
APA> Hello Alan,
APA> could you please comment on your original patch?
APA> What is the breakage you found without the patch?
APA> To what extent have you tested your patch?
APA> Thanks!
APA> Steve, I don't have any further info than what I forwarded under
No problem. Now I know Alan's email address. :-)
Thanks, Adrian, I appreciate your help.
--
|---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---|
| XEmacs - It's not just an editor. |
| It's a way of life. |
|------------------------------------<youngs(a)xemacs.org>---|
8377
days inactive
8377
days old
4 comments
3 participants
participants (3)
-
Adrian Aichner -
Adrian Aichner -
Steve Youngs