8:20 a.m.
I sent three patches to xemacs-patches a week ago and haven't heard
anything, either pro or con, about them. Should I take this silence as
approval and commit them? The patches are
Native Windows message handling bug
<http://list-archive.xemacs.org/xemacs-patches/200207/msg00000.html>
Don't delete process output in call-process-region
<http://list-archive.xemacs.org/xemacs-patches/200207/msg00002.html>
shell-command-on-region deletes too much
<http://list-archive.xemacs.org/xemacs-patches/200207/msg00003.html>
At least the first seems like it should be applied since it fixes a long
standing problem in the Windows native version (it has no effect anywhere
else). The other two look to me like they fix real bugs (for example
<http://list-archive.xemacs.org/xemacs-beta/200206/msg00574.html>) too.
Mike
9:36 a.m.
>>>> "Mike" == Mike Alexander
<mta(a)arbortext.com> writes:
Mike> I sent three patches to xemacs-patches a week ago and
Mike> haven't heard anything, either pro or con, about them.
Mike> Should I take this silence as approval and commit them?
No, sending a query is the right thing to do.
Thanks for the patches.
--
Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
My nostalgia for Icon makes me forget about any of the bad things. I don't
have much nostalgia for Perl, so its faults I remember. Scott Gilbert c.l.py
4:49 p.m.
They are in my Inbox, I would like to know whether these are recommended
for 21.4 also?
Thanks
andy
At 03:20 AM 7/8/2002 -0400, Mike Alexander wrote:
I sent three patches to xemacs-patches a week ago and haven't
heard
anything, either pro or con, about them. Should I take this silence as
approval and commit them? The patches are
Native Windows message handling bug
<http://list-archive.xemacs.org/xemacs-patches/200207/msg00000.html>
Don't delete process output in call-process-region
<http://list-archive.xemacs.org/xemacs-patches/200207/msg00002.html>
shell-command-on-region deletes too much
<http://list-archive.xemacs.org/xemacs-patches/200207/msg00003.html>
At least the first seems like it should be applied since it fixes a long
standing problem in the Windows native version (it has no effect anywhere
else). The other two look to me like they fix real bugs (for example
<http://list-archive.xemacs.org/xemacs-beta/200206/msg00574.html>) too.
Mike
6:17 p.m.
>>>> "Andy" == Andy Piper <andyp(a)bea.com>
writes:
Andy> They are in my Inbox, I would like to know whether these are
Andy> recommended for 21.4 also?
This one doesn't apply (it needs Ben's process.el changes from 21.5, I
suspect):
Don't delete process output in call-process-region
<http://list-archive.xemacs.org/xemacs-patches/200207/msg00002.html>
This one is probably irrelevant without them but can't hurt, it's in
21.4 mainline already:
shell-command-on-region deletes too much
<http://list-archive.xemacs.org/xemacs-patches/200207/msg00003.html>
I don't know anything about the Message passing thing.
--
Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
My nostalgia for Icon makes me forget about any of the bad things. I don't
have much nostalgia for Perl, so its faults I remember. Scott Gilbert c.l.py
11:36 p.m.
--On Tuesday, July 09, 2002 2:17 AM +0900 "Stephen J. Turnbull"
<stephen(a)xemacs.org> wrote:
>>>>> "Andy" == Andy Piper
<andyp(a)bea.com> writes:
Andy> They are in my Inbox, I would like to know whether these are
Andy> recommended for 21.4 also?
This one doesn't apply (it needs Ben's process.el changes from 21.5, I
suspect):
> Don't delete process output in call-process-region
> <http://list-archive.xemacs.org/xemacs-patches/200207/msg00002.html>
This one is probably irrelevant without them but can't hurt, it's in
21.4 mainline already:
> shell-command-on-region deletes too much
> <http://list-archive.xemacs.org/xemacs-patches/200207/msg00003.html>
I don't know anything about the Message passing thing.
The other patch to event-msw.c should go in 21.4, but it will probably
need to be reworked slightly since the code around there has changed
recently. Fixing this problem in 21.4 would be a very good idea since it
is a minor but annoying bug.
Mike
11:48 p.m.
At 06:36 PM 7/8/2002 -0400, Mike Alexander wrote:
>>shell-command-on-region deletes too much
>><http://list-archive.xemacs.org/xemacs-patches/200207/msg00003.html>
>
>I don't know anything about the Message passing thing.
The other patch to event-msw.c should go in 21.4, but it will probably
need to be reworked slightly since the code around there has changed
recently. Fixing this problem in 21.4 would be a very good idea since it
is a minor but annoying bug.
Right, agreed. It should go in.
andy
1:38 a.m.
You've probably seen my response to your patches already...
|--==> "MA" == Mike Alexander <mta(a)arbortext.com> writes:
MA> I sent three patches to xemacs-patches a week ago and haven't heard
MA> anything, either pro or con, about them. Should I take this silence
MA> as approval and commit them? The patches are
MA> Native Windows message handling bug
MA> <http://list-archive.xemacs.org/xemacs-patches/200207/msg00000.html>
I don't do washing and ironing, and I don't do no stinkin windows
either.:-) Reading between the lines, I didn't look at it. Perhaps
Andy can.
MA> Don't delete process output in call-process-region
MA> <http://list-archive.xemacs.org/xemacs-patches/200207/msg00002.html>
MA> shell-command-on-region deletes too much
MA> <http://list-archive.xemacs.org/xemacs-patches/200207/msg00003.html>
These two look good, are approved for 21.5, and you can commit them
there. Thanks again for your patches.
--
|---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---|
| XEmacs - It's not just an editor. |
| It's a way of life. |
|------------------------------------<youngs(a)xemacs.org>---|
8172
days inactive
8173
days old
6 comments
4 participants
participants (4)
-
Andy Piper -
Mike Alexander -
Stephen J. Turnbull -
Steve Youngs