Oscar Figueiredo <Oscar.Figueiredo(a)di.epfl.ch> writes:
>>>>> "Robert" == Robert Pluim
<rpluim(a)bigfoot.com> writes:
Robert> Hrvoje Niksic writes:
>> Oscar Figueiredo <Oscar.Figueiredo(a)di.epfl.ch> writes:
>>
>> > *** IMPORTANT NOTE ***
>> > Due to the function renaming, this patch introduces an
incompatible
>> > change that breaks the packages using the current LDAP API, most
>> > notably EUDC and W3.
>>
>> Renaming doesn't necessarily entail breaking backward
compatibility.
>> If you want to be kind to your users, define functions with old
names
>> that do nothing except call the new functions.
Robert> Wouldn't define-{obsolete,compatible}-function-alias be better
here?
Robert> Or are they intended only for 'core' emacs functions?
Of course I've been concerned by this problem. But I don't know what to
do for the particular case of ldap-search. Currently ldap-search is the
name of the high-level search function (vs. ldap-search-internal which is
the low-level function). But according to the recent discussion on the
subject, what we want is the low-level function to be called ldap-search
and the high-level one called something else (my patch proposes
ldap-search-entries). In this particular case I don't know how to rename
backward compatible. That's the reason why I didn't provide
compatibility aliases at all, compatibility will be broken anyway... :-((
I am not satisfied by this but I've seen no workaround. I don't know how
many packages are currently using the LDAP API. I know of two: EUDC
which I maintain myself and W3. As I said, I can provide a compatible
version of EUDC as soon as necessary and I guess Bill is responsive
enough these days to do the same.
Yup, if this gets approved, I'll hack up url-ldap.el to deal with it. I'll
try to make it work with both interfaces if I can find a nice clean way.
-bp