11:10 a.m.
Martin Buchholz <martin(a)xemacs.org> writes:
No, we should not trust the output of `esd-config --libs`. We
should
be paranoid and test it, as my pseudocode non-working esd config patch
tries to do.
Maybe we should, but I really don't like where this going. What is
next, we check for every single header file we include?
Potato is not released yet. Let's try not working around other peoples
bugs when they still can be fixed.
Jan> Fix your setup. Or even better file a bug with your
Jan> distribution/vendor/sys-admin. Unfortunately configure failures are
Jan> always very indirect :-(
I disagree. The esd-config utility is shipped with the runtime
package, not the development package, which need not be installed.
Redhat 6.0:
urysohn:~> rpm -qf `which esd-config`
esound-devel-0.2.12-4
Are there any other distributions which get this wrong? In a released version?
Jan
11:45 a.m.
New subject: Configure needs to be picker about Enheavied Sound Demon
>>>> "Jan" == Jan Vroonhof
<vroonhof(a)math.ethz.ch> writes:
Jan> Martin Buchholz <martin(a)xemacs.org> writes:
> No, we should not trust the output of `esd-config --libs`. We
> should be paranoid and test it, as my pseudocode non-working
> esd config patch tries to do.
Jan> Maybe we should, but I really don't like where this
Jan> going. What is next, we check for every single header file we
Jan> include?
Yes. And we should also include code to do checks like
(rpm -qf `which esd-config` || dpkg -S esd-config) | grep dev
which if negative sends a bitchy memo to the relevant distribution
about it, From: Jan, of course ;-).
Seriously, I side with Jan, even though this bug bit me. What's the
point of having a utility like esd-config if you can't trust it? We
should take advantage of these utilities where they are available, and
encourage the distributions to use them in a way which is consistent
with the developers' intent.
The Enlightment people would like to avoid being the next Xaw3d---
let's encourage them. It would be nice if esd-config actually
verified the configuration it's reporting---maybe we should suggest an
option for that?, but it wouldn't be necessary if Debian did it right.
Jan> Potato is not released yet. Let's try not working around
Jan> other peoples bugs when they still can be fixed.
It's not like (at 4700-some and counting) the Debian people have an
aversion to creating packages.
--
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Institute of Policy and Planning Sciences Tel/fax: +81 (298) 53-5091
_________________ _________________ _________________ _________________
What are those straight lines for? "XEmacs rules."
11:49 a.m.
New subject: Configure needs to be picker about Enheavied Sound Demon
>>>> "Jan" == Jan Vroonhof
<vroonhof(a)math.ethz.ch> writes:
Jan> Martin Buchholz <martin(a)xemacs.org> writes:
> No, we should not trust the output of `esd-config --libs`. We
should
> be paranoid and test it, as my pseudocode non-working esd config patch
> tries to do.
Jan> Maybe we should, but I really don't like where this going. What is
Jan> next, we check for every single header file we include?
Jan> Potato is not released yet. Let's try not working around other peoples
Jan> bugs when they still can be fixed.
Sorry. You're too late.
1999-12-09 Martin Buchholz <martin(a)xemacs.org>
* configure.in: Clean up sound support.
- variable `old_nas' was used but never set.
- change `with_esd' to `with_esd_sound' for consistency.
- Don't trust the output of `esd-config --libs`; test it.
- Add `esd-config --cflags` to c_switch_site.
- Die if ESD sound requested, but not available.
- ESD is not dependent on X, therefore use LIBS, not libs_x.
--- configure.in 1999/12/08 07:43:35 1.111.2.53
+++ configure.in 1999/12/09 11:46:37
＠＠ -617,8 +617,8 ＠＠
nas ) with_nas_sound=yes ;;
nonas ) with_nas_sound=no ;;
- esd ) with_esd=yes ;;
- noesd ) with_esd=no ;;
+ esd ) with_esd_sound=yes ;;
+ noesd ) with_esd_sound=no ;;
* ) bogus_sound=yes ;;
esac
＠＠ -631,7 +631,7 ＠＠
elif test -n "$new_sdefault" ; then
with_native_sound=$new_sdefault
with_nas_sound=$new_sdefault
- with_esd=$new_sdefault
+ with_esd_sound=$new_sdefault
new_sdefault= # reset this
fi
sound_notfirst=true
＠＠ -3476,29 +3476,34 ＠＠
XE_PREPEND(-laudio, libs_x)
dnl If the nas library does not contain the error jump point,
dnl then we force safer behavior.
- AC_EGREP_HEADER(AuXtErrorJump,audio/Xtutil.h,,[AC_DEFINE(NAS_NO_ERROR_JUMP)])
+ AC_EGREP_HEADER(AuXtErrorJump,audio/Xtutil.h,,[old_nas=yes;
AC_DEFINE(NAS_NO_ERROR_JUMP)])
fi
+dnl ESD Sound support
+if test "$with_esd_sound" != "no"; then
AC_CHECK_PROG(have_esd_config, esd-config, yes, no)
-if test -z "$with_esd"; then
- with_esd=$have_esd_config
+ if test "$have_esd_config" = "yes"; then
+ save_c_switch_site="$c_switch_site" save_LIBS="$LIBS"
+ XE_APPEND(`esd-config --cflags`, c_switch_site)
+ XE_PREPEND(`esd-config --libs`, LIBS)
+ AC_CHECK_FUNC(esd_play_stream,
+ have_esd_sound=yes,
+ c_switch_site="$save_c_switch_site" LIBS="$save_LIBS")
fi
-if test "$with_esd" = "yes"; then
- if test "$have_esd_config" = "no"; then
- echo "*** esd-config was not found in your PATH. Disabling esd support."
- with_esd=no
- else
- AC_DEFINE(HAVE_ESD_SOUND)
+ if test "$have_esd_sound" = "yes"; then
+ with_esd_sound=yes
need_miscplay=yes
XE_ADD_OBJS(esd.o)
- XE_PREPEND(`esd-config --libs`, libs_x)
+ AC_DEFINE(HAVE_ESD_SOUND)
+ else
+ test "$with_esd_sound" = "yes" && \
+ XE_DIE("Required ESD sound support cannot be provided.")
+ with_esd_sound=no
fi
fi
-if test "$need_miscplay" = "yes"; then
- XE_ADD_OBJS(miscplay.o)
-fi
+test "$need_miscplay" = "yes" && XE_ADD_OBJS(miscplay.o)
dnl ---------------------
dnl TTY-dependent options
＠＠ -4175,10 +4180,11 ＠＠
test "$with_jpeg" = yes && echo " Compiling in support for JPEG
image handling."
test "$with_tiff" = yes && echo " Compiling in support for TIFF
image handling."
test "$with_xface" = yes && echo " Compiling in support for
X-Face message headers."
+
test "$with_native_sound" = yes && echo " Compiling in native
sound support."
test "$with_nas_sound" = yes && echo " Compiling in network sound
(NAS) support."
test "$old_nas" = yes && echo " nas library lacks error
trapping, will play synchronously."
-test "$with_esd" = yes && echo " Compiling in support for
Enlightened Sound Daemon."
+test "$with_esd_sound" = yes && echo " Compiling in support
for Enlightened Sound Daemon (ESD)."
test "$with_database_berkdb" = yes && echo " Compiling in support
for Berkeley DB."
test "$with_database_dbm" = yes && echo " Compiling in support
for DBM."
12:06 p.m.
New subject: Configure needs to be picker about Enheavied Sound Demon
On Thu, Dec 09, 1999 at 03:49:20AM -0800, Martin Buchholz wrote:
Sorry. You're too late.
And no matter what, I tend to think that a lot of paranoia at
configure time is a good thing. "configure;make" should never crash
because of missing libraries or includes (modulo well-known and
required ISO C/POSIX/system ones).
OG.
9116
days inactive
9116
days old
3 comments
4 participants
participants (4)
-
Jan Vroonhof -
Martin Buchholz -
Olivier Galibert -
Stephen J. Turnbull