yoshiki, you made a change of 2000-11-07 to event-stream.c, commented:
* event-stream.c (execute_command_event): Preserve current_events
and the like when event is misc-user-event.
Inhibit quit during the call to maybe_echo_keys.
My patch "Fix C-x @ h <scrollbar-drag> a crash",
<87ofzthdgr.fsf(a)sodan.org>
unfortunately, this causes problems because [this-command-keys] returns bogus
values after a misc-user-event. to see the problem, do Help->About XEmacs...
and click on any of the hyperlinks with button1.
part of your change looks like this:
/* Emacs 18 doesn't unconditionally clear the echoed keystrokes,
so we don't either */
- reset_this_command_keys (make_console (con), 0);
+ if (XEVENT (event)->event_type != misc_user_event)
+ reset_this_command_keys (make_console (con), 0);
commenting this out fixes the problem.
however, i have absolutely no idea if this interferes with the original patch.
yoshiki, it's *extremely* important when you modify code as subtle as the
event-stream code that you comment exactly why you did it. instead, your only
comment is
- reset_current_events (command_builder);
+ /* To fix C-x @ h <scrollbar-drag> x crash. */
+ if (XEVENT (event)->event_type != misc_user_event)
+ reset_current_events (command_builder);
which gives no information as to why you added this check.
could you please explain what's going on here?
--
ben
I'm sometimes slow in getting around to reading my mail, so if you
want to reach me faster, call 520-661-6661.
See
http://www.666.com/ben/chronic-pain/ for the hell I've been
through.