[discussion moved to xemacs-beta]
Simon Josefsson <jas(a)extundo.com> writes:
(These are generic comments, I haven't really looked at the
patch.)
FWIW my feelings are that having XEmacs internal stuff in (supposedly)
externally maintained files (browse-url.el) is less than perfect.
(Synching the file with the external source becomes a pain, someone
need to look over the XEmacs specific and decide that they indeed are
XEmacs specific and that they are still valid even after the other
changes. This review has to be done every time the file is synched.
There are more fun things to do..)
But I wouldn't have anything against putting this in a new file,
e.g. xemacs-url.el, in the mail-lib package, since I agree it may be
easier to maintain this in a package than in the core.
So assuming the patch is good (I didn't look at it, sorry) and that it
doesn't _have_ to be in browse-url.el but just in any package (and I
guess mail-lib would be a suitable place), MHO is to move it into a
mail-lib/xemacs-url.el.
Well the patch is more or less a rip from menubar-items.el from the
core, wrapped in a (featurep 'xemacs) so it shouldn't be a problem
moving this to a file of it's own.
Following the convention in some other packages I think it should be
mail-lib/browse-url-xemacs.el
Steve it's your call.
/torkel