12:59 a.m.
The Python electric deleting feature is totally broken wrt
`delete-key-deletes-forward'. I have `delete-key-deletes-forward',
but my backspace key generates delete, and I have no backspace key on
my keyboard. The standard XEmacs way of recognizing this can look
like this:
(defsubst delete-forward-p ()
(and delete-key-deletes-forward
(or (not (eq (device-type) 'x))
(x-keysym-on-keyboard-sans-modifiers-p 'backspace))))
This is hard to explain and harder to understand, but that's what
compliant code has to do in order to respect the current
`delete-key-deletes-forward' mess.
1:51 a.m.
>>>> "Hrvoje" == Hrvoje Niksic
<hniksic(a)srce.hr> writes:
Hrvoje> The standard XEmacs way of recognizing this can
Hrvoje> look like this:
Somewhere along the way (possibly b/w XEmacs 20 and 21, possibly after
I unsub'd from the list ;-) the blessed way of doing this changed. I
made the change in CC Mode, but never made it in python-mode. See the
attached patch.
Thanks for helping be uncover a bug in my Exceed setup, and Hrvoje,
it's good to see you hacking Python! :-)
If this patch works for you, I'll check it in and do a new release.
-Barry
-------------------- snip snip --------------------
Index: python-mode.el
===================================================================
RCS file: /projects/cvsroot/python/dist/src/Misc/python-mode.el,v
retrieving revision 3.91
diff -c -r3.91 python-mode.el
*** python-mode.el 1999/01/09 17:22:38 3.91
--- python-mode.el 1999/01/15 01:41:57
***************
*** 1519,1528 ****
\\[universal-argument] (programmatically, argument ARG) specifies the
number of characters to delete (default is 1)."
(interactive "*p")
! (if (and (boundp 'delete-key-deletes-forward)
! delete-key-deletes-forward)
(funcall py-delete-function arg)
- ;; else
(py-electric-backspace arg)))
;; required for pending-del and delsel modes
--- 1519,1529 ----
\\[universal-argument] (programmatically, argument ARG) specifies the
number of characters to delete (default is 1)."
(interactive "*p")
! (if (or (and (fboundp 'delete-forward-p) ;XEmacs 21
! (delete-forward-p))
! (and (boundp 'delete-key-deletes-forward) ;XEmacs 20
! delete-key-deletes-forward))
(funcall py-delete-function arg)
(py-electric-backspace arg)))
;; required for pending-del and delsel modes
1:54 p.m.
>>>> "BAW" == Barry A Warsaw
<bwarsaw(a)cnri.reston.va.us> writes:
BAW> --- 1519,1529 ----
BAW> \\[universal-argument] (programmatically, argument ARG) specifies the
BAW> number of characters to delete (default is 1)."
BAW> (interactive "*p")
BAW> ! (if (or (and (fboundp 'delete-forward-p) ;XEmacs 21
BAW> ! (delete-forward-p))
BAW> ! (and (boundp 'delete-key-deletes-forward) ;XEmacs 20
BAW> ! delete-key-deletes-forward))
BAW> (funcall py-delete-function arg)
BAW> (py-electric-backspace arg)))
IIRC, I was the author of that delete-forward-p defsubst. But I won't
bless it as the officially sanctioned way to do this. It was
originally written only for use in the file in which it is found. I
simply haven't done the requisite Deep Thought to figure out what the
Right Way is.
Perhaps Gary would like to bless something?
Martin
6:31 p.m.
>>>> "MB" == Martin Buchholz
<martin(a)xemacs.org> writes:
MB> IIRC, I was the author of that delete-forward-p defsubst. But
MB> I won't bless it as the officially sanctioned way to do this.
MB> It was originally written only for use in the file in which it
MB> is found. I simply haven't done the requisite Deep Thought to
MB> figure out what the Right Way is.
MB> Perhaps Gary would like to bless something?
Please someone do. I'll support whatever blessing you guys come up
with, but I'd rather change it once and forget about it. :-)
-Barry
12:10 p.m.
Hrvoje Niksic wrote:
The Python electric deleting feature is totally broken wrt
`delete-key-deletes-forward'. I have `delete-key-deletes-forward',
but my backspace key generates delete, and I have no backspace key on
my keyboard.
If your backspace key generates delete, and you have no backspace key
on your keyboard (by which I presume that you mean that no key
generates the Backspace keysym), isn't setting
delete-key-deletes-forward to t a bad idea?
[OK, having the backspace key generate Delete instead of Backspace is
a bad idea in itself, but we should probably deal with it as best as
we can.]
If the problem is with t being the default, then maybe the default
should be changed from t to something which checks the value of
(x-keysym-on-keyboard-p 'backspace) under X.
--
Glynn Clements <glynn(a)sensei.co.uk>
9253
days inactive
9255
days old
4 comments
4 participants
participants (4)
-
Barry A. Warsaw -
Glynn Clements -
Hrvoje Niksic -
Martin Buchholz