10:47 a.m.
Hi,
I stumbled on this code fragment with keymaps in GNU Emacs lisp and I
wonder how it should be implemented properly. As Googling didn't
answer this I turned to the list.
Gnu version:
(use-local-map (append (make-sparse-keymap) (current-local-map)))
As I get it keymaps are objects in XEmacs so appending them doesn't
work. GNU Emacs also have functions for dealing with keymaps so even
there maybe appending keymaps isn't the best thing!? Maybe use
inheritance there as well?
Is this the proper XEmacs implementation of the code above?
(use-local-map (let ((map (make-sparse-keymap)))
(set-keymap-parent map (current-local-map))
map))
Finally - Does this code make sense?
Yours
--
%% Mats
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
12:35 a.m.
Mats Lidell writes:
Gnu version:
(use-local-map (append (make-sparse-keymap) (current-local-map)))
**gag**
As I get it keymaps are objects in XEmacs so appending them
doesn't
work.
Correct.
GNU Emacs also have functions for dealing with keymaps so even
there maybe appending keymaps isn't the best thing!? Maybe use
inheritance there as well?
Dunno. You'd have to ask on emacs-devel. I don't know how they
implement inheritance. Shared list structure may be how they do it.
Is this the proper XEmacs implementation of the code above?
(use-local-map (let ((map (make-sparse-keymap)))
(set-keymap-parent map (current-local-map))
map))
It should work in GNU Emacs as well.
BTW, that `let' shouldn't be necessary. :-/ (But it is.) I really
don't understand why these APIs return the parent(s) (which
necessarily were passed into the code, and so are conveniently
available to the calling code), rather than the new keymap (which
might be created here). Then you could do:
(use-local-map
(set-keymap-parent (make-sparse-keymap) (current-local-map)))
Isn't that ever so much nicer?
Finally - Does this code make sense?
Looks good to me.
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
12:40 a.m.
>>>> Stephen J Turnbull <stephen(a)xemacs.org> writes:
Dunno. You'd have to ask on emacs-devel. I don't know how
they
implement inheritance. Shared list structure may be how they do it.
Well, I don't need to know how it is implemented, just what it is
supposed to mean. :-) I assume it is inheritance.
[...]
(use-local-map
(set-keymap-parent (make-sparse-keymap) (current-local-map)))
Isn't that ever so much nicer?
Yes. I thought it was a bit strange too. After the new keymap is
created I would assume that the parent keymap is the last thing you
would want to access.
Yours
--
%% Mats
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
4:35 a.m.
Mats Lidell writes:
>>>>> Stephen J Turnbull <stephen(a)xemacs.org>
writes:
> Dunno. You'd have to ask on emacs-devel. I don't know how they
> implement inheritance. Shared list structure may be how they do it.
Well, I don't need to know how it is implemented, just what it is
supposed to mean. :-) I assume it is inheritance.
Well, if it's implemented by shared list structure, then using
inheritance in XEmacs is exactly the right thing. AFAICT, if the only
use of (current-local-map) in that buffer is the one you cite,
inheritance and the shared list structure at identical. However if
that map is accessed (other than by keyboard commands, of course) in
other ways, it might matter. I don't have the context to judge.
Yes. I thought it was a bit strange too. After the new keymap is
created I would assume that the parent keymap is the last thing you
would want to access.
We could change the XEmacs API, but I don't know if it would be worth
it.
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
6:53 p.m.
>>>> Stephen J Turnbull <stephen(a)xemacs.org> writes:
I don't have the context to judge.
I was looking at file-lisp.el in GNU Emacs. It was required by a
recent version of the go-mode (the mode for the go programming
language).
While I was checking how to convert that to XEmacs (this thread)
another version of go-mode arrived and removed the issue! ;-)
So whether find-lisp.el fits into the XEmacs packages became an issue
on its own and then maybe not that interesting!? It implements
functionality of the find command in lisp. So far it seems to be a
good idea but it is used only in a small number of places in GNU Emacs
itself. So it might be functionality not normally needed.
We could change the XEmacs API, but I don't know if it would be
worth it.
Don't think so. For better or for worse it is compatibility we are
after.
Yours
--
%% Mats
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
12:51 p.m.
Mats Lidell writes:
>>>>> Stephen J Turnbull <stephen(a)xemacs.org>
writes:
> We could change the XEmacs API, but I don't know if it would
be
> worth it.
Don't think so. For better or for worse it is compatibility we are
after.
By "XEmacs API" I meant `set-keymap-parents' (with an "s"). Of
course
the GNU-compatible `set-keymap-parent' has to stay GNU-compatible.
Steve
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
1:51 p.m.
>>>> Stephen J Turnbull <stephen(a)xemacs.org> writes:
By "XEmacs API" I meant `set-keymap-parents' (with an
"s"). Of
course the GNU-compatible `set-keymap-parent' has to stay
GNU-compatible.
OK. Even though -- too subtle for my taste. It would be hard to
remember the difference.
Yours
--
%% Mats
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
4275
days inactive
4278
days old
6 comments
2 participants
participants (2)
-
Stephen J. Turnbull -
The XEmacs Package Smoketest