Vaclav> Steve Youngs wrote: VB> 2002-03-04 Vaclav Barta <vbar(a)comp.cz&gt; VB> * jde.el: use get-file-buffer to map pathname to buffer Vaclav> Er, I've been looking at JDE upstream, and it seems (I didn't test) that Vaclav> the problem is already fixed in a new beta (2.2.9beta9.1). I do think Vaclav> the fix is sub-optimal - it uses (the same) lambda in Vaclav> jde-save-close-buffer and jde-save-variable, where get-file-buffer could Vaclav> IMHO be used instead - but I'm not sure whether such details are worth Vaclav> gold-plating... Perhaps there are compatibility problems with Vaclav> get-file-buffer? Vaclav> Bye Vaclav> Vasek Vaclav> P.S.: on the other hand, looking at the jde-save-variable again, how is Vaclav> it Vaclav> supposed to work? The fixed (note the comment) lambda is Vaclav> (lambda (buf) Vaclav> (let* ((directory-sep-char ?/) ;; XEmacs defaults to backslash Vaclav> (buf-file-name (buffer-file-name buf))) Vaclav> (and buf-file-name Vaclav> (string= (car project) Vaclav> (expand-file-name buf-file-name))))) Vaclav> Apparently buffer-file-name depends on the value of Vaclav> directory-sep-char (not that it's documented); but isn't Vaclav> directory-sep-char above declared just locally, i.e. a Vaclav> different variable from the global one? clearcase.el, before it became the clearcase package, used to cause buffer file names to use ?\ as separator, irregardless of directory-sep-char. This is bad! It showed up as a mix of / and \ separated filename paths in the *Buffer List* (those before clearcase was loaded, and those after) :-( Do you see something like this in jde too? Under Windows, the cygwin build sets directory-sep-char to ?/ and the native build sets it to ?\ and packages must be able to deal with both. I can even change directory-sep-char in the middle of my XEmacs session and things still work. Does jde keep the local binding of directory-sep-char internal, or does it cause any external side-effects (like clearcase used to)? Best regards, Adrian -- Adrian Aichner mailto:adrian＠xemacs.org http://www.xemacs.org/

Paul> Adrian Aichner writes: Paul> It always uses it locally to avoid external side Paul> effects. There are lots of places where the JDE has to Ah, great! Paul> compare paths. It "normalizes" all paths to use forward Paul> slashes to permit valid comparisons. The native Windows Paul> version of XEmacs is the only version of Emacs that uses Paul> backslashes in the paths that it returns, thus potentially Paul> invalidating comparisons. Declaring directory-sep-char to be Paul> / locally and temporarily within JDE functions forces the Paul> native Windows version of XEmacs to behave like the other Paul> versions of Emacs and thus assure that the JDE will work on Paul> the native Windows version of XEmacs without a mass of Paul> special-case handling code. Sounds good, thanks! Adrian Paul> - Paul -- Adrian Aichner mailto:adrian＠xemacs.org http://www.xemacs.org/

Paul Kinnucan wrote: OK, I'm honored... :-) OK - I guess I have a lot of Lisp to learn... Bye Vasek