>>>> "Stephen" == Stephen J Turnbull
<stephen(a)xemacs.org> writes:
Stephen> APPROVE COMMIT web
Hi Stephen, your patch looks good, thanks!
Stephen> Adrian, it looks like the validation bugs are fixed.
Stephen> Yeah! But the 1 sec timeout on wget for setup.{ini,exe}
Stephen> are way too low (ask Hrvoje).
Ah, that 1 goes back to the time when our DNS records tool
www.xemacs.org out of business. It kept the timeout short but now
proves to be too small from my computer too. I didn't figure out why
wget wasn't working lately. Thanks for the hint!
Stephen> Also, the %.elc: %.el rule probably should not come
Stephen> before all:.
Why? This would be for stylistic reasons since pattern rules don't
qualify as default targets, right?
I'll make the change anyway.
Stephen> I question whether all: should depend on namazu and
Stephen> wgetting setup.*. Those seem to be maintainer targets,
Stephen> they're annoying for us ordinary contributors.
Target all is not the default. It makes everything and is used
explicitely by commit-trigger on our three master websites.
I'll make validate the default target and make it lean'n'mean.
Thanks for your testing!
Best regards,
Adrian
--
Adrian Aichner
mailto:adrianï¼ xemacs.org
http://www.xemacs.org/